Forum Replies Created
-
AuthorPosts
-
November 20, 2024 at 10:04 am in reply to: Bug – Abuse of /?avia_extended_shop_select= queries #1471720
Following on from this
I can 100% confirm this was the cause of our server issues.
Essentially ALL Enfold websites with WooCommerce installed will gradually use up the ram and see mysql memory usage rise until the server crashes.
The bots getting stuck crawling all of the ?avia_extended_shop_select=yes queries includes:
Even with the rel-nofollow:
Bing bot
Google bot
A majority of major search engines
AI crawlers – New aggressive bots that ignore all instructionsSee screenshot of the before and after. Our Ram use fell from almost 90GB of ram used to 8GB used on average.
Physical Ram usage screenshot
https://www.dropbox.com/scl/fi/tw8p399gfdr9cclorc5j9/ramuse-screenshot.PNG?rlkey=d9ty4xvui4w3m2ycb9b9ez94s&st=28aameqn&dl=0
Mysql memory usage screenshot
https://www.dropbox.com/scl/fi/iixhdd5vpe7253tbavbxf/mysql-memory-usage.PNG?rlkey=15061shf0haiu3d36cdy0be3t&st=ep9fncx5&dl=0SOLUTION
I propose that Enfold removes the custom sort by options and reinstates the default Woocommerce ones.
The defaults use form fields and JS so there are no a href links in the default woo sort by dropdown. Bots cannot follow these links because there are no urls in the HTML.In your child theme functions.php add the following to remove the enfold filters and reinstate the woo ones.
// remove the enfold sort by filters function avia_woocommerce_frontend_search_params() { return; } // reinstate the woo default sort by filters add_action( 'woocommerce_before_shop_loop', 'woocommerce_catalog_ordering', 20 );
Add the following CSS to quick CSS and tweak depending on your sidebar position:
.sort-param-count { display:none; } .product-sorting { padding-top:0px; } div .product-sorting ul, div .product-sorting li { font-size: 16px; } div .product-sorting ul { width: 200px; } .main_color .sort-param a { color: #000000; } .sort-param-sort a, ul.sort-param-order { border: 1px; border-color: #969696; border-style: solid; } @media only screen and (max-width: 767px) { .responsive #top .woocommerce-ordering { position: relative; float: left; clear: both; margin: 0; padding-bottom: 25px; padding-top: 15px; top: 0px; } } @media only screen and (min-width: 768px) { .responsive #top .woocommerce-ordering { position: relative; float: left; clear: both; margin: 0; padding-bottom: 25px; padding-top: 15px; top: 0px; } } #top.woocommerce-page .woocommerce-ordering select { width: 100%; font-size:16px; }
Install the Redirection Plugin:
Add the following RegEX expression to redirect the queries so that the URL redirects BEFORE the query runs on the DB
Source URL: ^/(.*?)/\?avia_extended_shop_select=.*
Enable: Ignore Case, Regex and Ignore Slash
Target URL: /$1/
Hit Save
This will redirect any attempt to crawl the enfold filters back to the current categoryOctober 28, 2024 at 11:56 am in reply to: Bug: avia-js.js aviajshelpers undefined value plugin compatibility problem #1469993Hi This issue has now been resolved.
Theme Complete have updated the plugin to include the fix.
No action to take this end.
Cheers.
Tom
Thats a good shout! I’ll investigate this further. At least we have identified that the video was the problem not enfold!
Cloud Convert seems to encode well with a good balance of compression. We will try tweaking the settings in VLC as the output file was about 50% smaller.
Hi Guenni,
It was definitely an encoding issue.
We’ve tried re-encoding the video and it runs absolutely fine
I agree about Vimeo and youtube – But we have a specific use case for this one where it must be self hosted. (A project I hope to share assuming we can iron out the last of the bugs!)
The Location it is scrolling to on the page is also slightly off. Scrolling too far down not showing the accordian tab itself.
We’ve just tried re-encoding the video using cloud convert as an acid test….
This works. Looks like our encoding wasnt right.
Thank you for your help – Looks like we need to check the mp4 encoding settings.
I’ve sent it to the email on your website. Thanks Guenii, Really appreciate your help.
Hi Gunter,
This seems to work ok if you go from a different url to a specific tab or you have anchor links on the same page
However when you then change the ID in the address bar manually
I.e.
Copy and paste the url of the page the accordion is on with the ID hash:
/pagewithaccodion/#toggle-id-1Then if you click in the address bar and change the #toggle-id-1 to a different ID like #toggle-id-2 then accordion toggle 2 vanishes and shifts off the page.
So its nearly there but something isnt right still.
Thanks Gunter
Well swap it on our test site and reply back shortly.
We’ve tested it – The video you have used works.
@guenni007
can you confirm what software you used to compress or encode the video?We’ve used VLC media player to encode ours which is a free software.
But we have Adobe Premier Pro and Adobe Media Encoder.
Hi Guenni007,
Thanks for this. I can see it seems to be working on your test server.
This is odd as our test was stock enfold without a child theme.
Im going to download your video from your test site and try looping that in our demo site and see if it works.
Hi Ismael,
We are using self hosted videos, not youtube. I imagine that youtube will work correctly because of how the embed works.
Can you try uploading a video. See the link in private below;
You can see the video plays once and then when it repeats the video doesnt actually play it just lags and plays the last second of the video.
This applies to all enfold elements
Colour section background video
Easy Slider
Full width easy slider
full screen background slider
ALB video element itself.The problem is with self hostred videos.For speed and latency reasons it would be better to host a small repeating background video locally vs on a public platform.
Hi Gunter,
No change here.
It still doesnt work.
If you open one accordian tab and change the # to the next tab in the list it disappears completely.
On the demo page we sent over if you enter any of the accordian # anchors into the searchbar the current one disappears.
The css jumps and the toggle disappears off the page to the side
If you refresh your screen the toggle is correctly displayed.
we have tried chrome, firefox and edge. We have also tried 2 different computersSee if it happens your end. If not we will send a loom video
To add – sometimes it works when you go from a different URL to the one with the #toggle id.
Really confused!
- This reply was modified 1 month, 3 weeks ago by thinkjarvis.
Hi
This requires investigation none of the video options are looping in the current version of enfold (6.04)
Please can you take a look at this in a clean version of enfold
Thank you- This reply was modified 1 month, 3 weeks ago by thinkjarvis.
Disabling the plugins and our changes to functions.php don’t seem to have helped. The toggle seems to completely disappear when the ID is used in the URL.
Hi Gunter,
I’ll try disabling the plugins and report back.
Hi Günter
that doesnt seem to have helped it is now not scrolling at all though it is opening the right tab
September 30, 2024 at 1:31 pm in reply to: Bug ?avia_extended_shop_select=yes breaks the filters #1468104Solution: Reinstate the default woo dropdowns – Applies to all Enfold sites:
The default woo filters are dequeued in enfold > config-woocommerce > config.php and config-365.php
We can requeue them and disable the Enfold filters by adding the following to functions.php in the child theme:
// Removes Enfolds sort by dropdowns function avia_woocommerce_frontend_search_params() { return; } // Re-adds the default sortby dropdown add_action( 'woocommerce_before_shop_loop', 'woocommerce_catalog_ordering', 20 );
Styling fixes
Add the following css:@media only screen and (max-width: 767px) { .responsive #top .woocommerce-ordering { position: relative; float: left; clear: both; margin: 0; padding-bottom: 0px; padding-top: 15px; top: 0px; margin-top:60px; } } @media only screen and (min-width: 768px) { .responsive #top .woocommerce-ordering { position: relative; float: left; clear: both; margin: 0; padding-bottom: 15px; padding-top: 15px; top: 0px; margin-top:0px; } } #top.woocommerce-page .woocommerce-ordering select { width: 100%; font-size:16px; padding: 8px; line-height: 1.2em; }
- This reply was modified 1 month, 3 weeks ago by thinkjarvis.
September 19, 2024 at 7:47 am in reply to: Bug ?avia_extended_shop_select=yes breaks the filters #1467424Essentially this doesn’t work:
?avia_extended_shop_select=yes&product_order=price – Only works on shop root and not categories or filtered items
?avia_extended_shop_select=yes&product_order=price&product_sort=desc
?avia_extended_shop_select=yes&product_order=price&product_sort=ascBut these work just fine:
?orderby=price-desc – without any extra params – just like storefront theme
?orderby=price-asc – without any extra params – just like storefront themePlease can we change this in Enfold for compatibility?
Why do we even need to alter these from the woocommerce defaults?
?avia_extended_shop_select=yes
&product_order=pricewhen there is a new single parameter query for sorting by price:
?orderby=price-desc
?orderby=price-asc- This reply was modified 2 months ago by thinkjarvis.
September 19, 2024 at 7:05 am in reply to: Bug ?avia_extended_shop_select=yes breaks the filters #1467420If you look at the default store front theme
It has two filters not three I think this is the root cause of the problem.
https://themes.woocommerce.com/storefront/shop/?orderby=price-desc
https://themes.woocommerce.com/storefront/shop/?orderby=price-ascWhy are we adding the extra parameter for
?avia_extended_shop_select=yes
and
product_order=price when the default woo filters dont use these queries at all?Is there a way to just use the default woocommerce filters instead of the modified Enfold ones?
- This reply was modified 2 months ago by thinkjarvis.
- This reply was modified 2 months ago by thinkjarvis.
Thanks Ismael,
We couldnt get this to work for some reason.
We’ve used a full screen background slider for now which does the job just fine for our design intent.
I’ll test this again when we are next doing a video background element.
Going back to your original question and a solution for you:
It would be an excellent feature for Enfold to Automatically do its own version of Remove unused CSS to bring the number of JS and CSS files down per page.
However if you wanted to do this using a plugin WP-Rocket and others come with remove unused CSS or RUCSS as it is known. I have had good results with Enfold and RUCSS in WP-Rocket. Seems to work without specifying any fallback css or exceptions.
RUCSS is not perfect however. So if Enfold could add an option to only load the CSS for used elements per page it would be a 100% compatible way of doing RUCSS without the unreliability of systems that attempts to work it out after css file generation.
I’d be keen to know what Gunter thinks of this idea. It is essentially an extension of the current only load used elements function.
Performance advice and how it works in reality
All of this said – Once a browser has downloaded the files – Assuming you have a long cache life on your CSS and JS files in your HT Access file (Or set this value with a plugin like WP-Rocket or WP Super cache, etc.) then those files wont be re-downloaded by the visitors browser per page visit. So even if they have to download 100kb worth of CSS and JS to view page 1. page 2,3,4,5,6 etc onwards will use the cached css loading instantaneously.The minimum requirement for this to happen is page caching with a good cache life.
If you want any more advice on this sort of thing let me know.
https://www.hirekaraoke.co.uk/
The site above is one of ours and passes web vitals. They are the UKs largest Karaoke Hire company. So a national business. This site uses our performance stack including page caching and some bespoke settings. The actual booking pages are completely uncached (Which is why the TTFB score is a little higher on desktops – brings the average response time up). The site just serves minified CSS. It is not necessary to RUCSS to pass web vitals if everything else is done correctly.- This reply was modified 2 months, 2 weeks ago by thinkjarvis.
September 2, 2024 at 2:10 pm in reply to: Bug: Cannot turn off sonar animation on ALB icon element #1466045Cheers, Ismael / Gunter hope all is good your end,
The new global custom ALB layout system in 6.0+ is an excellent addition by the way. We’ve made good use of this so far.
I have a lot of projects I need to post on the showcase from the past 12 months so will try and get them up there when I get a minute.
August 26, 2024 at 2:12 pm in reply to: Bug: Cannot turn off sonar animation on ALB icon element #1465415Hi Ismael,
I can confirm the problem occurs in stock enfold.
You can see it in the test area shared in the private data
Let me know if we can get a fix – It has caused us a problem on some existing sites that suddenly started animating even when disabled.
Hi Mike,
Sorry for the duplication – I forgot I had a thread on this already. I have posted this on both threads.
Unfortunately what you have suggested doesnt work. BUT IT SHOULD!!!
Using the documentation guide – This works:
add_action( 'ava_after_main_title', 'enfold_customization_blog_widget_area', 50 ); function enfold_customization_blog_widget_area() { $check_tjnewswidget = true; if ( is_home() ) { $check_tjnewswidget = false; } if( !$check_tjnewswidget ) { dynamic_sidebar( 'blogheaderwidget' ); } }
Not quite as per documentation but I like using the true and false method of determining if something is a particular thing.
Hi Mike,
Unfortunately what you have suggested doesnt work. BUT IT SHOULD!!!
Using the documentation guide – This works:
add_action( 'ava_after_main_title', 'enfold_customization_blog_widget_area', 50 ); function enfold_customization_blog_widget_area() { $check_tjnewswidget = true; if ( is_home() ) { $check_tjnewswidget = false; } if( !$check_tjnewswidget ) { dynamic_sidebar( 'blogheaderwidget' ); } }
Not quite as per documentation but I like using the true and false method of determining if something is a particular thing.
- This reply was modified 2 months, 4 weeks ago by thinkjarvis.
August 26, 2024 at 12:08 pm in reply to: Bug: Cannot turn off sonar animation on ALB icon element #1465409Hi Ismael,
I’ll fire up a blank Enfold theme and double check. Our standard setup however is pretty much Stock Enfold. The plugins we use don’t alter the core Enfold system.
Will reply once Ive set it up.
See test area showing issue where my two widget areas are both showing on the shop when it only used to show one in the previous enfold version.
Sorry the issue here is the hook above never used to load on shop pages. It now loads on all pages which is causing the button I would normally load on the shop to not work because both filter news and filter products buttons are visible.
Can we get a new hook that only adds a widget area to the Blog in the same way that the before shop look adds a widget area before the products in the shop?
This is quite urgent see this post for context: https://kriesi.at/support/topic/hook-to-add-widget-area-above-blog-loop/
-
AuthorPosts