Hi,

4.5.4 has integrated the fix you did before manually. You should be OK to keep this version ans you can update the other sites also.
Let me know when you are done.

Best regards,
Günter

Hi,

I will try to login tomorrow and try to add the changes to the php files in madomains.com as a first step.

Best regards,
Günter

Hi,

I wrote a small script that creates a logfile in the uploads folder: …/uploads/avia_logfile/log.txt in case it encounters again undefined index.

In enfold\config-templatebuilder\avia-template-builder\php\shortcode-template.class.php line 413:

		
			if(empty( $this->builder->disabled_assets[ $this->config['shortcode'] ]) || empty( $this->config['disabling_allowed'] ) )
			{
				$content = $this->shortcode_handler($atts, $content, $shortcodename, $meta);
			}

Before $content insert:

			if( ( ! defined( 'DOING_AJAX' ) || DOING_AJAX !== true ) && ( ! isset( $meta['index'] ) ) )
			{
				$upload_dir = wp_upload_dir();
				if( ! empty( $upload_dir['basedir'] ) )
				{
					$log_dirname = trailingslashit( $upload_dir['basedir'] ) . 'avia_logfile';
					if( ! file_exists( $log_dirname ) )
					{
						wp_mkdir_p( $log_dirname );
					}
					
					$logfile = trailingslashit( $log_dirname ) . 'log.txt';
					$data = date('d/m/Y H:i:s', time()) . ': shortcode_handler_prepare - $meta[index] not set for ' . $shortcodename . "\r\n";
					
					file_put_contents( $logfile, $data, FILE_APPEND );
				}
			}

Make a backup of the original file for a fallback and keep an eye on the logfile as there is no length check.

To check that the file will be created replace

$meta['index']

in the first line with

$meta['xyz']

and load a small page with ALB content. The file should be created and contain some lines. Replace xyz with index again.

Best regards,
Günter

Hi,

Thanks for reporting this.

Sounds strange – because Enfold does not hook into any checkout logic – and we did not get any similar bug reports.

Can you try to reproduce the problem and then try to disable all other not needed plugins and check ?

Best regards,
Günter

Hi,

Sorry for the late reply but I got tagged for this topic today for the first time – and I did not find a report about that in our dev. repo before.

To make it easier for me to reproduce – could you give me a WP admin account for your backend and a link to the page pls so I can have a look?
Thx in advance.

Best regards,
Günter

Hi,

Strange.

Are the login credentials still valid?
And can you also give me the link to the page pls?

Best regards,
Günter

Hi,

Thanks for the feedback. Now I can reproduce it.

I will add this to our dev repo and will try to find a fix asap.

Best regards,
Günter

Hey Alexander,

Try to use the filter avf_alb_supported_post_types ( Avia_Builder()->get_supported_post_types() ) and add your post types to the array.

Best regards,
Günter

Hey guenther_baur,

Danke dass Du Enfold verwendest.

Dein Theme ist total veraltet (3.6.1 ist von 2016 June 6th).
Wir haben momentan 4.5.3.

Bitte update einmal auf die letzte Version. In jedem Fall ein Backup machen für ein fallback.

To update to the latest version follow the simple instructions here. (Or if you want the super detailed explanation you can read this blog post)

LG,
Günter

Hi,

Can you try to replace (around line 353)

if( defined( 'REST_REQUEST' ) && REST_REQUEST && ( $post instanceof WP_Post ) )

with

if( $post instanceof WP_Post )

I uploaded the changed file.

Best regards,
Günter

Hi,

I installed the ACF plugin on my server and can reproduce what you mean.

The output of the modal box is sent to the active editor TinyMCE – means when you have 2 editors and click in the second editor this becomes the active one.

If you then open the modal window with the button of the this second editor your input is correctly placed in the position of the cursor of this second editor because this is the active editor.

If you open the modal window with the button of the first editor instead your input is still placed in the position of the cursor of the second one because this is still the active editor.

In my opinion if you want to add a shortcode to the text in an editor you want to control where the code is inserted – and click in the editor to have the cursor at that position – and in this case that editor becomes the active one and the code is placed at the cursor position. And this is from my point of view a consistent behaviour.

You can check this in enfold\config-templatebuilder\avia-template-builder\assets\js\avia-tinymce-buttons-4.js – look for tinyMCE.activeEditor.

Best regards,
Günter

Hi,

I’ve found a possible solution. Can you please replace

enfold\config-templatebuilder\avia-template-builder\php\shortcode-template.class.php

with this file:

https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_4_5_3/shortcode-template.class.php

Do not forget to make a backup of the original file for a fallback.

The changes can be found in function shortcode_handler_prepare line 315 ff.

I asked Kriesi to recheck that these changes do not have a negative impact – if not it will become part of the core.

Best regards,
Günter

Hi,

I’ve found a possible solution. Can you please replace

enfold\config-templatebuilder\avia-template-builder\php\shortcode-template.class.php

with this file:

https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_4_5_3/shortcode-template.class.php

Do not forget to make a backup of the original file for a fallback.

The changes can be found in function shortcode_handler_prepare line 315 ff.

I asked Kriesi to recheck that these changes do not have a negative impact – if not it will become part of the core.

Best regards,
Günter

Hi,

Thank you for reporting this – and sorry for the problems.

I opened a bug issue for that in our dev repo.

Cause is, that Gutenberg saves changes via REST API calls. We probably missed to create output of ALB content on regular calls.
We try to fix it asap.

Best regards,
Günter

Hi,

There has been a fix added in version 4.5.3.
Can you check with this version please?

Best regards,
Günter