Forum Replies Created
-
AuthorPosts
-
Hi Roger,
Thank you for helping to improve Enfold.
I merged your pull into core, fixed the typos 2 + 3 – already in core.
I made a sync including the latest updates and all language files and uploaded it to github https://github.com/KriesiMedia/enfold-language-files.
For your dutch there are now 2 untranslated strings remaining – probably the fixes I made.
Concering the select box: The content is coming from a standard WP function call – should actually be translated by WP (?). But I will check when I have a spare time.
Best regards,
GünterAugust 16, 2020 at 10:24 am in reply to: Conflict: “Essential Grid” Enfold Media Content “Image with Hotspots" #1238114Hi,
Thank you for this information. I will close this thread.
Feel free to come back when you need further assistance.
Enjoy the theme and have a nice day.Best regards,
GünterAugust 14, 2020 at 6:18 pm in reply to: Masonry Gallery breaks with Lazy Load and WordPress 5.5 #1237906Hi Rob,
Exactly. Jetpack is overriding Enfold. ( and probably also WP, because it handles lazy loading for its own with js which will get in conflict with the html attribute).
If you have time you can keep jetpack lazy loading disabled and enable Enfold lazy loading for each element and check, if a page works as expected – would mean that at least modern browsers can take advantage of this feature – without any overhead of javascript. Older browsers simply ignore this attribute.
Best regards,
GünterAugust 14, 2020 at 5:21 pm in reply to: Masonry Gallery breaks with Lazy Load and WordPress 5.5 #1237897Hi Rob,
Thanks for reporting this.
Enfold uses the WP lazy load logic added with WP 5.5 adding the HTML attribute Loading=”lazy” to images which is supported by modern browsers without any js.
As we are aware that there are problems with animations and lazy load we disabled it by default for existing sites and you can activate it for each element (option in developers tab) to check, if nothing is broken.
We had reports for problems with jetpack, lazy loading and broken layout – as jetpack uses js.
As far as I know jetpack offers a filter to add classes to images to supress lazyloading for these – but this is currently not part of Enfold.We have an open issue for that.
Best regards,
GünterHi,
Thank you for giving us access to your dev server.
Finally I could locate the problem: $params was not an array but a query string.
I added in line 1628 (enfold\config-woocommerce\config.php):
$params = wp_parse_args( $params );
This should fix the problem.
Best regards,
GünterHi!
Added to next release:
If WP Option “Search engine visibility” is checked:
<meta name="robots" content="noindex, nofollow" />
will be added (if theme option Meta tag “robots” is set to Use Enfold default settings).
Cheers!
GünterHey!
Thanks for sharing the fix.
Will be added to next release – should come in the next days (as WP 5.5 is close to release).
Best regards,
GünterHey Jan,
If this is dutch language – there are missing/wrong translations causing this.
Please update
enfold\lang\nl_NL.mo
enfold\lang\nl_NL.powith
https://github.com/KriesiMedia/enfold-language-files/blob/master/lang/nl_NL.mo
https://github.com/KriesiMedia/enfold-language-files/blob/master/lang/nl_NL.poIf you need assistance please provide us ftp access so we can upload it for you.
Best regards,
GünterHi,
Ich habe einmal eine “Clean functions.php” hochgespielt (functions_clean.php). Mit dieser funktiniert V2 und (nach einigen clear browser cache) auch V3. Habe für beide ein autoresponder Mail erhalten. Du solltest in deinen somit auch einige erhalten haben – Testseite siehe unten.
Hab es auch als nicht angemeldeter Benutzer in Chrome in einem normalen Fenster getestet.
Ich habe wieder auf die alte functions.php umgestellt.
Irgend ein code in Deiner functions.php dürfte somit etwas stören. Wäre interessant, das zu eruieren. Vielleicht kann man dann einen Fix einbauen auch für andere User, die Probleme haben.
Best regards,
GünterAugust 3, 2020 at 12:30 pm in reply to: Optimizing images: Should I use more than 1 version? #1234799Hi,
WP creates the srcset from images with the same aspect ratio ( +/- 1 px ) as the image you are displaying.
This means if the displayed image has e.g. 700px * 700px thumbs with a aspect ratio of 1:1 are considered responsive for scrset.
If your displayed image e.g. has 1280 * 720 ( 16 : 9 ) and you do not have thumbs with 16 : 9 the image does not get any scrset.
You find a list of thumbs in Enfold Options page -> Performance -> Responsive Images -> Image Thumbnails Info.
If you need responsive images for 16 : 9 you will need to add additional image thumb sizes for 16:9.
Best regards,
GünterHi,
Strange. Could you provide me ftp access please? I might need to add some debugging code to php and I do not like to do that without ftp in case I crash the site.
And I’m afraid I will also need some time to find the problem.
Best regards,
GünterJuly 30, 2020 at 11:39 am in reply to: Optimizing images: Should I use more than 1 version? #1234130Hi,
The reason why the images are not visible is a CSS rule:
img[data-lazyloaded] { opacity: 0; }
located in a script from litespeed.
WP creates the srcset from images with the same aspect ratio ( +/- 1 px ). Do you have thumbs that have the same aspect ratio as the original image?
You find a list of thumbs in Enfold Options page -> Performance -> Responsive Images -> Image Thumbnails Info.Best regards,
GünterHey Guenter,
Could you please provide us a link to a page where we can see the problem with credentials for backend (we need to disable file merging to debug js).
Best regards,
GünterJuly 27, 2020 at 12:58 pm in reply to: 4.7.6. – added: alt attribute to fixed size masonry background image container #1233511Hi,
Lösung wird ziemlich sicher Teil der nächsten Release werden.
Einen schönen Tag noch.
Best regards,
GünterJuly 25, 2020 at 5:21 pm in reply to: 4.7.6. – added: alt attribute to fixed size masonry background image container #1233222Hi,
Am ersten Blick sehe ich, dass Du das js script im child theme lädst – und das ist nicht die Version von github (sondern eine alte Originalversion von Enfold).
HTML markup ist korrekt mit title und alt.
Im Parent theme ist die korrekte version von avia-snippet-lightbox.js – wenn diese geladen wird (und cache löschen) sollte es funktionieren.
Da functions.php sehr gross, möchte ich da nichts ändern.
Best regards,
GünterHi,
Thanks, yes, I missed it. Will be part of next update.
If you want to update, you can replace
enfold\framework\php\function-set-avia-frontend.php
with
Best regards,
GünterJuly 25, 2020 at 3:38 pm in reply to: 4.7.6. – added: alt attribute to fixed size masonry background image container #1233209Hi,
Hab eine Lösung ohne das Originalscript ändern zu müssen.
Update die beiden oben angeführten Dateien.
Lösung findest Du in avia-snippet-lightbox.js die beiden Funktionen:
titleSrc
markupParsea) Wenn kein titel vorhanden, dann wird mfp-title versucht mit alt zu befüllen
b) mfp-img erhält jetzt das alt attribute jetzt auch bei Hintergrundbild, soferne vorhandenBest regards,
GünterJuly 24, 2020 at 4:50 pm in reply to: 4.7.6. – added: alt attribute to fixed size masonry background image container #1233043Hey Guenter,
Not sure if this is what you meant, but I extendend the lightbox script that when no title attribute exists (which currently leads to an empty title string in lightbox) it searches for the alt attribute and displays it instead.
And for the fixed size I also copy the alt attribute to the a tag.
Does that make sense?
To check use 4.7.6.1 and replace
enfold/js/avia-snippet-lightbox.js and
enfold/config-templatebuilder/avia-shortcodes/av-helper-masonry.phpwith:
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_4_7_6_1/lightbox_fix/avia-snippet-lightbox.js
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_4_7_6_1/lightbox_fix/av-helper-masonry.phpBest regards,
GünterHi,
We will do, but if you find something please report it. Helps us to speed up fixing.
Thanks in advance.Have a great day.
Best regards,
GünterHi,
Thanks for this info. I’m pretty sure that was missing also in previous versions.
I merged it for the next update.
Have a nice day.
Best regards,
GünterJuly 21, 2020 at 12:23 pm in reply to: Google Maps "Retired Version" warning showing up again #1232011Hi,
Thanks for this info.
It will be updated to 3.41 in the next release (4.7.5.1). Will be coming in the next days.Best regards,
GünterHi,
Glad we could help you. Enjoy the theme and have a nice day.
Feel free to come back when you need further assistance.
Best regards,
GünterJuly 17, 2020 at 11:53 am in reply to: Feature request: Lazy load compatibility fix and Idea for plugin compatibility. #1231201July 17, 2020 at 10:08 am in reply to: Optimizing images: Should I use more than 1 version? #1231151Hi,
Our latest beta version (4.7.5.1-beta-3) includes support for all ALB elements. If you are interested in testing, please open an own thread and we can give you a link to it in private content when it is ready.
Thanks for pointing at lazy loading. I added this to our dev repo and we will adress it asap.
Best regards,
GünterJuly 17, 2020 at 10:02 am in reply to: Feature request: Lazy load compatibility fix and Idea for plugin compatibility. #1231149Hi,
I added the WP lazy loading to our dev repo. We certainly will address it in near future – not sure if we can get it for our next release.
According jet pack lazy loading.
As there are many plugins around adding this to core will not be possible. But we think about adding filters so we can allow extension plugins to hook and do the changes they need. This is more flexible and easier to maintain.
Best regards,
GünterHi,
I agree – it is in the duty of the website owner to add a GDPR complient content to the Maintenance mode page.
As you say – you can create a simple page …..
The only thing that Enfold can do is not to load scripts like Google fonts and other services Enfold offers on that page when maintenance mode is enabled.
But that’s it.
Best regards,
GünterHi,
Sorry for the late reply.
I added it to our dev repo as a feature request.
Best regards,
GünterJuly 16, 2020 at 10:37 am in reply to: gelöschte Bilder als eine Art Beitrag über URL zu finden #1230867Hi,
@VariablerEsel
Danke für diese Info.
Ich schliesse dieses Topic. Sollten weitere Fragen auftreten, bitte ein neues Topic anlegen.
Einen schönen Tag noch.Best regards,
Günter -
AuthorPosts