Hi,

see private content.

Best regards,
Günter

Hi @EZWebdesign,

Thanks a lot – already merged into core.

Have a great day.

Best regards,
Günter

Hey Guenter,

As far as I see theme.json is mostly related to block editor. So I would not touch that from Enfold.

What I could think of is adding e.g. all the colors of “General Styling” at top of “dynamic-css.php” e.g.

enfold-header-color-bg: "#...';
enfold-header-color-bg2: "#...';
...
enfold-footer-color-bg: "#...';
....

Best regards,
Günter

Hi Günter,

I added a fix:

Can you replace enfold\framework\php\font-management\class-avia-type-fonts.php

with the contents of

https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_5_1_1/framework/class-avia-type-fonts.php

This should load in the order of woff2, woff, ttf, svg, eot (if they exist).

You can use filter ‘avf_font_manager_file_formats’ to add additional formats or reorder as you like.

Can you check please.

Best regards,
Günter

Hi,

if you check enfold\js\avia-snippet-lightbox.js line 21:

fixedContentPos: 	false, // allows scrolling when lightbox is open but also removes any jumping because of scrollbar removal

Changeing this to true will do it.
There was probably a reason why it was added.

As far as I know there was no request up to now – so I would suggest to add a filter to activate this.

Edit:

added: filter ‘avf_default_lightbox_no_scroll’ – block default lightbox and body from scroll

return anything except false (e.g. true) in filter

Best regards,
Günter

• This reply was modified 2 years, 5 months ago by Günter.

Hey Guenter,

A first response:

The basic implementation for responsive in enfold is that you have a setting with no media query (description is desktop – no media query) either in css files or set in options and then media queries that override the desktop setting.

I think this is also a historical reason because responsive was added later.

Changing this will certainly break many sites.

But I agree – there is missing an option with a media query for large screens only (wider than 990px).

This would allow:

• set a custom default value for all sizes (and override theme setting)
• set a custom value for each of the 4 devices independently, if not set the custom default value for all sizes or theme default is used

I will think about it a little more.

This can also be used for font sizes and other responsive settings

Best regards,
Günter

Hi,

Thanks for providing the code.
I added it to core for 5.0.2.

Replace enfold\framework\php\class-media.php:

https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_5_0_1/framework/class-media.php

I had to replace

$query->set('orderby', 'meta_value_num'); 

with

$query->set('orderby', 'ID'); 

and

 remove $query->set('meta_key', 'post_attachments_id');

Best regards,
Günter

Hi Tim,

Please try to update enfold\config-woocommerce\config.php with the content of

https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_5_0/config-woocommerce/config.php

This should now show responsive images or the “large” image (if theme option Responsive Images For Lightbox is disabled). You can change the default lightbox image size with filter avf_avia_builder_helper_lightbox_size.

@guenni007

If you set ratio to > 1 @2x is added.

If theme option Responsive Images For Lightbox is disabled I get “Image could not be loaded” (because I do not have such a file uploaded), with option enabled I get the correct image responsive image (without @2x).

Best regards,
Günter

Hi,

Sorry for that.

A modified fix is integrated in the latest release 5.0 published yesterday.
Can you check with this version if the problem is fixed please.

Best regards,
Günter

Hi,

@thinkjarvis

Thank you for bringing this up.

I checked the font behaviour of the “Special Heading” element with 4.8.3 (a version prior the post css file changes).

Setting Heading Font Sizes – Font Size (Default) to e.g. 50px, responsive Font sizes to “Use default”.

The 50px are used for all devices (because added inline in a style tag).
There is a media query in heading.css:

@media only screen and (max-width: 767px) {
	#top #wrap_all .av-inherit-size .av-special-heading-tag{ font-size: 0.8em; }
}

And this is what I missed to implement when switching to post css file implementation.

And the only difference I can see.

Would adding this help you ?

And I’m also thinking about extending the selectable font sizes with flexible units also for responsive:

vw
em
rem

Maybe an option for pro users to replace the dropdown with input boxes ?

Best regards,
Günter

Hey!

For your information:

This problem is fixed in oncoming version 5.0.

You also have a new option “Deeplink String” (Advanced Tab -> Developer Settings) where you can define a custom lnk hash for the tab.

Cheers!
Günter

Hi,

In addition to @Guenni007:

If you only modify class-avia-masonry.php you can copy the original file to “$template_url.’/shortcodes/'” and your copy will be loaded before the original file preventing loading this.

There is no need for a directory structure.

Only in case you need control which modified files in your child theme must be loaded before other files you can create a directory structure but must add this structure e.g.

add_filter('avia_load_shortcodes', 'avia_include_shortcode_template', 15, 1);
function avia_include_shortcode_template($paths)
{
  $template_url = get_stylesheet_directory();
      array_unshift($paths, $template_url.'/shortcodes_1/', $template_url.'/shortcodes_2/' );

  return $paths;
}

and then file inside shortcodes_1 are loaded before files in shortcodes_2.

Best regards,
Günter

Hi,

Thanks for reporting this.

Fix will be included in Enfold 5.0.

If you need a temporary fix let us know and we can provide it.

Best regards,
Günter

Hi,

Here you can find a rough overview of upcoming releases:

https://kriesi.at/support/topic/enfold-upcoming-fixes/

Best regards,
Günter

Hi,

Thank you for reporting this – and very sorry for the problems.

Icon Grid problem should be solved – please check your staging site. Was caused by a wrong selector to apply the selected font size (resulted in a wrong padding).

Widget problem also solved for ALB Widget area.

Already added for next update 4.9.2.2 which is planned in the next days.

If you do not want to wait you can copy the 2 modified files (do not forget to make backups of the original files for a fallback):

enfold\config-templatebuilder\avia-shortcodes\icongrid\icongrid.php
enfold\config-templatebuilder\avia-shortcodes\widgetarea\widgetarea.php

And you need to save theme options to invalidate the post css files and clear server and browser cache.

Best regards,
Günter