Hi Mike,
I just realized i have never given any feedback, sorry for that. This works flawlessly, thank you so much for that neat script!

Best regards

Michael

Unfortunately the editor removed my indentions, I hope this makes it clearer:

<div id=“product-12345“>
—<div class=“single-product-main-image“>
——<div class=“woocommerce-product-gallery“>
—<div class=“single-product-summary“>
<aside class=”sidebar”>

Hi Ismael,

hmm, strange about the dashboard. Our Geolocation Blocking is off atm, so not sure why it doesn’t work.

I have edited the code, but it still won’t scroll :-(

The link should be entered as ‘#something’ not as ‘something’ in the Deep Link field, right?

What else could I do?
Cheers,
Michael

Hi Ismael,

as written in the first post, I did enter that link in the Tabs options in the Deeplink string, see here: https://cloud.deinhardt.com/s/zo5LonycyDedxo9

No matter if I enter that link as #nebenbuehne1link or as nebenbuehne1link, it doesn’t work.

Cheers,

Michael

• This reply was modified 2 years, 3 months ago by 0rca.

Hi Ismael,

thank you very much for your help. I entered your script via Code Snippets and can see that it is loading, but no scrolling :(
The console gives me this error:

Uncaught Error: Syntax error, unrecognized expression: .av-section-tab-title[href=]
    jQuery 7
    av_trigger_scroll_to_tab https://crimeday.de/crime-day-2022/:4635
    jQuery 8
    av_trigger_scroll_to_tab https://crimeday.de/crime-day-2022/:4631
    <anonymous> https://crimeday.de/crime-day-2022/:4655
    jQuery 13

Do you see what is going wrong? Or what other info do you need?
Cheers,
MIchael

Hi Ismael,

thank a lot. Yes, that new options is the reason we’re doing his. And your code works great now. From your first post I assumed we could just add that one bit, but I understand now that we have to replace the whole array.

This only leaves the other two files, that would have to be edited: /includes/helper-privacy.php (line 1786) and /config-templatebuilder/avia-template-builder/php/generic-helper.class.php (line 928).

Any chance you have an update safe way of editing those up your sleeve ;-)

Cheers,
Michael

Hi Ismael,
thank you for that hint. If I understood you correctly, should it work like this in the shortcode:

array(	
								'type'				=> 'template',
								'template_id'		=> 'screen_options_toggle',
								'templates_include'	=> array(
															$this->popup_key( 'new_breakpoint' ),
															'screen_options_visibility'
														)
							),

and then later in the same file

protected function register_dynamic_templates()
		{
			global $avia_config;
// existing code goes here.................................................
                          /**
			 * Advanced Tab
			 * ===========
			 */
			
			$c = array(
						array(	
									'desc'              => __( 'Hide on very large screens (wider than 1280px - eg: Large Desktop)', 'avia_framework' ),
									'id'                => 'av-desktopl-hide',
									'std'               => '',
									'container_class'   => 'av-multi-checkbox',
									'type'              => 'checkbox'
								),
				);
			AviaPopupTemplates()->register_dynamic_template( $this->popup_key( 'new_breakpoint' ), $c );
		}

The entry shows up in the shortcode popup but it isn’t applied. What am I missing? Naturally I have the correct CSS in place like this:

@media only screen and (min-width: 1280px){

.responsive.av-no-preview #top #wrap_all .av-desktopl-hide,
.responsive.av-no-preview #top #wrap_all .av-desktopl-font-size-hidden,
.responsive.av-no-preview #top #wrap_all .av-desktopl-font-size-title-hidden{display:none;}
}
}

@media only screen and (min-width: 990px)  and (max-width: 1279px) {
.responsive.av-no-preview #top #wrap_all .av-desktop-hide,
.responsive.av-no-preview #top #wrap_all .av-desktop-font-size-hidden,
.responsive.av-no-preview #top #wrap_all .av-desktop-font-size-title-hidden{display:none;}
}

Thanks for your valuable input.
Cheers, Michael

Hi Günter,

awesome, all the upcoming features in 4.6.3 are exactly what has been missing and if the documentation and backend description reflect all that, Enfold is back on track.

Are you saying that disabling [av_privacy_accept_essential_cookies] should have an influence on cookies set by Woocommerce and WPML? I would have to test that, I assumed it wouldn’t…

Thanks for the heads up.

Cheers,
Michael

Just tested a bit further to confirm the above about 3rd party cookie shortcodes and found some strange behaviour. Why is [av_privacy_accept_essential_cookies] enabled by default but third-party shortcodes like [av_privacy_video_embeds] are not? That’s completely illogical.

A user accepting cookies, i.e. opting-in to have cookies saved would never expect that he has to go into the settings and enable each and every cookie separately.

A website user either wants to enable all cookies (with one click), some cookies by en- or disabling some (takes a few clicks) or no cookies at all (with one click).

• This reply was modified 5 years, 2 months ago by 0rca.

Hi Ismael,

thanks for clearing this up. I guess you might wanna update the documentation as well as the shortcode description in the backend to reflect that. I would even suggest to rename the shorcodes, as their names alone bear a lot of potential for confusion.

To be honest, I would have preferred the other way around, i.e. the toggle saying “Enable to only allow essential cookies” – since this is what the GDPR and the latest judgement by the EuGH made mandatory. But from a legal standpoint it doesn’t matter if you allow or forbid with toggle on “on” – the only thing that matters is that the users has a – clearly described – choice. That’s why that description is so very important and why I kept nagging you for the definite explanation.

One other thing: If we don’t use Google Analytics, Google Maps, Google Fonts or Videos, those cookies are still set since they are enabled by default.
Wouldn’t it make more sense, to make it possible to deactivate the shortcodes and also their respective Cookies, if we don’t need them?
Our privacy policy explains that we don’t use any of these service but the cookies are still set to “allow”, if users accept the cookie message bar. That is not good and might even have some legal implications. I know that I can create my own modal popup texts and leave those shotcodes out, but they are still enabled by default.
Thanks a lot for your continued help.

Cheers,
Michael

Hi Ismael,

thanks for taking the time to answer. You misunderstood me, I was talking about the button “Link to another page” in the modal popup. Linking to another page is not working!

Also thanks for updating the documentation. Please believe me, I am not trying to be a pain in the ass, but some question are still unanswered resp. not yet clear. Could you shed some light on these?

• 1. [av_privacy_allow_cookies] refuses ALL cookies or only non-essential ones?
• 2. [av_privacy_accept_essential_cookies] refuses essential cookies additionally to the above? Why does the description say “and all other cookies”?
• 3. The toggle logic is not clearly described in the documentation: When the toggle is set to “on”, what is happening, allow or forbid? Btw, the new wording “allow to refuse” only makes it worse ;-)
• 4. Both toggles are set to “on” on the first visit. Clicking on “Accept” or clicking on “Decline” does not change that. So the logic behind it all is still not clear.

I have updated the test page under http://enfold.muster.website/ Have a look at it and try to switch the toggle of either one shortcode and then click on “Accept” or “Deny” and see if the behaviour is as intended. For me the logic is botched, even considering that I still am misinterpreting some of your explanations the wrong way. Which would be a GDPR issue of its own:

There is a very big danger here for all of us. The GDPR clearly states, that the user has to be informed in clear and concise natural language what his privacy options are. The current solution MIGHT be viable from a technical point of view (not sure yet, that it really is), but it is not clear at all and this opens up all kinds of problems, from unintended misconfigurations to written warnings (Abmahnungen) and other legal risks and issues.

Please continue to work with us, so that we can find an easily working solution as well as an unambiguous documentation.

Best regards
Michael

I forgot one thing. The third button, that we can use in the Modal Popup Window does not work as intended. It should link to another page, right?
It doesn’t, as you can test here: http://enfold.muster.website/ (Open modal and klick on “Ich will hier weg!”)
Btw. that’s where I have been testing all the shortcodes, but the results where inconsistent, so I had to ask all those questions above.

• This reply was modified 5 years, 2 months ago by 0rca.

Hi Ismael,

yep, seems to work fine. Thank you very much for your help!

Cheers,
Michael

Hi Ismael,
you have the login details in the first post.
Let me know, if I can help in any way.
Cheers,
Michael