Viewing 30 posts - 31 through 60 (of 64 total)
  • Author
    Posts
  • #1372784

    Hi,

    Thanks for that. The CSS is targeting an ID which has changed. If you change after_submenu_1 to after_grid_row_1, then it should work as expected for the first section for example. But I would advise that you set the background in a Color Section element instead though, and move the content into that section. Then you don’t have to worry about custom CSS.

    Best regards,
    Rikard

    #1372846

    Hi Rickard,

    I’ve found & changed after_submenu_1 (for the Home Page) in the Styles.css file and the colour does indeed come back, thanks!…however, the alignment of the content boxes is still not correct and the rest of the page customisations are still missing?

    Obviously all of the custom styling has all been done in the site files because of the various custom requirements of the content boxes in the first section and other sections below……it’s not just the colour that has been customised……If you look closely at the two versions of the home page you’ll see what I mean.

    I’m not clear on why the ID would have changed ONLY on the home page either? Shouldn’t having a child theme prevent that? The other pages havent lost their customisations so I’m not clear on why the difference….

    1. Do you know what is causing the other page elements to not work? How should I detect those?

    2. Are you suggesting that all “after submenu #” should be changed to after_grid_row_# &

    3. What’s the best way to be clear on which ID’s have changed in the NEW update so I can update the Styles.css accordingly?

    Thanks in advance

    #1373116

    Hi,

    You can check why the CSS is not applying on your production site by following these steps:

    1. Inspect the element in your browser on your old site.
    2. Find the element ID or class
    3. Check which CSS is applying to it.
    4. Repeat step 1 and 2 on your new site.
    5. Check the difference between the two
    6. Modify the old CSS with updated classes or ID’s.

    If ID’s are changed in core files, then the CSS has to be updated accordingly. It doesn’t really matter if the CSS is placed in a child theme or not.

    The best way to detect changes after updates would be to perform the update on a staging site first, then you wouldn’t introduce problems on your production site. You could also check the theme changelog and check if any of the ID’s or classes you are targeting in your custom CSS has been changed. Please note that ID’s and classes rarely change though.

    Best regards,
    Rikard

    #1373327

    Hi Rickard, 
    I’m not really making much progress here….. (I’m not clear on why ID’s would be changed in Core Files? doesn’t that make having a child theme pointless?)
    Either way, I’ve followed the steps you suggested and it looks like there are significant differences in the elements (But I cannot find any of the below in the styles.css or footer/header.php files)

    An example of the OLD site element which is working correctly;

    <div class=”flex_column_table av-equal-height-column-flextable -flextable”><div class=”flex_column av_one_third  flex_column_table_cell av-equal-height-column av-align-top av-zero-column-padding avia-link-column av-column-link first  avia-builder-el-8  el_after_av_one_full  el_before_av_one_third  row_courses column-top-margin” style=”border-radius:0px; ” data-link-column-url=”/what-we-do/#training–development”>

    And the UPDATED page element which is broken…… note the jumbled code in bold;

    <div class=”flex_column_table av-kcaecnmk-94c2af9e98a62e33180765e9ae58c909 sc-av_one_third av-equal-height-column-flextable”><div class=”flex_column av-kcaecnmk-94c2af9e98a62e33180765e9ae58c909 av_one_third  avia-builder-el-8  el_after_av_one_full  el_before_av_one_third  row_courses first flex_column_table_cell av-equal-height-column av-align-top av-zero-column-padding avia-link-column av-column-link column-top-margin” data-link-column-url=”/what-we-do/#training–development”>

    What I have found in the element inspector is that the issues with the updated site relate to;

    1. The “.flex_column.av-bg5p2-8b8a6aaa113dfa980309a10de497638b css in each column – This style DOES NOT show at all in the old site? When I remove the PADDING from this element in the Updated site…… the columns look 99% the same as in the old site &

    2. I removed “Position – inherit” from the “Find Out More” links row course css and that fixed that, so those 2 changes made the new site look 100% like the old.

    Can you help with the two points above?

    Your suggestion to test updates on a Staging site doesn’t really get us any closer to fixing the problem? I guess I could always just restore the live site from a backup and go back to the start, which I’m willing to do.

    OR we could use the staging site as the example of what IS working and update the Live site accordingly. Either way we’re still dealing with the same issues, which is what I’m trying to fix.

    Thanks in advance

    #1373415

    Hi,

    Thanks for the update. That code is not jumbled, it’s part of an improvement in the theme which allows to only load page or post specific CSS. It’s not really important in your case though, since you should focus on the styling which is added in your child theme. Are they really targeting the elements you are referring to? What you are referring to as styling in the first question is actually a class, not styling.

    My suggestion to update on a staging site might not be relevant in your current situation, but it could have been avoided on the live site. You could have fixed the problems on a staging site instead of your production site.

    I’m not 100% sure as to why the ID were changed at some point, but I’m sure we have a good reason for doing so, otherwise there would be no point. Having a child theme would not have made any difference in that case, since you have added styling to your child theme, you haven’t overridden any templates in the theme.

    Best regards,
    Rikard

    #1373438

    Hi Rickard,

    You’re right, my terminology about the Div class items was not accurate, but I believe the PADDING and POSITION points I made in my previous email are.

    So lets get back to the problem we’re trying to solve….

    How do we get the 3 column boxes just below the fold on the home page to load as expected on the new site?

    I’ve compared the two Styles CSS files from Old to Updated sites and the ONLY differences are;

    a) I’ve changed “submenu” to “grid_row” per your suggestion

    b) I’ve added the “position: inherit” to the row courses per your suggestion for the Footer problem (However, per my previous email when I REMOVE this in the Styles of the Element Inspector, the “Find Out More” links move to the position they’re supposed to be in.)

    The rest of the Child Styles.css file is exactly the same from Old to Updated site. I’ve tried to offer some suggestions……what do you think is causing the problem?

    As I’ve said, given the size of the issue, I don’t feel like it really matters whether we fix this on the Live or Staging site, only that we fix it. But if you’d prefer I restore the live site and we try to find a solution on the Staging site, I’m happy to do that.

    Can you help me fix this?

    #1373691

    Hi Rickard,

    Here’s what I mean re the Padding….

    This is what the three columns look like after the update. The Style in the “flex-column” with the new Code shows “0” Padding – https://drive.google.com/file/d/1mT4s2P4niiS3iEIfMDOp_BejLE0Pxhe9/view?usp=sharing

    By removing that Padding style the column reverts to very close to what it was before the update – https://drive.google.com/file/d/11O_I1evZC0q9PBkvHJkHuPLKtatoREIN/view?usp=sharing

    The only extra step is to change the “position: inherit” so that the Find Out More links line up……

    Where should I make this change in the site files so that they’re reflected on the live site?

    #1373692

    Hmmm, it seems ALL of OPT In Buttons are all broken as well………

    looks like the update has broken a lot of the custom elements in the child theme…….

    I’ll revert to an old version of the site I suppose.

    #1373717

    Hi,

    Thanks for the update, and sorry for the late reply. It would likely be better if you rolled back to an older version, then update and fix the problems on a staging site instead.

    Best regards,
    Rikard

    #1373823

    Hi Rickard,

    Yes, that is what I’ve done.

    What is your recommended method to update the Staging site?

    Is it via FTP or via the https://envato.com/market-plugin/ you suggested previously?

    Can you list the steps you suggest I follow and I’ll see what happens on the staging site.

    Thanks

    #1373959

    Hi,
    To update your staging site I recommend downloading the latest installable WP version from your Theme Forest account and upload it to your WordPress ▸ Appearance ▸ Themes ▸ Add Themes ▸ Add New
    WordPress_Appearance_Themes_Add-Themes_Add-New.jpg
    after you choose the zip file and click install, you will see a This theme is already installed message because you are updating, you can continue
    Installing_theme_from_uploaded_file_This_theme_is_already_installed.jpg
    then you will see the Theme updated successfully message.
    Theme_updated_successfully.jpg

    Best regards,
    Mike

    #1374393

    Hi Mike,

    Thanks for the clarification.

    I did this (updated from 4.5.7 to 5.2.1) and the same errors occurred as per my previous discussion with Rickard.

    Please see the staging site here – https://gmcomaubrocstg.wpengine.com/

    – The Footer Area has ALL Pages listed (not widgets)….?
    – The home page has lost all styling from the Child Theme…..?

    Can you help with this?

    Thanks in advance

    #1374396

    Hi,
    I tried to review this thread to catch up, and as I understand you have a backup for 4.5.7 where everything works correctly, but when you update to 5.2.1 the demo footer shows and you lose the homepage styling?
    Do you lose any other styling?
    The WP login doesn’t work, but the FTP did work. It looks like you have a custom loop-index.php, related-posts.php, single.php, header.php, footer.php
    I wonder if any of these are conflicting with the latest version, quite a lot has changed since 4.5.7

    Do you know what the customizations in each of these are? If these are minor customizations I would imagine that you could remove these files to see if your footer and homepage styling returns, and then add the files back one at a time to see where the error occurs.

    Best regards,
    Mike

    #1374397

    Hi Mike,

    Thanks. I have updated the WP login details and added them below in case you need them.

    “…as I understand you have a backup for 4.5.7 where everything works correctly, but when you update to 5.2.1 the demo footer shows and you lose the homepage styling?….” YES – this is correct.

    The styling loss is 99% impacting the home page. All other pages seem to be unaffected (other than a minor padding issue on the carousel buttons below our “Just Some of our Reviews” testimonials block that is located towards the bottom of the home page and on various other pages as well, e.g. /academy)

    I don’t know “Exactly” what customisations are in the various .php files and appreciate any assistance you can provide in identifying which ones might be causing the issues.

    Can the removal and re-adding of those files be done via the WordPress Theme editor or should they be done via FTP?

    Thanks in advance for your help

    • This reply was modified 1 year, 4 months ago by CBurgo.
    #1374449

    Hi,
    Thanks for the login to your staging site, I have tried deactivating your plugins,
    When I remove your child theme header.php & footer.php your footer shows correctly, please check.
    I didn’t find what was going on with your styling though.

    Best regards,
    Mike

    #1374539

    Thanks Mike,

    Removing the child theme header.php & footer.php has had other impacts on the styling. You can see the size difference in the above the fold elements between https://www.greatmanagers.com.au/ and https://gmcomaubrocstg.wpengine.com/

    Is there a way to check what other changes will have occurred?

    And what’s the best way to keep the custom elements in the Child as well as whatever made the Footer return to normal by removing those files?

    When following some of the suggestions from Rickard previously, I found the following;

    1. changing after_submenu_[Number] to after_grid_row_[Number] in the Styles.css file brought back the colours on the home page. I have tried this again on the Staging Site but it has NOT brought the colours back to the page – Is it possible the removal of the Child Header.php and Footer.php could have something to do with it?

    2. Removing the Padding from the “.flex_column.av-bg5p2-8b8a6aaa113dfa980309a10de497638b” css as seen in the element inspector in each column (But which does not show on the old version of the site at all) returned the columns to look 99% the same as in the old site. (I have not tried this again on the Staging site given the issue with point 1 above.

    Can you put the Child Header.php and Footer.php back where they were and we can see if it brings some of the styling back to normal?

    Thanks in advance

    #1374542

    Hi,
    I put the Header.php and Footer.php back, please check.

    Best regards,
    Mike

    #1374545

    Thanks Mike,

    Hmmm, nope, nothing’s changed……

    I’m really not sure what’s going on with this update?

    The only thing we haven’t done is add the position_inherit to the Quick CSS as suggested by Rickard…….which i’ve done, but it didn’t seem to make a big difference…..?

    • This reply was modified 1 year, 3 months ago by CBurgo.
    #1374776

    Hi,
    Glad to hear that the css is not caused by the removal of the Header.php and Footer.php, we are not recommending adding these to child themes anymore for this very reason.
    We have updated our documentation to recommend adding scripts to the child theme functions.php.
    So please remove these two files from your staging site and check if removing any of your other customized child theme files will change the css, if not we will continue to investigate.
    I see that you are using ACF to add a custom page class to your pages, but I don’t understand if it has another purpose, is this just for your custom css? Could this have changed and is causing your css to be wrong? Couldn’t you use the page IDs in the same way without ACF?

    Best regards,
    Mike

    #1375059

    Hi Mike,

    I understand you’ve re-added the Header Footer, but it does seem as though there were changes that occurred when you removed them originally…..

    per my previous message, “…Removing the child theme header.php & footer.php has had other impacts on the styling. You can see the size difference in the above the fold elements between https://www.greatmanagers.com.au/ and https://gmcomaubrocstg.wpengine.com/&#8230;.” – the simple difference in the above the fold element is one example……

    Can you clarify what ACF is?

    I probably need to get someone with more coding experience to deal with the problem and update any styling into the methodology you recommend (ie NOT in the Header/Footer files) as it does seem like we’re going around in circles a little bit here.

    Thanks for your help so far.

    kind regards
    Cameron

    #1375062

    Hi,
    ACF is your plugin Advanced Custom Fields
    I don’t see how the Header.php and Footer.php would change the layout it is not expected.
    How about we try again, please restore the staging site back to the old version that is correct, and then I will investigate it first and then try to update again and see what happens.
    Sorry for the back and forth, but I have not seen this kind of error before.

    Best regards,
    Mike

    #1375064

    Gotcha, thanks Mike,

    I appreciate your support and patience. Sorry if my coding skills are not advanced enough to be better at this.

    I also appreciate the chance to try again….. I have re-copied LIVE to STAGING and thanks for taking another look.

    Please feel free to log in and see what you think.

    Thanks again
    Cameron

    #1375066

    Hi,
    Thank you, I tested the FTP and it seems to be the same and working, but I couldn’t login to the staging site with any of the logins posted in the past, I tried each one twice unless I missed one. Please check and post the staging site admin login.
    Thank you for your patience.

    Best regards,
    Mike

    #1375067

    Hi Mike,

    Sorry, the copy from Live to Staging has obviously overwritten the Users….. I’ve updated the staging user password below……

    Please note the updated USER Name as well……

    Thanks and kind regards

    #1375111

    Hi,
    Thanks for the login, so your header.php is adding the Google Tag Manager code and some ontraport scripts, this can be added to the child theme functions.php and is not a big deal. We don’t recommend using a header.php or footer.php in your child theme or you will keep having to update these files in most updates.
    Your footer seems to be adding some call-to-action scripts, so this can also be moved to the functions.php
    Your custom single.php & related-posts.php files have minor edits and I have made updated versions for these for v5.2.1
    But your loop-index.php has major customizations and the v5.2.1 version is quite different so you are going to need to customize a new v5.2.1 loop-index.php for when you update. If you had hired someone to do this before please ask them to help you again because I don’t understand the customization and it is beyond what I can help you with.
    Your custom contentslider.php was only edited to show the arrow and dot navigation at the same time so it should be easy to update.
    If the theme had not changed so much from 4.5.7 to 5.2.1 then you could have just used your custom files and updated with no issues, but back around v5 the theme added more features and changed many core files like the loop-index.php
    I found that your Advanced Custom Fields plugin adds custom classes to your pages and your css is based on this, so this is why when we updated the elements on your homepage was so different because we had disabled all of your plugins so the Advanced Custom Fields plugin was not added the custom classes and your css was not working.
    So at least we figured that out.
    So we could probably update with the new files I made for you and most of your pages would be fine, but not your loop-index.php, so I imagine that you are going to want to wait to update until you get a new custom loop-index.php created.

    Best regards,
    Mike

    #1375167

    Thanks Mike,

    I really appreciate the extensive nature of your support. Excellent service and thank you!

    Two questions;

    1. Is it worth trying the update with the new files you’ve made and see whether we can live with the outcome or not?

    2. Is there a way to avoid future updates having an impact on the loop-index.php? ie – Are we also better off putting those customisations in a different Child Theme folder?

    (I’ll reach out to the contractor who did the customisations on the site in the meantime…..)

    Thanks again & kind regards
    Cameron

    #1375230

    Hi,
    We could try updating and seeing how it goes since it is a staging site and we can easily roll it back.
    As for future updates on the loop-index.php it’s hard to say, I don’t think it changed for a very long time and then the big change for version 5 was because WordPress made a big change and PHP8 was rolling out, so my guess is that it may not change for a long time.
    Do you know what the customization was meant to do? I don’t see anything major on your blog page, if your customization was to just move some of the elements around like the date below the post for example then we could just use some javascript instead and you won’t need to use a custom loop-index.php at all.
    Let me know what the customization was for and perhaps I can try to make the same changes with javascript first before we try updating.

    Best regards,
    Mike

    #1375293

    Thanks Mike,

    Yes, I believe the customisation was just for the page elements and how they’re positioned and how they show on the page.

    I’ll see if I can get a clear answer on this from the developer…..

    Thanks again!

    #1375513

    Hi,
    I took a look at the staging site and it looks like you have made some good progress with it, I see it is updated to v5.2.1 and it looks like it is working well?

    Best regards,
    Mike

    #1375607

    Hi Mike,

    Thanks for checking back in.

    I have a developer looking into it, so I’m glad to hear that. I shared your comments from 5th December with the Dev and they were VERY helpful……(The Dev even commented on the quality of your support, so well done! :)

    I trust the dev will heed your advice about moving customisations out of Header/Footer.php and into Functions.php….and removing the Header/Footer files from the Child…..

    I’m not sure what the outcome with be regarding the loop-index.php

    I’ll keep you posted

    Thanks again!

Viewing 30 posts - 31 through 60 (of 64 total)
  • You must be logged in to reply to this topic.