Update to Enfold 5.2.1 breaks footer and other child elements

Hi Rickard,

I’ve found & changed after_submenu_1 (for the Home Page) in the Styles.css file and the colour does indeed come back, thanks!…however, the alignment of the content boxes is still not correct and the rest of the page customisations are still missing?

Obviously all of the custom styling has all been done in the site files because of the various custom requirements of the content boxes in the first section and other sections below……it’s not just the colour that has been customised……If you look closely at the two versions of the home page you’ll see what I mean.

I’m not clear on why the ID would have changed ONLY on the home page either? Shouldn’t having a child theme prevent that? The other pages havent lost their customisations so I’m not clear on why the difference….

1. Do you know what is causing the other page elements to not work? How should I detect those?

2. Are you suggesting that all “after submenu #” should be changed to after_grid_row_# &

3. What’s the best way to be clear on which ID’s have changed in the NEW update so I can update the Styles.css accordingly?

Thanks in advance

Hi Rickard, 
I’m not really making much progress here….. (I’m not clear on why ID’s would be changed in Core Files? doesn’t that make having a child theme pointless?)
Either way, I’ve followed the steps you suggested and it looks like there are significant differences in the elements (But I cannot find any of the below in the styles.css or footer/header.php files)

An example of the OLD site element which is working correctly;

<div class=”flex_column_table av-equal-height-column-flextable -flextable”><div class=”flex_column av_one_third  flex_column_table_cell av-equal-height-column av-align-top av-zero-column-padding avia-link-column av-column-link first  avia-builder-el-8  el_after_av_one_full  el_before_av_one_third  row_courses column-top-margin” style=”border-radius:0px; ” data-link-column-url=”/what-we-do/#training–development”>

And the UPDATED page element which is broken…… note the jumbled code in bold;

<div class=”flex_column_table av-kcaecnmk-94c2af9e98a62e33180765e9ae58c909 sc-av_one_third av-equal-height-column-flextable”><div class=”flex_column av-kcaecnmk-94c2af9e98a62e33180765e9ae58c909 av_one_third  avia-builder-el-8  el_after_av_one_full  el_before_av_one_third  row_courses first flex_column_table_cell av-equal-height-column av-align-top av-zero-column-padding avia-link-column av-column-link column-top-margin” data-link-column-url=”/what-we-do/#training–development”>

What I have found in the element inspector is that the issues with the updated site relate to;

1. The “.flex_column.av-bg5p2-8b8a6aaa113dfa980309a10de497638b css in each column – This style DOES NOT show at all in the old site? When I remove the PADDING from this element in the Updated site…… the columns look 99% the same as in the old site &

2. I removed “Position – inherit” from the “Find Out More” links row course css and that fixed that, so those 2 changes made the new site look 100% like the old.

Can you help with the two points above?

Your suggestion to test updates on a Staging site doesn’t really get us any closer to fixing the problem? I guess I could always just restore the live site from a backup and go back to the start, which I’m willing to do.

OR we could use the staging site as the example of what IS working and update the Live site accordingly. Either way we’re still dealing with the same issues, which is what I’m trying to fix.

Thanks in advance

Hi Rickard,

You’re right, my terminology about the Div class items was not accurate, but I believe the PADDING and POSITION points I made in my previous email are.

So lets get back to the problem we’re trying to solve….

How do we get the 3 column boxes just below the fold on the home page to load as expected on the new site?

I’ve compared the two Styles CSS files from Old to Updated sites and the ONLY differences are;

a) I’ve changed “submenu” to “grid_row” per your suggestion

b) I’ve added the “position: inherit” to the row courses per your suggestion for the Footer problem (However, per my previous email when I REMOVE this in the Styles of the Element Inspector, the “Find Out More” links move to the position they’re supposed to be in.)

The rest of the Child Styles.css file is exactly the same from Old to Updated site. I’ve tried to offer some suggestions……what do you think is causing the problem?

As I’ve said, given the size of the issue, I don’t feel like it really matters whether we fix this on the Live or Staging site, only that we fix it. But if you’d prefer I restore the live site and we try to find a solution on the Staging site, I’m happy to do that.

Can you help me fix this?

Hmmm, it seems ALL of OPT In Buttons are all broken as well………

looks like the update has broken a lot of the custom elements in the child theme…….

I’ll revert to an old version of the site I suppose.

Hi Rickard,

Yes, that is what I’ve done.

What is your recommended method to update the Staging site?

Is it via FTP or via the https://envato.com/market-plugin/ you suggested previously?

Can you list the steps you suggest I follow and I’ll see what happens on the staging site.

Thanks

Hi Mike,

Thanks for the clarification.

I did this (updated from 4.5.7 to 5.2.1) and the same errors occurred as per my previous discussion with Rickard.

Please see the staging site here – https://gmcomaubrocstg.wpengine.com/

– The Footer Area has ALL Pages listed (not widgets)….?
– The home page has lost all styling from the Child Theme…..?

Can you help with this?

Thanks in advance

Hi Mike,

Thanks. I have updated the WP login details and added them below in case you need them.

“…as I understand you have a backup for 4.5.7 where everything works correctly, but when you update to 5.2.1 the demo footer shows and you lose the homepage styling?….” YES – this is correct.

The styling loss is 99% impacting the home page. All other pages seem to be unaffected (other than a minor padding issue on the carousel buttons below our “Just Some of our Reviews” testimonials block that is located towards the bottom of the home page and on various other pages as well, e.g. /academy)

I don’t know “Exactly” what customisations are in the various .php files and appreciate any assistance you can provide in identifying which ones might be causing the issues.

Can the removal and re-adding of those files be done via the WordPress Theme editor or should they be done via FTP?

Thanks in advance for your help

• This reply was modified 2 years ago by CBurgo.

Thanks Mike,

Removing the child theme header.php & footer.php has had other impacts on the styling. You can see the size difference in the above the fold elements between https://www.greatmanagers.com.au/ and https://gmcomaubrocstg.wpengine.com/

Is there a way to check what other changes will have occurred?

And what’s the best way to keep the custom elements in the Child as well as whatever made the Footer return to normal by removing those files?

When following some of the suggestions from Rickard previously, I found the following;

1. changing after_submenu_[Number] to after_grid_row_[Number] in the Styles.css file brought back the colours on the home page. I have tried this again on the Staging Site but it has NOT brought the colours back to the page – Is it possible the removal of the Child Header.php and Footer.php could have something to do with it?

2. Removing the Padding from the “.flex_column.av-bg5p2-8b8a6aaa113dfa980309a10de497638b” css as seen in the element inspector in each column (But which does not show on the old version of the site at all) returned the columns to look 99% the same as in the old site. (I have not tried this again on the Staging site given the issue with point 1 above.

Can you put the Child Header.php and Footer.php back where they were and we can see if it brings some of the styling back to normal?

Thanks in advance

Thanks Mike,

Hmmm, nope, nothing’s changed……

I’m really not sure what’s going on with this update?

The only thing we haven’t done is add the position_inherit to the Quick CSS as suggested by Rickard…….which i’ve done, but it didn’t seem to make a big difference…..?

• This reply was modified 2 years ago by CBurgo.

Hi Mike,

I understand you’ve re-added the Header Footer, but it does seem as though there were changes that occurred when you removed them originally…..

per my previous message, “…Removing the child theme header.php & footer.php has had other impacts on the styling. You can see the size difference in the above the fold elements between https://www.greatmanagers.com.au/ and https://gmcomaubrocstg.wpengine.com/&#8230;.” – the simple difference in the above the fold element is one example……

Can you clarify what ACF is?

I probably need to get someone with more coding experience to deal with the problem and update any styling into the methodology you recommend (ie NOT in the Header/Footer files) as it does seem like we’re going around in circles a little bit here.

Thanks for your help so far.

kind regards
Cameron

Gotcha, thanks Mike,

I appreciate your support and patience. Sorry if my coding skills are not advanced enough to be better at this.

I also appreciate the chance to try again….. I have re-copied LIVE to STAGING and thanks for taking another look.

Please feel free to log in and see what you think.

Thanks again
Cameron

Hi Mike,

Sorry, the copy from Live to Staging has obviously overwritten the Users….. I’ve updated the staging user password below……

Please note the updated USER Name as well……

Thanks and kind regards

Thanks Mike,

I really appreciate the extensive nature of your support. Excellent service and thank you!

Two questions;

1. Is it worth trying the update with the new files you’ve made and see whether we can live with the outcome or not?

2. Is there a way to avoid future updates having an impact on the loop-index.php? ie – Are we also better off putting those customisations in a different Child Theme folder?

(I’ll reach out to the contractor who did the customisations on the site in the meantime…..)

Thanks again & kind regards
Cameron

Thanks Mike,

Yes, I believe the customisation was just for the page elements and how they’re positioned and how they show on the page.

I’ll see if I can get a clear answer on this from the developer…..

Thanks again!

Hi Mike,

Thanks for checking back in.

I have a developer looking into it, so I’m glad to hear that. I shared your comments from 5th December with the Dev and they were VERY helpful……(The Dev even commented on the quality of your support, so well done! :)

I trust the dev will heed your advice about moving customisations out of Header/Footer.php and into Functions.php….and removing the Header/Footer files from the Child…..

I’m not sure what the outcome with be regarding the loop-index.php

I’ll keep you posted

Thanks again!