Tagged: SSL
-
AuthorPosts
-
August 8, 2016 at 4:08 pm #669882
I just noticed the following in
enfold\framework\php\class-framework-widgets.php:$remote = wp_remote_get( 'https://www.instagram.com/'.trim( $username ), array( 'sslverify' => false, 'timeout' => 60 ) );And these posts must be the reasons for this: https://kriesi.at/support/topic/unable-to-communicate-with-instagram/ , https://kriesi.at/support/topic/mailchimp-api-not-connecting/#post-552751.
Please don’t set
sslverifyto false. It is bad practice. See https://www.skyverge.com/blog/developers-stop-using-sslverify-false/ for more information. Having to disable sslverify indicates a PHP configuration error on the web server that users or administrators need to fix, and see https://www.saotn.org/dont-turn-off-curlopt_ssl_verifypeer-fix-php-configuration/ on how to do that.So please don’t make these kind assumptions for your users, it may break the internet (really). Or if you really have to, make it optional through the Enfold Options Framework.
Other files affected:
./config-templatebuilder/avia-shortcodes/av-helper-mailchimp.php: 'sslverify' => falseand here I have set sslverify to true:
./framework/php/class-framework-widgets.php: $remote = wp_remote_get( ‘https://www.instagram.com/’.trim( $username ), array( ‘sslverify’ => true, ‘timeout’ => 60 ) );`
-
This topic was modified 9 years, 2 months ago by
jan_reilink. Reason: fixed some typos
August 11, 2016 at 4:36 pm #671428Hey Jan,
I think Kriesi implemented a fix in Enfold v3.7.1. for it.
Best regards,
AndyAugust 12, 2016 at 9:37 am #671770Hi Andy,
Thank you for you reply.Unfortunately, Enfold v3.7.1 is what introduced this bad practice code. Just don’t do
'sslverify' => false-
This reply was modified 9 years, 2 months ago by
jan_reilink. Reason: within doesn't work :)
August 15, 2016 at 3:41 pm #672725Hey!
thank you. I will notify Kriesi about it.
Best regards,
Andy -
This topic was modified 9 years, 2 months ago by
-
AuthorPosts
- You must be logged in to reply to this topic.
