Viewing 26 posts - 1 through 26 (of 26 total)
  • Author
    Posts
  • September 10, 2019 at 11:22 am #1136478
    mosesjohnson

    Hi,
    I’ve noticed that we have a heading where share links should be located But there is nothing under it.
    This is heading level five, after reading an article.
    .
    Kindly add them for me as I am visually impaired and I’m very poor in this area.

    Furthermore I would need the 3 different Icons in following order: Facebook, Instagram and Twitter.
    Thanks for the support you have always extended to me.
    Moses

    • This topic was modified 5 years, 2 months ago by mosesjohnson.
    September 10, 2019 at 7:28 pm #1136723
    Victoria

    Hey mosesjohnson,

    https://cl.ly/39516dcf965b Are you referring to this?

    You need to add the social profiles in the theme options in the order that you need them to be shown.

    Best regards,
    Victoria

    September 10, 2019 at 7:53 pm #1136744
    mosesjohnson

    Hi Victoria,
    Thank you for your message,
    Kindly check things further for me.
    I cannot get the share links To appear after the blog post .
    Thank you, kindly help

    September 11, 2019 at 2:27 pm #1137052
    Rikard

    Hi,

    Where are you having this problem? The sharing buttons are showing fine on my end on the post in private.

    Best regards,
    Rikard

    September 11, 2019 at 2:50 pm #1137060
    mosesjohnson

    Hi,
    Thank you for your response,
    Kindly note that I’m visually impaired and I use the screen reader called
    Voiceover on my phone and
    JAWS on my Windows laptop .
    Non is reading those buttons.
    Kindly investigate Further for me .

    I think everything on the theme should be accessible with voiceover
    And jaws screen reader
    .
    Initially , my screen readers were not able to read or recognize the top menu as well as menu elements however,
    A moderator
    Was able to fix it for me .
    I think this is accessibility issues with the theme.
    Any help would be really appreciated .
    Thank you
    Moses

    September 16, 2019 at 7:58 pm #1138903
    Basilis

    Hi,

    Yes you are correct they should. I couldnt login with this password although, how can we check this?

    Best regards,
    Basilis

    September 16, 2019 at 8:06 pm #1138905
    mosesjohnson

    Hi,
    The password is okay.
    The first letter is capitalized.

    September 19, 2019 at 2:11 pm #1139924
    Ismael

    Hi,

    Thank you for the update.

    Do you have JAWS 15? According to the following article, the software will be able to read the text using the aria-label attribute. This attribute is present in the social share icons.

    // https://www.deque.com/blog/text-links-practices-screen-readers/

    We also added the following css code to display the anchor text back.

    #top .avia_hidden_link_text {
    display: inline;
}

    Let us know if it changes anything. Please don’t forget to purge the plugin and browser cache.

    Best regards,
    Ismael

    September 19, 2019 at 2:33 pm #1139929
    mosesjohnson

    Hi Ismael,
    Thank you for your support.
    Actually, my screen readers are not able to read or recognize The share buttons yet.
    I am using voiceOver screen reader on my iPhone and Mac and
    JAWS screen reader
    On my windows PC.
    .
    Kindly check it further for me.

    Thanks always for your support .
    Moses.

    September 19, 2019 at 2:35 pm #1139931
    mosesjohnson

    I’m running the latest version of Jaws,
    JAWS 2019

    September 20, 2019 at 6:40 am #1140120
    Ismael

    Hi,

    We removed the “avia_hidden_link_text” span tag around the anchor text of the social share icons. Maybe that will help. Please don’t forget to purge the cache before testing the page in the screen reader.

    Thank you for the update.

    Best regards,
    Ismael

    September 20, 2019 at 12:09 pm #1140194
    mosesjohnson

    Hello,
    There is no change.
    The screen reader is not identifying the links Yet..
    I don’t know what your colleague
    Mike
    did for the menu items to be identified by the screen reader, Initially my screen reader Couldn’t identify menu items And he was able to fix .
    .
    In the future, maybe you could also escalate things father as it relates to the accessibility of the theme.
    Hopefully you’ll be able to fathom what is happening.
    Best regards.

    September 20, 2019 at 1:52 pm #1140215
    Ismael

    Hi,

    Thank you for the update.

    We will ask the @mike to check this thread for additional help. In the previous thread, @mike adjusted the display property of the menu so that it’s visible for the screen reader. This is also what we are trying to do here, but we’re not sure why it doesn’t work. Have you tried testing it while the cache W3 Total Cache plugin is disabled?

    // https://kriesi.at/support/topic/enfold-theme-by-kriesi-link/#post-1134185

    Best regards,
    Ismael

    September 20, 2019 at 2:14 pm #1140223
    mosesjohnson

    Thanks for your response,
    I have disabled the plug-in,
    Still, it’s not working.
    I don’t know what is the problem,.
    But I am positive things will work..
    Thank you for your continuous help..
    Kind regards.

    Moses.

    September 22, 2019 at 4:46 am #1140527
    Mike

    Hi,
    Sorry for the late reply, I have added this function to your functions.php in an attempt to get your screen readers to read the title attribute of the share buttons:

    function custom_share_titles(){
  ?>
  <script>
(function($){
  $(document).ready(function(){
  $('a[aria-label="Share on Facebook"]').attr('title','Share on Facebook');
  $('a[aria-label="Share on Twitter"]').attr('title','Share on Twitter');
  $('a[aria-label="Share on WhatsApp"]').attr('title','Share on WhatsApp');
  });
})(jQuery);
</script>
<?php
}
add_action('wp_footer', 'custom_share_titles');

    One interesting thing I find, thanks to the article @Ismael linked to, is that the aria-label is ment to have preference over the title and anchor text, but in your case it doesn’t seem to be working that way. Perhaps if this doesn’t work we can try adding the aria-label to the list item (li) that contains the link.

    One question, does your screen readers read the H5 heading for the share link group “Share this entry”? Is there anything else that your screen readers tell you about the elements, even if it makes no sense?

    Best regards,
    Mike

    September 22, 2019 at 8:24 am #1140580
    mosesjohnson

    Hi Mike, It’s always good hearing from you.
    My screen reader is only announcing
    Share this entry Heading level 5

    it doesn’t read the share links themselves.
    Kindly check things further for me.
    Best regards.
    Moses.

    September 22, 2019 at 8:40 am #1140592
    mosesjohnson

    Hi,
    The screen reader is only reading
    Share this entry Heading level 5
    It doesn’t read anything else about the element.
    Best regards,
    Moses.

    September 22, 2019 at 4:06 pm #1140641
    Mike

    Hi,
    Thanks for your feedback, I did some more research and changed the code again, I feel more confident with this one so please clear your browser cache and check. Please note that your iPhone could be trickier to clear so please try a couple of times.

    function custom_share_titles(){
  ?>
  <script>
(function($){
  $(document).ready(function(){
  $('a[aria-label="Share on Facebook"]').attr({title:'Share on Facebook','aria-hidden':'false'});
  $('a[aria-label="Share on Twitter"]').attr({title:'Share on Twitter','aria-hidden':'false'});
  $('a[aria-label="Share on WhatsApp"]').attr({title:'Share on WhatsApp','aria-hidden':'false'});
  });
})(jQuery);
</script>
<?php
}
add_action('wp_footer', 'custom_share_titles');

    Best regards,
    Mike

    September 22, 2019 at 4:29 pm #1140647
    mosesjohnson

    Hi Mike,
    You have done it again :)
    it’s now working like magic.
    I’m very happy.
    If it’s possible to set them to open on a new tab, it will be very cool.
    You are a true nerd.
    Best regards.
    Moses.

    September 22, 2019 at 5:09 pm #1140651
    Mike

    Hi,
    Glad this worked, but the links are set with target=”_blank” and are opening in new tabs for me, which device is the issue in? Does your screen reader open links via voice commands, could it be overriding the action?

    Best regards,
    Mike

    September 22, 2019 at 6:16 pm #1140669
    mosesjohnson

    Thanks Mike,
    Sorry, I didn’t realize. Actually it’s working perfectly.

    September 22, 2019 at 8:56 pm #1140764
    Mike

    Hi,
    Glad to hear, I removed the sub-title, but I’m not sure about the menu H2, the menu is set up differently and I’m not sure how it will affect our modifications.
    By the way, did you know your logo image is not showing now, I believe the image file name has changed, please try re-choosing it in the settings.

    Best regards,
    Mike

    September 22, 2019 at 11:12 pm #1140788
    mosesjohnson

    Hey Mike,
    Thank you for your message.
    We can just leave the menu as it is.

    Actually, it’s cool that way.
    I reuploaded my logo image however, I don’t know if it’s set up correctly. I would appreciate if you could adjust it for me accordingly.
    My thanks always
    Moses.

    September 23, 2019 at 12:46 am #1140791
    Mike

    Hi,
    Glad to hear, your logo is looking good now :) *happy face*
    shall we close this then?

    Best regards,
    Mike

    September 23, 2019 at 12:59 am #1140792
    mosesjohnson

    Glad you could help.
    I really appreciate your support.
    I am also happy that the enfold team is taking accessibility concerns seriously.
    I hope There will be a permanent solution in the future updates..
    We can happily close this thread :)
    . Thank you Again for your help.

    Everything is now accessible with the screen reader.
    Best regards,
    Moses

    September 23, 2019 at 1:41 am #1140796
    Mike

    Hi,
    Thank you for the feedback, I have definitely learned a lot about accessibility while helping you and already see the dev team making changes internally. Thank you for your patience and using Enfold.

    Best regards,
    Mike

  • Author
    Posts
Viewing 26 posts - 1 through 26 (of 26 total)
  • The topic ‘Social share links’ is closed to new replies.