Viewing 11 posts - 1 through 11 (of 11 total)
  • Author
    Posts
  • #1154589

    I created a test page to illustrate the issue. You can find it here.
    1. Looking at the Portfolio Grid with the option “displayed with sort options and currently active categories” versus “displayed with sort options” the only difference I see is that the first is displaying the categories used in the displayed set left justified and the latter is showing them right-justified. I would expect the first option to show all categories that have portfolio entries.
    2. The Portfolio Masonry instead shows the categories in the second option centered. No other difference. The active categories are not shown. Only the subset.
    After translation to German using the recommend WPML plugin, the sort option display is not shown in the Portfolio Grid on the German page. The settings are not transferred to the German page by the Advanced Translation Editor in the WPML package. When I then open the German page in the editor to check it, then I see the Portfolio Grid and the Masonry do not show the selected Portfolio Categories in the backend. WPML says it is a problem with ENFOLD integration. I don’t care whose fault it is, but it should be fixed for all of us in the next update. It’s not so difficult. While the differences in the alignment of the sort option display are not related to WPML and the fact that I see no difference between “displayed with sort options and currently active categories” and “displayed with sort options” might be a misunderstanding. I don’t find it covered in your documentation.

    #1155926

    Hey milano24ore,

    Thank you for the inquiry.

    1-2.) The second option (displayed with sort options and currently active category) will display the active portfolio category name in the other side of the sort buttons, which is why the buttons are aligned to the right. In the case of the masonry element, it will display the active taxonomy term name. It doesn’t display in your installation because of this css code.

    .av-current-sort-title {
    	display: none;
    }
    

    Did you add it? Please remove the code or add the following css to override it.

    .av-current-sort-title {
    	display: inline;
    }
    

    Best regards,
    Ismael

    #1155997

    Thank you Ismael for shedding some light on this. It does not solve all the issues I reported.

    In fact, we had this “.av-current-sort-title {display: none;}” in our customized CSS. I took it out. Now the “…and currently active category” makes sense. No need to customize the CSS. We can just change the settings. We probably just wanted to eliminate the word “ALL”.
    It would be good to show all category names that are selected instead of only showing the ones that are currently displayed. You can see how useful that would be when you look at the test page I created. As you can see, I limited the initial load to 6 items only. However, there are about 25. If the headline would show all used categories then one could quickly select the category of interest. That would be a useful feature to add. Clicking the “All” should display all. That is what you would expect as a user.

    A big issue is that after translation using WPML, the recommended plugin, the translated pages do not look the same. Please kindly compare the EN with DE to see yourself. The Portfolio Grid has lost the category selection in the view and in the editor. The Masonry lost the categories in the editor view only. This is a problem that might need to be solved together with the WPML team.
    Too bad, you do not allow screenshots to be attached.

    Thank you again for your kind support.

    #1156616

    Hi,

    Thank you for the update.

    We probably just wanted to eliminate the word “ALL”.

    The following css code should remove the “All” sort button, but you may still see the “All” category because it is what is initially active on page load.

    .all_sort_button.active_sort, .all_sort_button.active_sort + .text-sep {
    	display: none;
    }
    

    If the headline would show all used categories then one could quickly select the category of interest. That would be a useful feature to add.

    This is one of the limitations of the sort buttons or filters. It can only filter items that are currently present in the page. This is also why the “empty” categories are hidden initially because the items that belongs to these categories are not accessible in the current page.

    The Portfolio Grid has lost the category selection in the view and in the editor.

    Did you translate the categories or taxonomies in your installation? If you haven’t done it yet, please check the documentation for more info. You will be able to select the translated categories in the portfolio grid element after the translation.

    // https://wpml.org/documentation/getting-started-guide/translating-post-categories-and-custom-taxonomies/

    Best regards,
    Ismael

    #1156875

    Hi Ismael,
    1. thank you for helping to remove the word “ALL”. All good.
    2. to show the “empty” categories would be much better. I guess that is a feature request.
    3. of course, the categories are translated as you can see in the test page in the masonry. next to it. same categories. the portfolio grid loses the categories altogether and masonry loses them only in the backend. Something to be fixed by the compatibility group.

    Kind regards
    Wolfgang

    #1157738

    Hi,

    Thank you for the update.

    2.) This is possible, but you have to modify the shortcode files directly. Look for the portfolio.php file inside the config-templatebuilder > aviashortcodes > portfolio folder, edit it, look for this code around line 813:

    if(in_array($category->term_id, $current_page_cats))
    

    .., then replace it with the following code:

    if(true)
    

    This will display the categories or terms even when they are “empty”.

    3.) We may need to access the site in order to check the issue. Please provide the login details in the private field.

    Best regards,
    Ismael

    #1158139

    Hi Ismael,
    2) we tested the suggested modification, but it does not give a useful functionality. Yes, it displays all portfolio categories in the portfolio grid, but selecting then one of them will not deliver the expected result. In our example, we display the travel products for each city. In the initial load of the page, we show the first 4 product thumbnails (portfolio pages). The headline shows now (after the modification) all categories. What I would expect is that clicking on another category (city) I would see the product thumbnails of that category. But that’s not the case. It would only show them if they had been on the page already. So that is is useless. This feature requires more development work. I will put a feature request, Not something to be solved in the support area.
    3) WPML team has delivered a patch that makes the Portfolio Grid and Masonry settings translatable. The patch should be integrated in the next update from you guys. It is 90% perfect.
    The issue is coming from this file \enfold\config-templatebuilder\avia-shortcodes\portfolio\portfolio.php.
    Find this line:
    $display_cats = is_array($params[‘categories’]) ? $params[‘categories’] : array_filter(explode(‘,’,$params[‘categories’]));
    and add this after it:
    if (defined(‘ICL_SITEPRESS_VERSION’)) {
    $display_cats_wpml = array();
    foreach ($display_cats as $display_cat) {
    $display_cat = apply_filters(‘wpml_object_id’, $display_cat, ‘portfolio_entries’, true);
    $display_cats_wpml [] = $display_cat;
    }
    $display_cats = $display_cats_wpml;
    }
    It works, however, the selected categories are not visible in the AVIA editor in the translated page. This is something you should fix. It is a programming error in the ENFOLD template. Easy to test as well in your own system. Use ENFOLD. Create portfolio categories. Translate them using WPML. Create portfolio items and assign them to portfolio categories. Create a page with Masonry and Portfolio grid and select some Portfolio categories to be shown on the page. Translate the page with WPML and see that the category selection is lost in the front end and the back end. After the above patch is applied, the portfolio category is only lost in the back end. Front end works.
    I give you access to our clone with the test page. Please check it out.

    #1158158
    This reply has been marked as private.
    #1158976

    Hi,

    Thank you for the update.

    2.) That is why the the “empty” categories are hidden initially on page load and as mentioned previously, this is one of the limitations of the category filter. It cannot filter posts that are not currently present in the page. One workaround is to display all items in a single page.

    3.) Thank you for the info. We’ll review the changes and include it in the next patch.

    4.) We’ll post this request in our channel for further considerations, but I don’t really think this is going to be implemented, at least not yet.

    Best regards,
    Ismael

    #1160304

    Thank you, Ismael
    3) Patch that makes the Portfolio Grid and Masonry work with WPML
    Compatibility is a big issue for Theme users. We want to be able to concentrate on content, good design and SEO to drive our business. Knowing that the Theme is compatible with WPML is a good thing and will help everyone. We will spread the word. Having said that, we expect that the issues we debugged so nicely together should really be resolved in the next update of the theme.
    See my note above at the end of the patch code section “It works, however, the selected categories are not visible in the AVIA editor in the translated page. This is something you should fix. It is a programming error in the ENFOLD template.” This is an issue we have not been able to fix, but the developer for sure knows the trick.

    #1161160

    Hi,

    Thank you for the update.

    The development team said that this is a known issue and is currently working on a solution. It hasn’t been finalized yet but hopefully, it will be included in the upcoming patch. @guenter is adjusting the link picker so that it returns the actual ID of the post/page in the current or active language.

    Best regards,
    Ismael

Viewing 11 posts - 1 through 11 (of 11 total)

You must be logged in to reply to this topic.