BUG REPORT: HTML-HELPER.class.php -> Image Element with multiple images

Hi,

there is a bug in html-helper.class.php in line 884

Issue:
When using “image”-type multiple times in a shortcode within popup_element().

like

array(
		"name" 	=> __("Custom Background Image",'avia_framework' ),
		"desc" 	=> __("Either upload a new, or choose an existing image from your media library. Leave empty if you want to use the background image of the color scheme defined above",'avia_framework' ),
		"id" 	=> "front_src",
		"type" 	=> "image",
		"title" => __("Insert Image",'avia_framework' ),
		"button" => __("Insert",'avia_framework' ),
		"std" 	=> ""),

array(
		"name" 	=> __("Custom Background Image",'avia_framework' ),
		"desc" 	=> __("Either upload a new, or choose an existing image from your media library. Leave empty if you want to use the background image of the color scheme defined above",'avia_framework' ),
		"id" 	=> "back_src",
		"type" 	=> "image",
		"title" => __("Insert Image",'avia_framework' ),
		"button" => __("Insert",'avia_framework' ),
		"std" 	=> ""),

attachment_size should always be attachment_size='full,full' but after a couple of post saves, it changes to attachment_size='full,full,full,full,full,full'

Solution:

please replace

$attachmentsize = !empty($element['shortcode_data']['attachment_size']) ? $element['shortcode_data']['attachment_size'] : "";

with:

$attachmentsizes= !empty($element['shortcode_data']['attachment_size']) ? explode(',', $element['shortcode_data']['attachment_size']) : array();
$attachmentsize = !empty($attachmentsizes[self::$imageCount]) ? $attachmentsizes[self::$imageCount] : "";

• This topic was modified 6 years, 2 months ago by Innovie.