AviaPointer breaks media uploading and Media Library

Hi!

I don’t know why this started but AviaPointer class is giving notices on ajax calls and media functionality breaks on wp-admin/upload.php. Ajax loader icon just keeps rolling and media thumbnails won’t appear.

PHP Notice: Trying to get property of non-object in …/wordpress/wp-content/themes/enfold/config-templatebuilder/avia-template-builder/php/pointer.class.php on line 52, referer: …/wp-admin/post.php/wp-admin/upload.php

This notice is also firing on other pages but doesn’t seem to cause any problems.

The problem is that AviaPointer calls get_current_screen() function which returns null.

$screen = get_current_screen();
$this->screen_id = $screen->id;

The second line gives the error because $screen is null on ajax calls.

It seems that this code is executed on every ajax call. Is this really necessary? Pointers should be a one time thing, right?

A relevant stack trace:
pointer.class.php:51, AviaPointer->__construct()
template-builder.class.php:296, AviaBuilder->call_classes()
template-builder.class.php:97, AviaBuilder->admin_init()
template-builder.class.php:84, AviaBuilder->Init()

I could fix the issue by adding the following check:

$screen = get_current_screen();
if(isset($screen)) {
    $this->screen_id = $screen->id;
}

I’m not sure if this is the best way to do it. I don’t see the point in running the pointer code on ajax calls.

Could you fix this?

• This topic was modified 9 years, 2 months ago by jiv_e. Reason: Fix code formatting