-
AuthorPosts
-
September 4, 2019 at 10:49 am #1133756
Hi,
I added a backwards comp. fix for those who have been using theme support avia_template_builder_custom_css and avia_template_builder_custom_tab_toogle_id.
Please replace enfold\config-templatebuilder\avia-template-builder\php\template-builder.class.php
with
The fix overrides the theme option settings “Custom CSS classes input field” and “ID attribute input field” to “Show and allow to edit ..”.
This fix will be added to core in the next update – but might be removed in a future release.
Do not forget to make a backup of the original file for a fallback, clear server and browser cache.
If you need assistance with the update let us know.
Best regards,
GünterSeptember 4, 2019 at 7:56 pm #1134050I have this same problem and have tried every fix suggested on each thread discussion. My problem still exists. I have custom css to pass SAML credentials to a 3rd party site. Version 4.6 is still not recognizing the css to pass the credentials. The SAML link that is in my ubermenu still works, it’s only the link that are inside a Page that still won’t work. Do you have any other suggestions? Thanks.
September 5, 2019 at 9:01 pm #1134611Hello,
We have this issue as well.
On Enfold 4.5.7 custom css classes assigned to code blocks under ‘Developer’ tab work fine.
On Enfold 4.6.1 custom css classes assigned to code blocks under ‘Developer’ tab regardless of if seem to get doubled for some reason.Example 4.5.7
https://staging-www.mbari.org/dist/working-457.pngExample 4.6.1
https://staging-www.mbari.org/dist/notworking-461.pngWe are using a child theme.
This occurs regardless of the settings under child theme > layout builder for Custom CSS classes input field, ID attribute input field, Customize heading style.If I remove the custom CSS, no background appears:
Example, custom-css class removed from code block:
https://staging-www.mbari.org/dist/nocustomcss.pngAny help is appreciated.
September 5, 2019 at 10:27 pm #1134623This appears to be the offending code to my above issue, notice the difference between Enfold versions:
./enfold/config-templatebuilder/avia-shortcodes/codeblock.php: $output .= '<section class="avia_codeblock_section '.$av_display_classes.' avia_code_block_' . avia_sc_codeblock::$codeblock_id . ' ' . $meta['custom_class'] . '" ' . $markup . $meta['custom_el_id'] . '>'; ./enfold-4.5.7/config-templatebuilder/avia-shortcodes/codeblock.php: $output .= '<section class="avia_codeblock_section '.$av_display_classes.' avia_code_block_' . avia_sc_codeblock::$codeblock_id . '" ' . $markup . '>'; ./enfold-4.5.6/config-templatebuilder/avia-shortcodes/codeblock.php: $output .= '<section class="avia_codeblock_section '.$av_display_classes.' avia_code_block_' . avia_sc_codeblock::$codeblock_id . '" ' . $markup . '>';
The addition of $meta[‘custom_class’] to line 219 causes the doubling.
This is only an FYI — please assist. I don’t want to edit this code since I don’t know the other implications.
- This reply was modified 5 years ago by MBARI-WP.
September 6, 2019 at 2:39 pm #1134939I tried the version 4.6.1 update just hoping. My custom CSS is still not working. So, I rolled back to 4.5.7 so my site would keep working. Any ideas on what I might try next? Thanks.
September 7, 2019 at 6:25 pm #1135453same issue. Custom CSS isn’t working
September 8, 2019 at 7:16 am #1135566I have a big site with full customization with css and js. and have a lot of classes and ids. When i see this change log:
removed: theme support avia_template_builder_custom_css use theme option or filter avf_alb_get_extended_settings instead
removed: theme support avia_template_builder_custom_tab_toogle_id (theme option “ID attribute input field” used instead)I create a topic for it to ask about this changes. Because if i update theme and according to other user say’s custom style and classes not work correctly my site is broken. I appreciate if solved this issue that i can update my theme to new version. if any one have issues with custom js please share in this topic.
Thank you.
September 9, 2019 at 6:25 pm #1136161Just a bump.
In addition to our doubling issue referenced in https://kriesi.at/support/topic/4-6-update-doesnt-recognize-old-custom-css-class/page/2/#post-1134611 and https://kriesi.at/support/topic/4-6-update-doesnt-recognize-old-custom-css-class/page/2/#post-1134623, custom css classes are not being shown when applied to post sliders (and possibly other items).
I have attempted:
1. Modifying Line 219 of enfold/config-templatebuilder/avia-shortcodes/codeblock.php and removing “$meta[‘custom_class’]” to be as previous versions of Enfold were. This fixed the doubling of things reflected in the above post.2. Changed Child Theme Options in /wp-admin/ to show custom classes as mentioned in this thread.
3. Added custom enfold\config-templatebuilder\avia-template-builder\php\template-builder.class.php from https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_4_6/developer-fix/template-builder.class.php
Custom CSS classes are still not applying. For instance, our post slider will have a custom css class called “home-hero-block”, which lives in our child css, but it does not get applied whereas on previous versions of Enfold it does.
September 10, 2019 at 6:43 am #1136377Hi,
Sorry for the delay.
You can fix the issue by moving your custom css class attributes to the same field inside the “Developers” tab. You can then remove the “avia_template_builder_custom_css” filter in the functions.php file if you add it manually. Temporarily, you can ignore the class attribute duplication because it will not affect the styles or scripts using that selector. It will probably be removed in the next patch.
Best regards,
IsmaelSeptember 10, 2019 at 8:09 pm #1136747Good evening,
I just tried as well the update from 4.5.6 to 4.6. via ftp and other try in wordpress.
The result was horrible – The Headlines changed in fater an bigger and all google-maps gone with the text “Maps were disabled by the visitors on this site. Click to open the map in a new window”. This were the bigger errors I saw only in a quick overview. In panic, because the page is brandnew, I installed again 4.5.6.
Any idea make an update without all these fatal changes?Greets Gabi
September 11, 2019 at 1:22 pm #1137024Hi,
4.6.2 has been released – please try to update to this version.
Check your DSGVO/GDPR settings – they have been adopted to support “must opt in” and that user have to accept cookies (see theme option Default Cookie and Services Option Settings). Check our documentation.
When user has to accept cookies and services no cookies or services are allowed until he accepts cookies and services.
There are also new theme options for custom CSS, ID and heading styling: Theme Options -> Layout Builder -> Builder Options For Developers
There are 2 fixes for 4.6.2 that are not included in that version:
If you have problems with codeblock:
Replace enfold\config-templatebuilder\avia-shortcodes\codeblock.php with
If with BlogPosts:
Reeplace enfold\config-templatebuilder\avia-shortcodes\blog\blog.php with
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_4_6_2/dev_fixes/blog.php
Do not forget to keep a backup of the original file for a fallback – clear server and browser cache.
If you need assistance in updateing we need WP admin access and ftp access. Open a new thread and put it in private content.Best regards,
GünterSeptember 12, 2019 at 9:18 pm #1137660Awaiting responses from Developers. Did the above recommendation from Gunter work for you guys? Thanks!
September 12, 2019 at 9:53 pm #11376854.6.2 update didn’t fix my issues. I am going to try to find time again tomorrow to replace codeblock.php. I am not confident about it though. My custom CSS is not in the Code Block element. Here is the code inside of a Text Block…
[av_button label='Launch WinFlex Web' link='manually,https://samplehub.sample.com/SSO/PTA/PTAService.aspx' link_target='_blank' color='theme-color' custom_bg='#444444' custom_font='#ffffff' size='small' position='left' icon_select='no' icon='ue800' font='entypo-fontello' custom_class='ebixlink WF' av_uid='av-117qth']
Again, the CSS still works from the ubermenu menu system after the theme update.
Thanks,
September 12, 2019 at 10:05 pm #1137696Hey Justin,
I will try at a time, when no traffic on the website (weekend). The part with cookies, DSGVO now ist so huge and difficult, because written in english.
Greets GabiSeptember 14, 2019 at 1:21 pm #1138297Hey. It’s seems, the custom CSS is case-sensitive. A Dev at clients page has used three rules with one uppercase. In 4.6.X, this has not accepted this. After search and replace all CSS rules to lowercase, all was fine. Hope, this is helpful for somone.
September 14, 2019 at 4:43 pm #1138343Thanks Hokuspokus,
Just to confirm, you’re saying the fields WON’T accept classes with uppercase lettering?
That would explain my class “textCtr’ didn’t work.September 14, 2019 at 4:54 pm #1138348That’s what happened to me.
3 Rules like upperclassBottom.In 4.5.7: Everything was fine.
Since 4.6.X: I have to rewrite it.I entered all Uppercase rules with “Search and Replace” Plugin and replaced all rules with lowercase with one step. After that and with modified Custom CSS: Everything is fine.Hope, this will help
September 14, 2019 at 5:52 pm #1138367It does. Thank you. I think it provides some good direction for Kriesi.
I’m sure they’ll take care of it.September 16, 2019 at 2:42 pm #1138829Worked for me too. When I changed my code to all lower case my custom css worked. Thank you all for your help!
September 16, 2019 at 4:40 pm #1138867Hi,
Thanks for your feedback and investigateing this “bug”.
With 4.6 custom id and custom classes were refactored and some options were added to Layout Builder -> Builder Options For Developers.
To make sure syntax is valid for id’s and custom classes in frontend (and to help not so experienced users) the values are sanitized before output. But the filter was to strict – only allowing lowercase and also some other replacements that are not absolutly necessary for classes and id’s.
This will be fixed in the next update to be closer to the w3.org specification:
- “a-zA-Z0-9_-“
- Not starting with -,–
- Not starting with a number
If you want to check it before (4.6.2):
Please replace
enfold\config-templatebuilder\avia-template-builder\php\shortcode-template.class.php
enfold\config-templatebuilder\avia-template-builder\php\generic-helper.class.phpwith
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_4_6_2/custom_css/shortcode-template.class.php
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_4_6_2/custom_css/generic-helper.class.phpDo not forget to make backups of the original files for fallback – clear server and browser cache.
Also added is filter avf_save_string_translated where you can manipulate strings for your own – Here is an example how to use it
Best regards,
GünterSeptember 17, 2019 at 4:18 pm #1139151I changed my classes to all lowercase and this still didn’t resolve the issue.
September 17, 2019 at 4:23 pm #1139152Hi,
@smulligan
Did you disable enfold file merging, save theme options, clear all server and browser cache several times ?
Please open a new thread and give us WP admin access so we can check your backend.
And specify where we can see the problem.Best regards,
GünterSeptember 17, 2019 at 4:31 pm #1139156Yes, but as soon as I enable afterward, the classes disappear. I’ll open a ticket.
October 1, 2019 at 4:46 pm #1143830Has this been resolved? I know the classes became case-sensitive with the last major theme update.
But can you confirm this is now resolved? I just really don’t want to go back into several websites and change all the class names because the theme no longer honors case-sensitivity. Seems like a waste of time to me.Just looking for an update. Thanks
October 2, 2019 at 9:28 am #1144104Hi,
In 4.6.3 the classes are no longer sanitized to lower case. It should work now.
Best regards,
GünterOctober 2, 2019 at 3:26 pm #1144177Thanks Gunter. Will upgrade via FTP and see how it goes.
JustinOctober 2, 2019 at 3:30 pm #1144178I upgraded this morning and it fixed my issues. Thanks!
October 2, 2019 at 5:26 pm #1144210I updated the theme via FTP.
I no longer have the ability to edit the child theme CSS from the WordPress Dashboard.
Both menu items:CUSTOMIZE
EDIT CSSTakes me to the WordPress Dashboard Edit CSS sesction,
Anyone else dealing with this?In other words…both of these options:
https://drive.google.com/file/d/1eNL2oOwRovXhkcPbe1GcCxm5qgP6zt7h/view?usp=sharingtake me here:
https://drive.google.com/file/d/1UUy3_-Gx71ylvcaZZzF8DGrFgeRfb6Wd/view?usp=sharingOctober 3, 2019 at 6:33 am #1144359Hi Justin,
The theme doesn’t add the Edit CSS menu item in your screenshot, maybe it’s a plugin adding that?
Best regards,
RikardOctober 3, 2019 at 2:45 pm #1144477Update: Version (4.6.3.1) fixed my custom CSS to the SAML connection issues I had been reporting. However, it broke a different custom CSS SAML connection so I had to roll back to Version (4.5.7) again. The error I get now is…
A PHP Error was encountered
Severity: Warning
Message: First parameter must either be an object or the name of an existing class
Filename: controllers/api.php
Line Number: 106
Error: Agency not found!So, the newest version is still doing something with the CSS. I am currently working on trying to figure out what is happening.
-
AuthorPosts
- You must be logged in to reply to this topic.