Forum Replies Created
-
AuthorPosts
-
Hey Gunter,
I have just started playing the the new responsive typography feature, and I wanted to say a big thank you for implementing this suggestion.
I’ve only just started with it, so sorry if I’m missing something or don’t understand something fully, but I had a few questions/suggestions on it’s implementation.
1. In the articles I linked to when I started this thread, and in the ones you link to from the Enfold theme settings, to achieve the best responsive results they usually use em or rem units for font sizes. However, I can only select pixel sizes in the Enfold settings. Is there a reason for this? As a suggestion, could we do away with the drop down list of pixel sizes, and instead use a text entry box where we can enter a value that we want, such as 1em, 2vw, 1.5rem, 10px etc? This would provide a lot more flexibility, plus also I think would be quicker than using a drop down list for all of these sections. Then it would be easy to implement the typographic scales you link to in the articles for instance by simply copying/pasting the em values if we wanted to.
2. Would it be possible to add an option in for each h1-h6 section along the lines of “override individual page settings”? For instance, on some sites before this feature was added, I’ve customised the Special Headings using the responsive settings in the ALB element. But now with these global features, I have to find each one I customised and revert it to default for this new feature to take affect on it. Another possibility to help with this could be a global option “set all heading elements responsive styles to default” which as a one-time thing when starting to work with the new responsive typography element you can select it and know that any custom headings/special headings that you’ve ever customised over time are now back to defaults, so you can start using the new responsive typography without any surprises. (I think I prefer this second option)
3. How does this feature interact with the Advanced Styling tab? For instance, if values are set in responsive typography, and values for a H1 exist in the Advanced Styling tab, does the AS tab take priority? (It seems that way, but just want to be sure).
Thanks again Gunter for your brilliant work implementing these and other features.
Regards,
Tim
-
This reply was modified 3 years, 3 months ago by
THP Studio.
Thanks a lot Yigit, have a great weekend.
Hi Gunter,
Thanks again
Tim
Oh I’m sorry, I misunderstood what the filters where there for, thanks for clarifying and for putting in place the fix, I really do appreciate it.
Tim.
Hi Gunter, that’s really great thank you for that.
Just out of curiosity, what was the reason to keep the current functionality and use filters for this fix? (rather than maybe the other way around)
Thanks so much for improving this for us.
Tim.
-
This reply was modified 3 years, 4 months ago by
THP Studio.
Thanks Gunter, you too.
Tim
Hey Gunter,
Brilliant, that seems to have fixed it, thanks for such a speedy fix.
Have a great weekend,
Tim
Great, thanks Yigit, I appreciate it.
Tim
HI Yigit,
Regards
Tim
Hey Gunter,
Thanks for the positive feedback as always.
Glad to hear there’s a lot on the roadmap at the moment, can’t wait to see it.
Tim.
This can be closed, thanks.
This can be closed, thank you.
Hey Gunter,
Ah ok sorry I didn’t see that other thread.
That is a strange one. Maybe someone with some ARIA experience (not me!) can shed some light on it for the forum.
Thanks for getting back to me so quickly.
Tim
Brilliant, thanks Gunter. Enjoy your weekend too.
Tim
Hey Yigit & Gunter,
Been using this more and more and loving it, thanks again.
One small additional request:
Currently if you have a field, say a Text Area field, and you don’t want anything in the “Form Element Label” section, it still outputs a:
“: ”
in the email, as it’s expecting a field name like “Test: “.
So the resulting email can look like:
Test: 12345 (this field has a Form Element label of ‘Test’)
: 12345 (this field has a blank Form Element label)But especially now that we can do headings using the new heading elements, can we change the logic to say that if we leave a fields Element Label section blank, that it doesn’t output a “: ” in the email?
I hope that makes sense.
Regards
Tim
Hey Gunter,
Just tried this out on one of my client sites who will benefit from this, and I have to say a huge thank you, this has been implemented so well. It makes the forms not only look better on the front end, but way more readable on the emails as well. Great job!
Regards
Tim
Thanks Yigit!
Thanks a lot Gunter!
Cache perhaps? I had to navigate to another front end page to see the logo show up, as my browser was caching the page I was on.
Brilliant, thanks Gunter, the following release sounds great!
Perfect, thanks!
Off topic – will the final post-css elements be included in the next release too?
Hi @ismael and @Gunter,
Thank you for the update, I tested it and can confirm it’s fixed.
Really appreciate you jumping on this one quickly, this will have thrown off client reporting quite a bit, but appreciate getting it fixed up.
Tim
Hey Gunter, great thanks for considering this. I think it would be a really helpful feature.
And thanks Guenni007 for the suggestions!
Hey Gunter,
I tried this on a dev site and unfortunately it doesn’t seem to be working, it throws some errors, please see below.
Thanks
Tim
examples below
Hi Yigit,
Thanks for forwarding it to the devs.
Yeah I appreciate that for more complex stuff a plugin might be better. I was just hoping that these two requests (line breaks and headings) wouldn’t be too much hard work, and would make the current form even more useful.
Thanks for considering it.
Tim
September 26, 2021 at 7:31 pm in reply to: Small Styling Issue on Portfolio Masonry Element ALB #1322369Hi Mike,
Lol, no worries at all, you got is sorted for me anyway, thanks for taking the time to look into it.
If I notice on another one of my installs I’ll let you know, otherwise I think we’re good.
Tim.
September 25, 2021 at 10:07 pm in reply to: Small Styling Issue on Portfolio Masonry Element ALB #1322304Yeah that’s really odd. I couldn’t find it in there either.
Only functions that should be affecting that page specifically I think would be the ones below
Thanks
September 25, 2021 at 7:42 pm in reply to: Small Styling Issue on Portfolio Masonry Element ALB #1322300Hey Mike,
Thanks for pointing that out.
That has fixed the problem (on the live site). Strange thing is, I can’t see anywhere in our custom css that would be overriding that.
Please see below for the staging site which is uncached, to see if you can spot the root cause.
Thanks again.
Tim
September 23, 2021 at 8:22 pm in reply to: Small Styling Issue on Portfolio Masonry Element ALB #1322073Hey Mike,
Thanks for the reply, and sorry for the delay in getting back to you.
Please see the link below.
If you can spot the issue that would be great. Might be some custom code we added at some point.
Thanks a lot
Tim
-
This reply was modified 3 years, 3 months ago by
-
AuthorPosts