Forum Replies Created
-
AuthorPosts
-
March 18, 2022 at 1:41 pm in reply to: Icon Grid (Image Flip Box) broken after Enfold upgrade from ver. 4.8.7.1 to 4.9 #1345070
Hi,
please save theme options to force a recreation of the post css files to reflect the changes
No, you only need to update the php file.
Then go to theme options page, make a change and revert again so the “Save Theme Options” button is active and save theme options.
This deletes all the post css files and forces a recreation on page load. This is necessary because the wrong padding setting is in the post css file for the page.Hope I could clearify what I meant.
BTW: Next release 4.9.1 is planned in the next days.
Best regards,
GünterMarch 18, 2022 at 9:54 am in reply to: Icon Grid (Image Flip Box) broken after Enfold upgrade from ver. 4.8.7.1 to 4.9 #1345021Hi,
Sorry for the problems.
I could locate it in a “bug” with the option “Items Padding” set to 0.
4.9 interpretes it correctly as padding: 0 whereas version prior ignore it and use theme default padding.
I added a backwards fix to your staging site:
file config-templatebuilder\avia-shortcodes\icongrid\icongrid.php line 1546 I replaced:
if( trim( $atts['icongrid_padding'] ) != '' )
// this is a bug from older versions < 4.8.8 where 0 was interpreted as not set if( ! empty( $atts['icongrid_padding'] ) )
The fix will be in next release.
In case you update your life site before please save theme options to force a recreation of the post css files to reflect the changes.right menu (widget area) is well defined in backend:
The widget area is empty on the staging site.
Best regards,
GünterHey!
Please check enfold\config-templatebuilder\avia-template-builder\php\class-template-builder.php
around line 686 you have the function autoloadLibraries()
and inside filter avf_load_single_shortcode_file.
There you can hook to load your customized file instead the original one.
A few lines above you have filter avf_load_single_builder_core_file where you can load modified customized core files.
Regards,
GünterHi @comkapi,
Thanks a lot for sharing. Will be added for next release.
Have a great day.Best regards,
GünterHi,
Syntax error:
if($context = "avia_slideshow") {
should be
if($context == "avia_slideshow") {
That is why it is recommended to write:
if( 'avia_slideshow' == $context ) {
which would throw a syntax error if you use ‘=’ by mistake.
Best regards,
GünterHey Patrick,
Thank you for using Enfold.
Using multiple tinyMCE in one popup is not supported by Enfold (out of the box). Enfold always binds the logic to ‘content’ of shortcode.
It is rather tricky to implement multiple tinyMCE- and I’m not even sure that it is possible without heavy changes to Enfold core.
I implemented a solution in another project – but this is not based on ALB elements.Best regards,
GünterHi Luigi,
Thank you very much for sharing your work.
We do not remove any metadata – the only thing I can think of is that when I sync the language files with LOCO translate this plugin alters the metadata.
To be honest I did not dig into the plugin how to avoid this – or how to change any of these data. I only click sync button and save the updated files.Best regards,
GünterFebruary 15, 2022 at 1:20 pm in reply to: What about the filter: avf_load_single_shortcode_file #1340689Hey Guenter,
The main idea of this filter is
- to supress loading of shortcode files that are not needed on your site
- or load a modified file instead (- unnecessary loading of the original file can be skipped)
- Very advanced users might create base classes for group of elements and load these before the shortcode class
what do I have to change in the modified ALB element so that it does not interfere with the original element
Minimum to change is:
$this->config['shortcode'] = '......';
maybe also
$this->config['shortcode_nested'] = array( '......' );
Other changes depend on what you want to modify in your customized element.
Best regards,
GünterHi Tim,
I had a look into it – but it turns out to be more complicate as there are many elements involved and core backend functions.
I add it to our dev repo – but no ETA I can promise at the moment (we are starting to work on 5.0 with some nice new frontend features and Kriesi wants to set priority on this).Best regards,
GünterHey Tim,
Thanks again. You are right.
I think it is better to use settings of “Custom Font Display Behaviour” and add it to the link for google fonts
(https://peterdaugaardrasmussen.com/2021/04/02/how-to-add-font-display-swap-to-font-from-google/):<link type="text/css" rel="stylesheet" href="//fonts.googleapis.com/css?family=Barlow:400,500,600,700%7CAlice&display=swap" id="avia-google-webfont">
Filters will allow to change it.
I uploaded a modified file that implements this solution (replace file enfold\framework\php\class-style-generator.php):
As this file is already based on 4.9 release please keep a copy of the original file for fallback (in case you see problems).
If you want to have a copy of the latest dev release let us know.Best regards,
GünterHey Tim,
WordPress’ default lazy loading
Thanks for pointing at this. For most ALB elements you can disable/enable lazy loading – this should allow more control than the WP implementation taking the first (or with filter a custom number) image only.
Standard templates have not been updated.
Taking a quick look – we did not implement any lazy loading logic in config-woocommerce\config.php yet. And the ALB elements use standard WC templates.
I’m afraid there is no quick solution at the moment.I will add this to our dev repo to take a closer look – but I cannot provide an ETA at the moment.
Best regards,
GünterHi,
Sorry for the problem.
With oncoming version 4.9 the problem with the dashes is fixed again – so it is safe to use fonts with dashes.
Problem was caused by a fix in 4.8.9.1 that removed the dashes for websafe fonts (which contained the dashes in theme options) – missing that custom fonts still need them.
Best regards,
GünterHi,
I do not see the problem, but I have a server error 500 – see private content:
Checking the web: https://developers.google.com/tag-platform/tag-manager/web
Looks different now. Maybe you are using an old implementation ?
Best regards,
GünterHi,
Sorry for the late reply.
A theme can only offer a basic implementation. To be on the safe side plugins specialised for GDPR certainly can offer more options and can stay up to date with laws.
Depending on your needs a plugin might be the better solution.
Best regards,
GünterHi Roger,
Thanks a lot. Merged into core for next release.
Have a great day.Best regards,
GünterHi,
It is not possible to put h2 or h3 tags inside a “p” tag which is the container for the title:
https://stackoverflow.com/questions/42890736/slim-h3-inside-p
I’ve added this problem to our dev repo and planned to address it for 4.9 – check the changelog or https://kriesi.at/support/topic/enfold-upcoming-fixes/
But for the moment there is no easy solution.
Currently the only way is to modify enfold\config-templatebuilder\avia-shortcodes\toggles\toggles.php around lines 1118 – 1124 and replace the p tag.
And add additional logic to identify the element to know how to update the p tag.Best regards,
GünterHi,
Thanks for the feedback – and glad it solves the problem.
I will keep an eye on this.Best regards,
GünterHi,
I will update the Image Element and Team Member and send you the latest dev version to check when ready.
Best regards,
GünterHey Tim,
Thanks for reporting this.
There is really a bug with the lightbox and image element.
If I add the height and width attribute to the img element is that enough or do you still need a filter to manipulate the img html ?
Team Member takes the image size from the media library “Attachment Display Settings” selectbox for sizes.
But you are right, it is more user friendly similar to image element to change the size with a selectbox in the modal popup.
Will add this.And same to img element – is it enough to add height and width attribute to img html ?
Best regards,
GünterHey Thomas,
Strange.
Do you see anything in the php error log (can you reproduce it on a stageing site where you can turn on WP_DEBUG and the WordPress Error Log) ?
Seems that WPML query gets stuck. Maybe something went wrong in saveing the translations. Are you using translation management?
If you can reproduce it on a stageing site try to translate the posts on this page 3 again – or delete one post after the other and check ?Best regards,
GünterHi,
Great it solved the problem.
Sorry for the wrong code. In the next version av-helper-masonry.php is deprecated and a modified code is moved to config-templatebuilder\avia-shortcode-helpers\class-avia-masonry.php and there $this->config exists – and I tested it in this version.
Best regards,
GünterJanuary 4, 2022 at 6:03 pm in reply to: Moving JS inline for ALB color section and Full width Easy Slider #1334262Hi Thomas,
Happy new year to you also.
Most of the jQuery js code is packed in
(function($) { ...... })( jQuery );
or
$(function() { // Handler for .ready() called. });
see https://api.jquery.com/ready/
It is certainly possible to execute code before the dom is ready – but this will be special use cases only and cannot be done in general in the framework.
We have to rely that the dom is complete.Best regards,
GünterHi Tim,
Thanks for digging into this.
I think the best way is to use a filter and limit the changes right in av-helper-masonry.php.
For the next release I added the following filter:
/** * Allows to add width and height attribute to supress WP filters for responsive images * (can be used to server optimized images from an image proxy service like Imgix * * @since 4.8.9 * @param string $img_html * @param array $attachment * @param array $entry * @param array $this->config * @return string */ $img_html = apply_filters( 'avf_masonry_flex_image_html', $img_html, $attachment, $entry, $this->config );
right before (around line 481)
$img_html = Av_Responsive_Images()->make_image_responsive( $img_html, $thumb_ID, $this->config['lazy_loading'] );
and this is an example how to use it:
Best regards,
GünterDecember 28, 2021 at 1:54 pm in reply to: Moving JS inline for ALB color section and Full width Easy Slider #1334005Hey Thomas,
Sorry for the late reply. Hope you had a peacefull christmas time with your family.
This cannot be solved easily. It would need to hack core js files (and that after each update). And there are also dependencies to be considered (like jQuery) – and logic for file merging also.
Best regards,
GünterHi,
Please replace the content of /enfold/config-woocommerce/config.php with the contents of
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_4_8_8_1/WooCommerce/config.php
If you need help with it, let us know.
Do not forget to make a backup of the original file for a fallback and clear server and browser cache.
Best regards,
GünterDecember 18, 2021 at 5:01 pm in reply to: Bug: Wrong href=manually link if content-slider slide… #1333376Hey Mischa,
Thanks for reporting this.
Is a bug in a helper function analysing this input field. So all ALB elements will show the same behaviour.
I added a fix for the next update.Meanwhile you can replace enfold\config-templatebuilder\avia-template-builder\php\class-generic-helper.php
with the content of
Do not forget to make a backup of the original file for a fallback and clear server and browser cache.
If you need help let us know.Thank you for using Enfold and have a great day.
Best regards,
GünterHi,
I hope you’ve seen that with 4.8.4 the following files have changed due to post css file support (in case you modified them in child theme):
enfold\config-templatebuilder\avia-shortcodes\masonry_gallery\masonry_gallery.php
enfold\config-templatebuilder\avia-shortcodes\masonry_entries\masonry_entries.php
enfold\config-templatebuilder\avia-shortcodes\av-helper-masonry.phpThe attachment url for the image is set by following code in av-helper-masonry.php line 1330:
$this->loop[ $key ]['attachment'] = ! empty( $this->loop[ $key ]['thumb_ID'] ) ? wp_get_attachment_image_src( $this->loop[ $key ]['thumb_ID'], $img_size ) : '';
This is a default WP function.
I hope this helps you to locate the problem.
In case you need a filter that would help let us know.
Best regards,
Günter -
AuthorPosts