Hey Guenter,

The main idea of this filter is

• to supress loading of shortcode files that are not needed on your site
• or load a modified file instead (- unnecessary loading of the original file can be skipped)
• Very advanced users might create base classes for group of elements and load these before the shortcode class

what do I have to change in the modified ALB element so that it does not interfere with the original element

Minimum to change is:

			$this->config['shortcode']		= '......';

maybe also

			$this->config['shortcode_nested'] = array( '......' );

Other changes depend on what you want to modify in your customized element.

Best regards,
Günter

Hey Tim,

Thanks again. You are right.

I think it is better to use settings of “Custom Font Display Behaviour” and add it to the link for google fonts
(https://peterdaugaardrasmussen.com/2021/04/02/how-to-add-font-display-swap-to-font-from-google/):

<link type="text/css" rel="stylesheet" href="//fonts.googleapis.com/css?family=Barlow:400,500,600,700%7CAlice&display=swap" id="avia-google-webfont">

Filters will allow to change it.

I uploaded a modified file that implements this solution (replace file enfold\framework\php\class-style-generator.php):

https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_4_8_9_1/framework/class-style-generator.php

As this file is already based on 4.9 release please keep a copy of the original file for fallback (in case you see problems).
If you want to have a copy of the latest dev release let us know.

Best regards,
Günter

Hi,

Sorry for the problem.

With oncoming version 4.9 the problem with the dashes is fixed again – so it is safe to use fonts with dashes.

Problem was caused by a fix in 4.8.9.1 that removed the dashes for websafe fonts (which contained the dashes in theme options) – missing that custom fonts still need them.

Best regards,
Günter

Hi,

Sorry for the late reply.

A theme can only offer a basic implementation. To be on the safe side plugins specialised for GDPR certainly can offer more options and can stay up to date with laws.

Depending on your needs a plugin might be the better solution.

Best regards,
Günter

Hi,

It is not possible to put h2 or h3 tags inside a “p” tag which is the container for the title:

https://stackoverflow.com/questions/42890736/slim-h3-inside-p

I’ve added this problem to our dev repo and planned to address it for 4.9 – check the changelog or https://kriesi.at/support/topic/enfold-upcoming-fixes/

But for the moment there is no easy solution.

Currently the only way is to modify enfold\config-templatebuilder\avia-shortcodes\toggles\toggles.php around lines 1118 – 1124 and replace the p tag.
And add additional logic to identify the element to know how to update the p tag.

Best regards,
Günter

Hi,

I sent it to you right now.
Have a great day.

Best regards,
Günter

Hey Tim,

Thanks for reporting this.

There is really a bug with the lightbox and image element.

If I add the height and width attribute to the img element is that enough or do you still need a filter to manipulate the img html ?

Team Member takes the image size from the media library “Attachment Display Settings” selectbox for sizes.

But you are right, it is more user friendly similar to image element to change the size with a selectbox in the modal popup.
Will add this.

And same to img element – is it enough to add height and width attribute to img html ?

Best regards,
Günter

Hi,

Great it solved the problem.

Sorry for the wrong code. In the next version av-helper-masonry.php is deprecated and a modified code is moved to config-templatebuilder\avia-shortcode-helpers\class-avia-masonry.php and there $this->config exists – and I tested it in this version.

Best regards,
Günter

Hi Tim,

Thanks for digging into this.

I think the best way is to use a filter and limit the changes right in av-helper-masonry.php.

For the next release I added the following filter:

							
/**
 * Allows to add width and height attribute to supress WP filters for responsive images
 * (can be used to server optimized images from an image proxy service like Imgix
 * 
 * @since 4.8.9
 * @param string $img_html
 * @param array $attachment
 * @param array $entry
 * @param array $this->config
 * @return string
 */
$img_html = apply_filters( 'avf_masonry_flex_image_html', $img_html, $attachment, $entry, $this->config );

right before (around line 481)

$img_html = Av_Responsive_Images()->make_image_responsive( $img_html, $thumb_ID, $this->config['lazy_loading'] );

and this is an example how to use it:

https://github.com/KriesiMedia/enfold-library/blob/master/actions%20and%20filters/Images%20and%20Lightbox/avf_masonry_flex_image_html.php

Best regards,
Günter

Hi,

Please replace the content of /enfold/config-woocommerce/config.php with the contents of

https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_4_8_8_1/WooCommerce/config.php

If you need help with it, let us know.

Do not forget to make a backup of the original file for a fallback and clear server and browser cache.

Best regards,
Günter

Hi,

I hope you’ve seen that with 4.8.4 the following files have changed due to post css file support (in case you modified them in child theme):

enfold\config-templatebuilder\avia-shortcodes\masonry_gallery\masonry_gallery.php
enfold\config-templatebuilder\avia-shortcodes\masonry_entries\masonry_entries.php
enfold\config-templatebuilder\avia-shortcodes\av-helper-masonry.php

The attachment url for the image is set by following code in av-helper-masonry.php line 1330:

$this->loop[ $key ]['attachment'] = ! empty( $this->loop[ $key ]['thumb_ID'] ) ? wp_get_attachment_image_src( $this->loop[ $key ]['thumb_ID'], $img_size ) : '';

This is a default WP function.

I hope this helps you to locate the problem.

In case you need a filter that would help let us know.

Best regards,
Günter

Hi,

The release should be out soon.

Best regards,
Günter

Hi,

For next release 4.8.8.1 I added this feature:

add_theme_support( 'avia_options_extended_typography' );

replaces the selectboxes with plain input fields where you can add any valid CSS (there is no check).

To skip your ALB settings for responsive fonts there is a filter:

https://github.com/KriesiMedia/enfold-library/blob/master/actions%20and%20filters/Layout/avf_el_styling_responsive_font_size_skip.php

If you want to have a beta version for testing let us know.

Best regards,
Günter

Hi Tim,

Thanks for your feedback.

ad 1)

That makes sense. I took px because Kriesi did in his default setting (and also in the Advanced Styling tab).
I will change it to plain input fields with a default of px (if no other unit is specified).

ad 2)

For elements that support post css files (like ‘Special Heading’ does) the responsive handling for font sizes in in aviaElementStylingResponsive::add_responsive_font_sizes(…).

What I would suggest is to extend the parameter list with a reference to the shortcode object and add a filter to supress generating the media queries.
That will allow more flexibility without touching any other core code.

ad 3)

Yes, Advanced Styling has priority. Selectors are e.g.

#top #wrap_all .all_colors h1

Selectors from typography tab are simple e.g.:

h1

Best regards,
Günter

Hi,

Adding your code to my function.php the only thing I see are the ” ‘ “.

I modified the code to get a valid syntax on my install (see below).
Can you try that.

What is line 55 in your code above ?

Best regards,
Günter