Forum Replies Created
-
Posts
-
and this should be included in the next patch.
Thank you, Ismael. Really appreciated. We’ll be (all) waiting for next release with this patch.
Mission accomplished: this thread can be considered closed.
All the best, e.-You cannot use an Embed Block inside a Code Block element by default.
So you should disable that function to be possibly applied via Enfold “Advanced Layout Builder”. If you allow people using it – again: we’re not talking about a “Embed Block” inside whatever other block could be – then you should be aware that even a single URI would automatically produce that IFRAME (this is WP standard behavior). We’re not talking about the moon, super sophisticated hacks, reverse engineering; we are referring to just adding a generic site’s address, and that’s it: the site preview is done behind the scenes (even at back-end level), and the problem arises when under such an iframe-rendered preview a huge-unaesthetic-blank space is added, disrupting overall site’s layout.
Did you switch from the Block Editor to the Advanced Layout Builder?
Nope, not at all: only and always used the “Advanced Layout Builder” (no way that I will ever use the standard WP “Block Editor”).
We have forwarded the issue to our channel.
This is super nice, thanks. All the best, e.-
How did you place the Embed block inside a Text Block element?
Well, I simply typed the involved URI, in a new line, at that was it. I did not actually use any Embed block: that IFRAME-embed was done automatically, and it’s the huge space underneath that URI that was our problem. It was a problem also with 5.x Enfold versions, but in last one it has to be taken into account.
Are you going to apply any fix in core-code? Thanks, e.-Thanks, Mike. As for now the viable workaround is just avoiding to qualify straight URIs (with underlying links) inside a paragraph. I’ll be waiting for any update, anyway. Cheers, e.-
So we are referring to this: https://wordpress.org/documentation/article/embed-block/
That’s to say to how default WP “block editor” handles embeds, also with regards to a generic URI (an URI is embedded in terms of an IFRAME presenting the preview of URI’s content).
These are 2 virgin WP setups, one running under 6.5.5 WP, the other running under 6.6.2 (latest) WP version. Both cases theme is the standard “Twenty Twenty-Four” (v1.2).Output is just the same, meaning that soon after URI embed the subsequent “text after link” appears, without any white zone/area.
On the other hand here we have 2 different versions of Enfold (5.7.1 and 6.0.6) which behave in a different way;https://enfold-571.mydemo.it/blog/2024/10/19/hello-world/
https://enfold-606.mydemo.it/blog/2024/10/19/hello-world/In the 1st case (571) the “text after link” appears after a quite wide blank/white-area. That still is acceptable, but not correct.
In the 2nd case (606) the “text after link” appears after a huge and unaesthetic blank/white-area. And that might be a bug.
All those above mentioned 4 sites have no plugins at all.
Any idea? Thanks, e.-Hi Mike, I will surely follow your suggestions. See you here at the beginning of next week.
Cheers, e.-Even better: I will simulate the whole thing via to 2 identical sites, both virgin (no plugins at all, WP last release), and one being the clone of the other.
1st one will have the 5.x version of Enfold running, and the 2nd one will have Enfold last release.
Same code, same DB (schema/structure), same use case scenario. And you’ll see that 5.x version of Enfold will produce one output, whilst Enfold last release will parse a completely different one (unexpected, and breaking the standard page-layout), for the same URI/resource.
I’ll come back here within few days. Cheers, e.-So, dear Mike, we are all beta-testers, and we cannot report issues if not paying before being able to? If product license is perpetual, then I suppose to have a perpetual_and_working product. If the product I’ve paid for is not working in some of it’s functionalities (and this happens because of some version upgrade), then I suppose I can report the issues I face, just waiting for next commit to come, and to hopefully solve them all.
Again: should I pay to just report few bugs (with regards to a product I’m allowed to download to its latest release)?
I’m really curious about you reply. Thanks in advance, and best regards, e.-Thanks Mike. Kinda odd that discovering bugs (because this is what we’re facing, soon after major update), and reporting them to the community, would be only possible after having paid for “support”. I’m not asking for support: I’m just asking that evident bugs are fixed, based on the evidence that we ourselves would go on to document in depth. We report bugs, and we should be paid for that? Shouldn’t it in fact be just the opposite? After all, we are working for you, thus helping you improve a commercial product (i.e.: purchased, i.e.: paid by us). Thanks for further replies, if any.
Cheers, e.-Removed staging sites, and Enfold updated in production site (https://www.annamariamartinolli.it/).
So the working links (which behave as expected) are now:
– https://www.annamariamartinolli.it/servizi/tipologie/
– https://www.annamariamartinolli.it/2022/01/18/willy-wonka-e-la-fabbrica-di-cioccolato-1971-tra-i-film-della-biblioteca-del-congresso/
Thanks again for support, and best regards, e.-Thank you Yigit!
I’ve upgraded Enfold, to the latest available version, in https://enfold-4871.annamariamartinolli.it/
Seems that both pages now behave as expected;
– https://enfold-4871.annamariamartinolli.it/servizi/tipologie/
– https://enfold-4871.annamariamartinolli.it/2022/01/18/willy-wonka-e-la-fabbrica-di-cioccolato-1971-tra-i-film-della-biblioteca-del-congresso/
So we’re finally going to update Enfold also in production site (https://www.annamariamartinolli.it/).
Thanks again for support, and best regards, e.-Thank you so much, dear Günter. We’ll be waiting for Enfoled ver. 4.9.2.2 to be released during next days. Eventually keep me kindly posted here, when the time would have been arrived. All the best, e.-
Hello everyone,
coming back here because the upgrade from ver. 4.8.7.1 to 4.9.2.1 still presents some annoying issues.
One above all (which I also saw before, but I thought it was dealing with Icon Grid itself) is that previous widget assignments are lost after the upgrade.So I have cloned https://www.annamariamartinolli.it in two staging sites:
– https://enfold-4871.annamariamartinolli.it (with the 4.8.7.1 version of Enfold)
– https://enfold-4921.annamariamartinolli.it (with the 4.9.2.1 last version of Enfold)As you can see we have lost the widget dealing with menu’s structure, on the right column:
– https://enfold-4871.annamariamartinolli.it/servizi/tipologie/ (we have the “SERVIZI” widget in place)
– https://enfold-4921.annamariamartinolli.it/servizi/tipologie/ (we do NOT have any “SERVIZI” widget in place anymore, and also Icon Grid elements padding is not strictly respected)This happens for any page, also the ones which count hundreds (consider we’re referring to a multi-language WPML powered site):
– https://enfold-4871.annamariamartinolli.it/2022/01/18/willy-wonka-e-la-fabbrica-di-cioccolato-1971-tra-i-film-della-biblioteca-del-congresso/ (we have the “CATALOGO” widget in place)
– https://enfold-4921.annamariamartinolli.it/2022/01/18/willy-wonka-e-la-fabbrica-di-cioccolato-1971-tra-i-film-della-biblioteca-del-congresso/ (we do NOT have any “CATALOGO” widget in place anymore)Of course manually re-assigning the correct/original widget for any of those hundreds pages is not a viable solution, and that’s why I’m asking support, to just understand what might have happened, and why. We just upgraded Enfold, nothing else, but we now need a fix for this, of course.
WP’s backend and FTP credentials, with regards to the above mentioned staging sites, have been provided via Private Content textarea.Thanks in advance for investigations, and best regards, e.-
Ok, Günter, thanks. So there should be that substitution in place, acknowledged.
please save theme options to force a recreation of the post css files to reflect the changes
Are you basically saying that I should export theme options, then applying the above mentioned substitution, finally re-import the same theme options?
The widget area is empty on the staging site.
Yep, it’s true, and it should not have happened (not surely during Installatron clonation): maybe someone of you has deleted that widget’s content, just for testing. This is not a problem, anyway: staging sites are made for even break things up.
All the best, e.-
but updating the element does
Which, in terms of me being able to fix things under 4.9, actually means?
In the end I want that Enfold upgrade (4.8.7.1 > 4.9) for the production site, but I still haven’t got precise instructions on how proceeding.
Thanks, e.-BTW: if you need further investigations, another cloned version on that site (under Enfold 4.8.7.1) is reachable here:
Credentials for accessing it – as admin, of course – are the same as the ones already given in private communication.
Thanks for checking (debugging, and hopefully fixing), e.-This is how that page should appear (also under 4.9, but it works fine only in 4.8.7.1):
This is how it actually is (4.9)
The entire layout has changed (more than just one thing seems to be broken – again: because of the simple upgrade from 4.8.7.1 to 4.9).
Thanks, e.-So I have removed this part (the sick one):
Having left unchanged only this other one (the healthy) one:
As a matter of fact we now have the issue (already present also before, inside the 4.9 version of Enfold, but I did not initially realized) of right menu having been disappeared, as per:
While that right menu (widget area) is well defined in backend:
So I think there’s more to dig into, as for now…
Any help/hack/fix? Thanks in advance, and best regards, e.-Thank you Yigit. I isolated the two portions of code (btw: thanks for suggestions on how enabling debug mode) and I actually see some (relevant) differences:
Please remove old Icon Grid elements, then copy shortcodes from test pages and paste them into your live pages :)
This is exactly what I’m gonna do, within minutes! :-)
So, in the end, we’ve understood that those (IMHO: relevant) differences, in generated shortcodes, are in effect responsible of icongrid layout being corrupted in Enfold 4.9 (if code – parsed by icongrid module in 4.8.7.1 – is injected into pages under 4.9).
I’ll keep you (all) posted, soon after having done on “live” site. All the best, and thanks for the provided support, e.-Now I get the point: “icongrid_old.css” is actually inside the standard Enfold 4.9 package (and it’s presence, there, should be BTW avoided – message for admins/developers). This is the additional proof that something massive has happened in the passage from previous Enfold’s version to this 4.9 last one. I suppose that “icongrid_old.css” in 4.9 has the same content of “icongrid.css” in 4.8.7.1. Anyway: it would be really appreciated if any admin/moderator could have his voice being heard by us, as this is supposed to be definitely clarified, from Enfold/Kriesi side. Isn’t it Guenni007? :-) Cheers, e.-
I have only looked through the contents of the folders in Enfold 4.9. There you can see the files
Directory listing is – of course – disabled here: https://enfold.stage.annamariamartinolli.it/wp-content/themes/enfold/config-templatebuilder/avia-shortcodes/icongrid/
So I still do not get how you were able – even without WP backend’s credentials – to “see” this (FTP client, tuned into the correct directory): https://i.imgur.com/sFHKQdJ.png
There something which I’m actually missing, here… :-)PS: i’m participant as you – so i do not see private Content area that you posted – including logins etc.
Dear Guenni007, I thought you were an admin/moderator, thus having access to the credentials I sent in private area, furthermore considering that you “saw” “icongrid_old.css”, which is not supposed to be public information. So: how did you get such an evidence (without credentials for accessing WP’s backend or file system)?
Anyway the switch to default editor does not work for that page, as per https://i.imgur.com/KaQraKw.png
And we’ve finally discovered that the weird behavior of that Icon Grid module depends, in the end, on the specific values which have been set in module’s backend, in terms of its possible/allowed customizations. So now we have a path to follow, by fine tuning/tweaking those values, for finally reaching the desired FE/UX experience.
To the admins/moderators/developers: this is actually a bug, so kindly revise the whole thread and produce a commit for next Enfold’s release.
All the best to you all, and to Guenni007 in particular. Cheers, e.-the min-height is calculated in icongrid.js
Exactly.
As I said: there is no custom CSS, no overrides. Everything is handled by Enfold’s backend itself. So: did we actually discover a bug?
I mean: I can surely change some custom configurations, specifically applied for that module, but – as a matter of fact – those same/identical configurations simply work, as expected, in 4.8.7.1 version of Enfold; whilst on 4.9 version they just don’t (anymore).
Thanks for sharing additional thoughts on this.
All the best, e.-Now we might possibly dig deeper, and do the definitive simulation: having a brand-new-virgin WP installation, with 4.9 version of Enfold and no child-theme at all, and testing whether or not “Icon Grid” (Image Flip Box) is working
So this is a virgin WP (last version) install, with no plugins, and Enfold 4.9 (last version): https://enfold49.annamariamartinolli.it/index.php/about/our-story/
As you can see we face the same-identical issue we also see here (as already reported): https://enfold.stage.annamariamartinolli.it/servizi/tipologie/
Whilst on 4.8.7.1 version of Enfold that layout is not broken at all: https://www.annamariamartinolli.it/servizi/tipologie/
And, finally, there’s no child-theme.
In the end it might be the way that “Icon Grid” module has been customized, via backend (i.e.: using Enfold itself, not via CSS overrides).
Still this is not expected behavior (thus a possible bug). Credentials for accessing “enfold49.annamariamartinolli.it” are the same as the ones already delivered for accessing “enfold.stage.annamariamartinolli.it”. So you can give it a try/look, if you want.
Thanks, e.-Dear Guenni007,
thank you again for your investigations (and for smart insights of yours, on when and how to use child-themes), but IMHO this “flipping icons do not work any longer for mobile devices only” old ticket is actually misleading. That (May 20, 2021) was the case in which “Icon Grid” stop working as expected, after Enfold update to 4.8.2 version, but “for mobile devices only”.
What we face, as for now, is another/different issue, again dealing with “Icon Grid”, and faced after Enfold upgrade from ver. 4.8.7.1 to 4.9. As I previously states those old icongrid.js modifications (which Ismael – “look for this code around line 28” – suggested; and, BTW, on parent-theme, as child-theme was not anyhow recalled) have been overwritten during past months because of further Enfold updates (from May 2021 till now there have been at least 2 other Enfold updates, done by us), which have possibly applied the same fixes, and in fact we did not face any similar issue so far (up to 4.8.7.1).
Let’s now forget this child/parent situation, and let’s focus on the topic, and its real trigger.
We have (“www”) a 4.8.7.1 version of Enfold in which “Icon Grid” (Image Flip Box) is not broken, behaves as expected, and refers to “official” Enfold (4.8.7.1) source code (meaning: no overrides via child-theme). And we also have (“enfold.stage”) a 4.9 version of Enfold in which “Icon Grid” (Image Flip Box) is actually broken. The only difference is 4.8.7.1 on one hand, and 4.9 on the other hand. All the remaining parts of those sites are identical as being “enfold.stage” the clone of “www”.
As I pointed out there are a lot of modifications in icongrid.css, icongrid.js and icongrid.php, with the passage from 4.8.7.1 to 4.9. And surely some of such modifications is now responsible of unexpected behavior on “enfold.stage” (4.9 version of Enfold).
Now we might possibly dig deeper, and do the definitive simulation: having a brand-new-virgin WP installation, with 4.9 version of Enfold and no child-theme at all, and testing whether or not “Icon Grid” (Image Flip Box) is working. I can surely do this, but I’d prefer having some further thoughts/advise from you on this specific scenario, which I think has been clearly described.
Thanks in advance, and best regards, e.-So I had a diff/merge session (via MELD) with regards to these two “icongrid” directories:
– /public_html/wp-content/themes/enfold/config-templatebuilder/avia-shortcodes/icongrid/
– /subdomains/enfold.stage/wp-content/themes/enfold/config-templatebuilder/avia-shortcodes/icongrid/
And I do confirm that there are *a lot* of differences in all those three files, which are the only ones inside them:
– icongrid.css
– icongrid.js
– icongrid.php
Funny thing is that the modifications suggested in https://kriesi.at/support/topic/icons-grids-links-not-working-for-mobile-devices-after-update-to-4-8-2-version/#post-1301568 – with regards to “enfold/config-templatebuilder/avia-shortcodes/icongrid/icongrid.js” – are not present neither in “www”, nor in “enfold.stage”.
So this implies a simple conclusion: those patches have been applied in mother-theme, a long time ago, and they have been overwritten by theme’s updates (which we apply once every few months). In the end, this having all said and considered, I still thing this might be a bug, introduced by 4.9 version of Enfold, and I could also simulate such with a virgin WP+ENFOLD (4.9) installation, if needed.
What would you suggest me doing, now? To just keep a copy of the files as for now present in /public_html/wp-content/themes/enfold/config-templatebuilder/avia-shortcodes/icongrid/, so to overwrite the new ones (that would be introduced if we upgrade ENFOLD in “www”) with this local copy?
Thanks again and best regards, e.-Hi Guenni007, and thanks for suggestions.
I see that you have already disabled WP-Rocket (and I have cleared CSS/JS cache on ENFLOD: https://enfold.stage.annamariamartinolli.it/wp-admin/admin.php?page=avia)
Nevertheless we still face unexpected behavior, as per:
https://enfold.stage.annamariamartinolli.it/servizi/tipologie/ (broken layout)
VS
https://www.annamariamartinolli.it/servizi/tipologie/ (layout as designed, as always worked)
And also:
https://enfold.stage.annamariamartinolli.it/catalogo/copioni-teatrali/ (broken layout; meaning: compressed images)
VS
https://www.annamariamartinolli.it/catalogo/copioni-teatrali/ (layout as designed, as always worked)
Now going to check whether or not those suggested JS modifications have been applied at child-theme level (quite sure) or inside the ENFOLD main theme itself. I’ll be back in minutes. Thanks&Cheers, e.-
