Page builder's min-height seems to be causing problems

OK thanks. But that CSS looks like a workaround fix to the overarching issue. Why is the min-height being added in the first place? I would much rather ascertain that, and if possible, ensure it is not added, rather than add additional code just to undo it.

>> The minimum height property is probably added automatically by the slider because it’s not from the theme.

As a test, I created two pages, one using Avia page builder and one using classic editor. To each I added the same Slider Revolution slider:

https://wordpress-dev.feedxl.com/themepunch-original/ is created without Avia page builder. It does not have any min-height added to any element.
https://wordpress-dev.feedxl.com/themepunch/ is created with the Avia page builder. Its element div#revolutionslider_1 has a min-height of 901px.

So why does using the Avia page builder add a min-height?

>> And if you noticed the actual revolution slider wrapper’s height property value is the same as the value of the minimum height, so it’s possible that the slider applies it on both the wrapper and its parent container.

On my home page (https://feedxl.com/), the min-height CSS property is applied only to div#revolutionslider_1, and not to div#rev_slider_2_1_forcefullwidth (screenshots). Are you seeing otherwise?

Thanks.

I appreciate your help. But I’d really prefer it if you directly answered my questions–it will really help me understand the situation and resolve the issue. If we could just backup and proceed slowly, I would very much appreciate it:

>> The minimum height property is probably added automatically by the slider because it’s not from the theme.

As a test, I created two pages, one using Avia page builder and one using classic editor. To each I added the same Slider Revolution slider:

https://wordpress-dev.feedxl.com/themepunch-original/ is created without Avia page builder. It does not have any min-height added to any element.
https://wordpress-dev.feedxl.com/themepunch/ is created with the Avia page builder. Its element div#revolutionslider_1 has a min-height of 901px.

1. Why does using the Avia page builder add a min-height?

>> And if you noticed the actual revolution slider wrapper’s height property value is the same as the value of the minimum height, so it’s possible that the slider applies it on both the wrapper and its parent container.

On my home page (https://feedxl.com/), the min-height CSS property is applied only to div#revolutionslider_1, and not to div#rev_slider_2_1_forcefullwidth (screenshots).

2. Do you see the same thing on your end?

I have numbered each of my questions. When you answer a question, for clarity, can you please indicate which question number you are answering? If you do not know the answer to a question, please just say, “I don’t know.”

Thanks.

>> you’ll see the inline style with the height property and the value is the same as the minimum height of the avia-revolutionslider container.

OK. But my question is solely about the min-height on the avia-revolutionslider container.

>> I’ll ask one of the developers to check the thread because I can’t find any scripts from the theme that applies the height to the containers.

Thank you, that would be very helpful.

>> Again, you can always use css to adjust the height of slider on mobile.

Again, I realize that, thank you. But I’m trying to understand why the page builder is adding a min-height to this element.

>> the minimum height is added directly in the config-templatebuilder > aviashortcodes > slideshow_revolution.php file, around line 149. It was provided by the revolution slider team to a fix an issue on v6.0.

OK. I understand that the code was given to you by the Slider Revolution team to fix a particular issue. But would you agree that as a side effect it is also causing a separate issue–namely, the issue I have raised in this ticket?

Is there any way I can speak with Guenter directly? It might make this ticket come to a resolution more quickly.

>> The fix provided by Slider Revolution team was given us by another user

I’m confused–was the PHP code given to you by one of the Slider Rev developers? Or by an Enfold user?

>> As you are a customer of them best would be to open a support ticket there so they can check your sliders and find the reason why the provided fix is not working in your case and how we can get the right heights for your situation to set CSS properly.

I already opened a ticket with them. They said the min-height is being added by the Enfold code base, so therefore they cannot do anything about it. And that seems pretty logical to me.

>> I have no idea how to use this slider and we do not have any connection to the RevSlider Team.

Code from the Enfold theme–specifically the code adding the min-height–is causing an issue here. Wouldn’t you agree?

>> The code for min-height was provided by RevSlider (https://kriesi.at/support/topic/revolution-slider-9/#post-1118183).

I read that post. It looks like the code was provided by a used named ‘Zacc,’ who claimed he received it from Slider Revolution. It doesn’t look like you ever actually communicated with Slider Rev devs. Or am I misunderstanding something there?

The bottom line is that this min-height line of code exists in the Enfold code base. So ultimately, Enfold is responsible for understanding what it does, and fixing any issues it causes. Wouldn’t you agree?

I guess the ultimate question is this. It’s clear that code in the Enfold theme is causing a problem on my site (and perhaps others). Do you have any plans to fix it? I don’t think I’m being unreasonable to expect you to address it. If you explicitly tell me you have no plans to fix it, then there’s not too much I can do. But at least tell me, so I can move forward with an alternative solution.

Thanks.

Hi Gunter,

Thanks for the assistance, and sorry for the delay. I have your new PHP file a shot. I saved it to the correct directory, and even added an error log statement to the file so I know it is executing as expected. But the issue still seems to be present. Namely, the element in-question still seems to possess a min-height inline style (screenshot). I even gave the page a hard refresh, but still see the min-height present. Thoughts?

Let me know if you want access to my site and I can provide it.

Thanks.

Hi Gunter,

I have an update. First of all, I have three separate sites:

1. a local site
2. an online staging site
3. an online live site

So far, I have been working on my local site. On my local site, when I replace the file (slideshow_revolution.php) with your updated file, there is no change–the min-height is still present. But when I do the same on the online staging site, it *does* resolve the issue, i.e. the min-height is removed on the element, as expected and as desired. That’s great, but can you help me figure out why the issue is still present on my local site? I realize it is difficult for you to troubleshoot, but let me describe what troubleshooting I’ve done so far.

On my local site, at the top of slideshow_revolution.php (your new revised version), I have added two error log print statements: one before if ( ! class_exists( ‘avia_sc_revolutionslider’ ) && function_exists( ‘rev_slider_shortcode’ ) ) and one after (screenshot). When I load the page in-question, only the first statement is printed to the error log. So apparently the class avia_sc_revolutionslider already exists, or the function rev_slider_shortcode does not exist. I did some more testing, and this evaluates to true: class_exists( ‘avia_sc_revolutionslider’ ), which seems to be causing the issue. That needs to evaluate to false, correct? If not, none of the subsequent code is executed. But I’m still not sure why my local site and my staging site are discrepant in this manner…

>> Yes please – and let me also have access to the php code so I can check it (and edit it) – and a link to the page please.

I of course cannot share with you access to my local site. But would you still like access to my staging site?

>> Is the slider created with an older version of rev slider? If yes this could be a reason why min-height is still present.
>> Try to save the slider again.

Yes, the slider was created using an older version of Rev Slider. I’m not sure on the exact version number. But I tried re-saving the slider, but with no change in results.

>> You also can try to replace in file enfold\config-templatebuilder\avia-shortcodes\slideshow_revolution.php line 141:

Do you think it would be worthwhile to carry this out on my local site, given the symptoms I’ve described?

>> Clear all server cache and browser cache.

Yes indeed, I’have been doing that along the way.

Thanks.

Hi Gunter,

Actually I figured out the cause of the issue on my local site. On my staging site, I renamed the old PHP file to slideshow_revolution.php-bak. As a result, only the NEW PHP file (slideshow_revolution.php) was executed. But on my local site, I renamed the old PHP file to slideshow_revolution-old.php. As a result, both the old PHP file and the new PHP file were executed. Once I renamed the file to slideshow_revolution.php-bak, the issue went away, i.e. the min-height was no longer applied to the element.

I’ve actually experienced Enfold behavior like this in the past, in another ticket, i.e. simply renaming the PHP file was not enough–I had to give it an extension different from PHP. This behavior is a bit different to all other sites I’ve managed. Can you explain why this behavior is occurring? Is it expected, and/or beneficial in some way?

Thanks.

OK cheers for all that. We can consider this resolved.