Validity of code to disable Google Maps

Hi,

To be sure of what I said, I have restored a fresh backup on the DEV website, commented out the Google Maps code in functions.php (lines 538-596) and installed Query Monitor so you can check for yourself. I have disabled compression in the theme for now.

Without that code Google Maps js is loaded in the admin area. Google ReCaptcha is also loaded in the admin area.
The options you mentioned earlier in the theme settings work fine, but only for the frontend. In the backend things are like I described here.

Login info in private window. Thanks for taking a look at this,

Rob

Hi Ismael,

Thanks for the info and time. Yes, it’s nice that I can manually take care of it.
Yes, I need to disable these scripts and the link to Google(!). The same for Google ReCaptcha script.
Not only are they not needed when not used, they also slow down the backend when Google can’t be reached for some reason.

That is exactly my point: if I don’t use Google Maps at all, why would Enfold need to validate the API key at all? Same for ReCaptcha.

I think this is without doubt something that needs to be handled by the general theme settings as well, automatically. When elements are not used, then the associated scripts and styles should not load anywhere, neither frontend nor backend. They should ONLY load when required. Dot.

You say: the scripts are required in the backend because the theme has to validate the API key, which is needed in order to use the map API. I say NO. The theme doesn’t need to validate the API key, not until I start to choose to use the GMaps element…

And the same holds true for any other theme component, especially when external / third party..

Have a good day,

Rob

• This reply was modified 3 years, 1 month ago by rob2701.

Hi Ismael,

As usual thanks to you and the rest of the team for your attention and for all the hard work. Much appreciated! And thanks to all for taking a look at this.

On a related note, when testing several options,I found that these two filter generate warnings, you may also want to look at that. Neither seems to work for the backend, by the way.

// Google Maps solution after Enfold 4.5.x
// -- this disables all googlemap scripts handles frontend: avia_google_maps_front_script 
// -- and backend: avia-google-maps-api, avia_google_maps_api_script 
add_filter( ‘avf_load_google_map_api_prohibited’, ‘__return_true’ );
// This disables loading of Google ReCaptcha in the backend
add_filter( ‘avf_skip_enqueue_scripts_backend_grecaptcha’, ‘__return_true’ );

Warnings:

Warning	Use of undefined constant ‘avf_load_google_map_api_prohibited’ - assumed '‘avf_load_google_map_api_prohibited’' (this will throw an Error in a future version of PHP)

Warning	Use of undefined constant ‘avf_skip_enqueue_scripts_backend_grecaptcha’ - assumed '‘avf_skip_enqueue_scripts_backend_grecaptcha’' (this will throw an Error in a future version of PHP)

Correction:
My bad! That’s what I get as punishment for not wrapping it in a function… Embarassing…

Have a good day!
Rob

P.S.
This code from this post still seems to work however:
https://kriesi.at/support/topic/proper-method-to-disable-google-maps-in-enfold/#post-1186977

• This reply was modified 3 years, 1 month ago by rob2701. Reason: Added link to code in pastebin from a post from Nikko

Hi,

Just to let you know that your code for the filters to prevent the backend loading of Google Maps and Google Maps API works just fine. They are gone from the backend, thanks! I’m a happy camper. :-)
I added the one for dequeueing the Google ReCaptcha js as well, and that works fine too:

// Disable loading of Google ReCaptcha script in theme backend
add_filter("avf_skip_enqueue_scripts_backend_grecaptcha", function($skip) {
   return "skip_loading";
}, 10, 1);

I wish I had found these filters and the proper way to use them earlier, then I wouldn’t have had to waste so much of your time. :-)
Thanks again for your help and patience and have a good evening (or morning/afternoon/night depending on where you are).

Solved.

Rob