Viewing 7 posts - 1 through 7 (of 7 total)
  • Author
    Posts
  • #342404

    Hey Guys,

    is there a way so that a front page created as on http://kriesi.at/themes/enfold-business-flat/ gets HTML-valid?

    Please see http://validator.w3.org/check?uri=http%3A%2F%2Fkriesi.at%2Fthemes%2Fenfold-business-flat%2F&charset=%28detect+automatically%29&doctype=Inline&group=0 for errors.

    In my implementation, I get the following 2 errors:

    1. No space between attributes
    2. Attribute ; not allowed on element span at this point

    Thanks a lot!
    Best, Simon

    #343577

    Hi Simon!

    its not 100% the same, but I think very similar: https://kriesi.at/support/topic/enfold-and-httpthemecheck-org/#post-342704

    Regards,
    Andy

    #343700

    Hi Andy,

    the “client” is me ;-) I know the pros & cons of the W3C HTML / CSS validation very well, therefore I did not come up with the (very) “invalid” CSS of Enfold. In case of Enfold, these WC3 CSS validation errors can be ignored savely IMHO.

    But the W3C HTML validation should not give any errors. All Enfold sites pass the W3C HTML validation. But the “Business Theme” (I only tested the front page) does not, and this could be fixed pretty fast & easy (it’s only 19 errors, most of them are the same).

    There are many strong arguments for (W3C) valid HTML. I suppose there has been done some effort to Enfold to make it HTML valid (otherwise it’s kind of unlikely that it passes the W3C HTML validation). Therefore it would be great to have this for the “Business Theme” too.

    In case you do not want to fix this, maybe you can give me some advice where those errors are generated in the source code (this affects only the front page), so I can dig into the source code & fix this on my own (just the errors, not the warnings).

    Thanks!
    Regards, Simon

    • This reply was modified 10 years ago by Simon.
    #344518

    Hey!

    These errors are just false positives which checkers marked as invalid structure because the validation does not take into account cross browser compatibility such as vendor extensions which is totally required to make these complex themes work. Not to mention unconventional and modern techniques. Any premium themes, plugins and anything designed to have maximum compatibility for users or includes more than basic functionality will not pass these tests.

    Cheers!
    Ismael

    #348018

    I don’t think so ;-)

    Just for those who’d like to get valid html, go to hr.php, lines 262 – 263 and change …

    $inner_style = "style='{$inner_style}'; ";
    $style = "style='{$style}'; ";

    to …

    $inner_style = "style='{$inner_style}' ";
    $style = "style='{$style}' ";

    Cheers!

    #348405

    Hey!

    Thanks for your feedback Simon, i’ll let Kriesi know :)

    Best regards,
    Josue

    #379964

    thanks, we have added this to the theme ;)

Viewing 7 posts - 1 through 7 (of 7 total)
  • You must be logged in to reply to this topic.