Viewing 12 posts - 1 through 12 (of 12 total)
  • Author
    Posts
  • #824584

    Hi,

    When using Tab Section in RTL mode,
    and when av-tab-section-tab-title-container contains more items than the screen width,
    that whole av-tab-section-tab-title-container goes left, and creating a gap in the right.

    Please advise.

    Tnx

    #828923

    and… when the screen is narrow (example: iPhone 6 Plus). the whole component is almost not visible any more.

    Please advise ASAP.

    Thank you.

    #829241

    Hi,

    Thank you for reporting that issues.
    It seems that it is a bug from the theme.
    We will do report it to our developers so they can check it out and release an update.

    Best regards,
    Basilis

    #829398
    This reply has been marked as private.
    #831419

    Hi alonarad,

    Please refer to this thread for a possible solution.

    If you need further assistance please let us know.
    Best regards,
    Victoria

    #831450

    Hi,

    In the thread you mentioned above, you solve the problem of av-tab-section-inner-container in RTL, but it caused the issue I’m taking about here.

    So I still don’t have a solution.

    Please advise ASAP.

    Tnx.

    #833961

    Hi,

    Thank you very much for using our theme and sorry for the late reply to this issue.

    On your page I found 2 problems which will be solved in the next update. Meanwhile please do the following updates:

    File enfold\js\shortcodes.js around line 2961 you find the function:

    
    
                            set_tab_titlte_pos = function()
    			{
                                  ......
                            },
    
    

    Please replace this code by:

    
    
    			set_tab_titlte_pos = function()
    			{
    				//	scroll the tabs if there is not enough room to display them all - rtl allign right to left !!
    				var current_tab = container.find('.av-active-tab-title'),
    					viewport	= container.width(),
    					left_pos	= ( current_tab.position().left * - 1) - (current_tab.outerWidth() / 2) + (viewport / 2);
    			
    				if( ! $('body').hasClass("rtl") )
    				{
    					if( viewport >= min_width )
    					{
    						left_pos = 0;
    					}
    					
    					if(left_pos + min_width < viewport) left_pos = (min_width - viewport) * -1;
    					if(left_pos > 0) left_pos = 0;
    				
    					tab_wrap.css('left',left_pos );
    				}
    				else
    				{
    					var right_pos = 0;
    					
    					if( viewport < min_width )
    					{
    						if( left_pos + min_width > viewport )
    						{
    							if( left_pos > 0 ) left_pos = 0;
    							
    							var right_pos = (left_pos + min_width - viewport) * -1;
    							tab_wrap.css('left', 'auto' );
    							tab_wrap.css('right', right_pos );
    						}
    					}
    					tab_wrap.css('left', 'auto' );
    					tab_wrap.css('right', right_pos );
    				}
    			},
    
    

    This should fix the problem with the tab section titles.

    In file enfold\config-templatebuilder\avia-shortcodes\tab_section.php around line 451 you find the code

    
    
    $tab_link = AviaHelper::save_string($tab_title,'-');
    
    

    Replace this line with:

    
    
    $tab_link = AviaHelper::save_string($tab_title,'-') . '-1';
    
    

    This should fix the problem with jumping to the top of the page when clicking on a section tab.

    If you have problems to update the files please let us know. Give us FTP access and a WP admin account and we can do it for you.

    Make sure, you are using the latest version Enfold 4.1.2.

    Best regards,
    Günter

    #840337

    Sorry, but it’s not working.

    The 1st fix divide the section titles into 2 lines.
    The 2nd fix add “-1” to the url.

    #840361

    My mistake – Sorry.

    The solutions works!!
    (although the 2nd fix still add “-1” to the url)

    I made the fixes in the parent theme.
    Can I assume that the next version will overwrite this and contain the solution built-in?

    Tnx.

    #840369

    Hi,

    Thank you for coming back.

    The 2nd fix add “-1” to the url.

    This is intended to get a valid href. As your title returns an empty string the href results in # which jumps to the top.

    But I improved this line. Please use instead:

    
       $tab_link = AviaHelper::save_string($tab_title,'-');
       if( empty($tab_link)) $tab_link = 'av-tab-section-' . avia_sc_tab_section::$count . '-' . $i;
    

    The 1st fix divide the section titles into 2 lines.

    I checked it on my local install and it works for me.

    I uploaded the complete modified content of file enfold\js\shortcodes.js.

    Please replace the complete content of this file with the RAW paste content of

    https://pastebin.com/k4ib589u

    This link is valid for one week. Make sure to make a copy of the original file to have a fallback and that you are using Enfold 4.1.2.

    Please clear your browser cache, server cache and reload the page (sometimes you need to close the browser and reopen a new browser window and reload the page several times).

    If you still have problem, please post us your login credentials (in the “private data” field), so we can take a look at your backend and FTP access to update the files.

    1. Install and activate ” Temporary Login Without Password “.
    2. Go to ” Users > Temporary Logins ” on the left-side menu.
    3. Click ” Create New “.
    4. Add the email address for the account ( you can use wordpress@kriesi.at ), as well as the ” Role ” making that the highest possible and the expiry about four days
      ( do be sure that we have enough time to debug ).
    5. Click ” Submit “.
    6. You’ll now have a temporary account. Please provide us here in the private section the URL, so we can login and help you out.

    When your issue is fixed, you can always remove the plugin!

    Alternativ you can create a WP admin user for us and post the login details as usual.

    Best regards,
    Günter

    • This reply was modified 2 years, 6 months ago by  Günter.
    #841625

    Thank you, It all seems to work now.

    I made the fixes in the parent theme.
    Can I assume that the next version will overwrite this and contain the solution built-in?

    Tnx.

    #841644

    Hi,

    Glad the fix works now.

    I marked this patches as high priority on our gihub repository so Kriesi should merge it into the next update.

    Feel free to open new threads if further questions or problems occur.

    Enjoy the theme and have a nice day.

    Best regards,
    Günter

Viewing 12 posts - 1 through 12 (of 12 total)

The topic ‘Tab Section – RTL’ is closed to new replies.