Tagged: 

Viewing 11 posts - 1 through 11 (of 11 total)
  • Author
    Posts
  • July 27, 2017 at 12:06 pm #830594
    Jay

    Pagination for new Tab Section is broken

    It is perfectly acceptable to include a Masonry Element in the Tab section with either “Pagination” enabled or using “Load More” Button. Neither of them work properly under Tabbed Section. The fix should be relatively simple to put in place.

    There are two issues that occur. Here is a demo page that show the issues: https://visualwilderness.com/dfgs434534fdf

    Issue 1: Page Height does not change when you hit Load More Button if the Tabbed Section is configured as “Auto Adjust to Content”. You can try this out on the page under “Load More” tab in Chrome Desktop Browser.
    Issue 2: Pagination does not work on Masonry Element if the element is NOT on the first tab. You an try it out on the tab marked “Pagination”. This issue is that after fetching the correct page for the masonry element the page defaults to the first tab…instead of displaying the tab that triggered page fetch.

    If you guys have a function.php fix, I would be happy to try this out on my site and report back.

    FYI: While you are fixing this issue you may want to check of other elements that uses “Load More” and Pagination work properly. I have not checked this.

    • This topic was modified 7 years, 4 months ago by Jay.
    August 1, 2017 at 11:33 am #832768
    Ismael

    Hey pateljx,

    Thank you for using Enfold.

    Please edit the js > shortcodes.js file then look for the Tab Section function. Replace the whole function with the following.

    // https://pastebin.com/6QNCuh9T

    Best regards,
    Ismael

    August 1, 2017 at 1:01 pm #832829
    Jay

    @Ismael
    Thanks….I will try this out today and let you know what happens.

    What is the long term solution for this?

    August 2, 2017 at 12:35 pm #833391
    Guenni007

    oh – i will try too. isn’t there a functions.php trick to overwrite that orig function and set up the new function in child-theme?

    Edit: see here (primitive but just to see what has changed! : https://webers-testseite.de/ajax-portfolio/

    it seems not to work as expected.
    The pagination leeds to tab 1
    The container gets bigger on case one – load more button ! OK

    • This reply was modified 7 years, 4 months ago by Guenni007.
    August 3, 2017 at 9:27 pm #834028
    Jay

    Here is my report…It is consistent with Guenni007.

    First the good news: Load More on the first tab appears to be fixed.

    Now things that do not work and thing that were working seem broken

    • Pagination on the second tab is still borken
    • I am also not seeing the unique URL that defined each tab. So the URL for the middle tab should be https://visualwilderness.com/dfgs434534fdf#pagination. However it is NO longer the case. This URL takes you the first tab.

    I have left your fix in place. You can see this on my website at: https://visualwilderness.com/dfgs434534fdf

    • This reply was modified 7 years, 4 months ago by Jay.
    August 6, 2017 at 6:15 am #834932
    Ismael

    Hi,

    Pagination on the second tab is still borken

    By default, WordPress doesn’t allow multiple pagination on a single page unless you have an AJAX plugin that can handle multiple paged query. Unfortunately, the theme doesn’t have that feature yet. For now, please refrain from enabling multiple paginations on a single page.

    Best regards,
    Ismael

    August 6, 2017 at 1:49 pm #835025
    Jay

    Ismael,

    Thanks for the response. Hope you will make this fix available to general release soon.

    August 6, 2017 at 1:58 pm #835027
    Jay

    Ismael,
    I just update my theme to 4.1.2. Is this fix included in this release?

    Because I see that the the “Load More” behavior on the Chrome Desktop Browser (Win10) is very inconsistent after the upgrade.

    August 12, 2017 at 5:57 am #837729
    Ismael

    Hi,

    The fix is not included on 4.1.2 yet. We’re still testing it because it does produce inconsistent results. Please re-do the modification for now.

    Best regards,
    Ismael

    August 12, 2017 at 12:31 pm #837835
    Jay

    Ismael,

    Thanks for the update…I hope you guys figure this out. The Tabbed Section is a superb addition and provides fantastic way to organize the photos. I will redo the mods for now.

    Thanks.
    -Jay

    August 12, 2017 at 2:39 pm #837892
    Victoria

    Hi Jay,

    Thank you for your patience :)

    If you need further assistance please let us know.
    Best regards,
    Victoria

  • Author
    Posts
Viewing 11 posts - 1 through 11 (of 11 total)
  • You must be logged in to reply to this topic.