Prevent SPAM on Email Buttons

Hi,

Thank you for the update.

@Guenni007: What do you mean by “3times settings for ‘@’”? You are correct. The modification above is only applicable for manually inserted links. We could also add this function to check if the link is an email address.

// https://developer.wordpress.org/reference/functions/is_email/

We have forwarded the thread to our channel for further consideration. In case you prefer not to implement or test the suggestion above, please explore the possibility of using a plugin.

Best regards,
Ismael

Hi,

we had 3 times that check.

You need to replace the condition inside the get_url function, around line 442 as previously mentioned. However, I didn’t notice that I was using an older version of the theme for testing. In the latest version, the condition is located around line 468.

because i do not see any difference in the DOM when applying it without.

I read that Chrome automatically decodes HTML entities, so you may not see the difference, but I’m not sure if this information is accurate. Yes, adding the second parameter helps.

Thanks for helping.

Best regards,
Ismael

Hi,

For buttons I have to change the code in enfold/config-templatebuilder/avia-template-builder/php/class-generic-helper.php and I have to do it after every Enfold update again, correct?

We’re considering adding this modification in the next patch. Please keep the changes for now.

Best regards,
Ismael

Hi,

It will be implemented for every element with the Link Settings.

Best regards,
Ismael

Hi,

You also find an example here:

https://github.com/KriesiMedia/enfold-library/blob/master/actions%20and%20filters/Security/E-Mails/avf_obfuscate_email_link.php

Best regards,
Günter

Hi,

For what is this hex encoding?

It’s the value used in the rand function inside the antispambot function.

// Line 2911: https://core.trac.wordpress.org/browser/tags/6.3/src/wp-includes/formatting.php#L2911
// Line 2914: https://core.trac.wordpress.org/browser/tags/6.3/src/wp-includes/formatting.php#L2914

This is the manual for the rand function.

// // https://www.php.net/manual/en/function.rand.php

The returned value (0 to 2) of the rand function determines the execution of these conditions.

if ( 0 == $j ) {
	                        $email_no_spam_address .= '&#' . ord( $email_address[ $i ] ) . ';';
	                } elseif ( 1 == $j ) {
	                        $email_no_spam_address .= $email_address[ $i ];
	                } elseif ( 2 == $j ) {
	                        $email_no_spam_address .= '%' . zeroise( dechex( ord( $email_address[ $i ] ) ), 2 );
	                }

If you want to check the functions that are executed inside these conditions, please see the links below.

// https://www.php.net/manual/en/function.ord.php
// https://www.php.net/manual/en/function.dechex.php
// https://developer.wordpress.org/reference/functions/zeroise/

Best regards,
Ismael

Hi,

We recommend setting it to 1, as this will actually obscure the email address. Setting it to 0 will only convert each character to its HTML entity code, which most browsers automatically decode back to the actual symbols or letters.

hex_encoding: 1

<a href="mailto:%74%65%73%74%40te%73t%2e%63%6fm">Click me</span></a>

hex_encoding: 0

<a href="mailto: (Email address hidden if logged out) "></a>

Best regards,
Ismael

Hi,
Glad Ismael could help, please let us know if you need further help or if we should close this thread.

Best regards,
Mike

Hi,
Did you create this shortcode yourself, I don’t see a reference to this in the solution from Günter above
When I read the Github avf_obfuscate_email_link filter it is intended for buttons with email links, and when I test it seems to work correctly:


This is the filter that I added to my child theme:

function custom_avf_obfuscate_email_link_hex_encoding( $hex_encoding, $e_mail )
{
	$hex_encoding = 1;

	return $hex_encoding;
}
add_filter( 'avf_obfuscate_email_link_hex_encoding', 'custom_avf_obfuscate_email_link_hex_encoding', 10, 2 );

function custom_avf_obfuscate_email_link( $obfuscate, $e_mail )
{
	$obfuscate = true;

	return $obfuscate;
}
add_filter( 'avf_obfuscate_email_link', 'custom_avf_obfuscate_email_link', 10, 2 );

Try using the filter instead of your shortcode.

Best regards,
Mike

Hi,
Thanks for the feedback, in buttons the email address is automatically recognized so the “mailto:” is not needed, but the question mark for adding a subject line & email body text breaks this function. I have submited this issue to the Dev Team for their review. I also noted that you want this to work for email addresses in other fields.
We will repliy back when a solution is found, thank you for your patience.

Best regards,
Mike