Viewing 17 posts - 1 through 17 (of 17 total)
  • Author
    Posts
  • #288918

    hello
    My test page: http://www.wp-master.org/sandbox-new-lightbox-plugin/
    There is 2 images, one is an Image Element and the other is an simple image inside a text block
    The first is set to use then new lightbox
    The second act as a standard WordPress image linked to his fullsize version (so it trigger tje new lightbox version)

    #1 – try to click on the two images and: why the lightboxed images sizes are not the same?
    #2 – Both of images have title, but why thoss titles are not displayed in the lightbox ?

    Thanks

    #289594

    Hi pako69!

    1) Because you link to the thumbnail version of the image. The image link points to http://www.wp-master.org/wp-content/uploads/2014/07/visuels_flous_4-1030×643.jpg and not http://www.wp-master.org/wp-content/uploads/2014/07/visuels_flous_4.jpg
    Make sure the link points to the original image.

    2) Yes, I think this is a bug. To fix it open up enfold/js/avia.js and replace:

    
    				image: {
    				    titleSrc: function(item){
    						// return item.el.find('img').attr('title');
    						return item.el.attr('title');
    					}
    				},
    

    with

    
    				image: {
    				    titleSrc: function(item){
    				    	var title = item.el.attr('title');
    				    	if(! title) title = item.el.find('img').attr('title');
    						return title;
    					}
    				},
    

    I’ll ask Kriesi to fix this with the next update.

    Best regards,
    Peter

    #289647

    1/ No… I do not link to the thumbnail version of the image… I choose the full size version:

    It’s Enfold that do that code:

    <a class="avia_image lightbox-added" href="http://www.wp-master.org/wp-content/uploads/2014/07/visuels_flous_3-1030x643.jpg"
    

    2/ Well i’ll wait for an update that should comme soon, isn’t it ?
    Devin, just said:
    I’ll go ahead and close this one since any fix will be pushed out on ThemeForest.

    #289679

    Sorry to jump in on this post – I had a similar issue on another thread and was directed here for the solution.

    This fix sort of works. If I fill in the “Image Title Attribute” under the “Advanced Options” section of an image, the text shows up as a caption underneath the image. This is good. Thank you!

    By “sort of works” I mean, if there is no “image title attribute” on any other images in the post, then it shows the text from the image that has that field filled in.

    EXAMPLE: if I have a picture in a post of a cat with the “image title attribute” of ‘cat’, it shows as a caption in the lightbox. As it should be.
    If I have a picture of a dog, a pig and a cow after the cat picture, the “caption” in the lightbox says “cat”.

    The fix also does not apply to the featured image caption, which is included in the post’s lightbox gallery. The featured image shows the title of the article as the caption. I want it to show the caption of the image. Then I won’t have to duplicate the featured image in the article. Yes…I can tick the “Don’t display image on single post” under the featured image and then add it again to the post, but I don’t think that’s an efficient use of resources and requires the pic to load again. Many other issues with this as well.

    #289834

    @pako69 try linking the full image in the Image Element: http://screencast.com/t/Pda7r6vqW0


    @dubyajay
    , i tried reproducing that (after applying Peter’s fix) on my install with no success, can you paste a link to a page where this happens?

    Regards,
    Josue

    #289874
    This reply has been marked as private.
    #289903

    @Josue
    Sorry but I do not want to use this, event it if works…, my authors are not webmasters, the just want an image that is displayed with the size they have choosen… It’s an Enfold issue that, in my opinion, have to be corrected.

    And, as said @dubyajay, ” The featured image shows the title of the article as the caption.” please correct this too.
    It’s not usefull to have an image wichh display the post title.
    Those images may contains important informations that we want to be displayed to visitors.

    I will not upgrade to this 2.9 version and do not want to apply any JS patch, I prefer to wait that all those little bugs to be solved :)

    Thanks a lot.

    #289912

    Hey @dubyajay!

    I could note it. Try changing Peter’s fix to this:

    titleSrc: function(item){
    	var title = item.el.attr('title');
    	if(!title) title = item.el.find('img').attr('title');
    	if(typeof title == "undefined") return "";
    	return title;
    }

    Best regards,
    Josue

    #292095

    Hello
    No news about an Enfold update to correct those image title issues withtout any JS fix and to correct: https://kriesi.at/support/topic/new-lightbox-plugin-questions/#post-289647

    Thank you

    #292166

    Hi,

    It is safe to apply the fix provided here, this change is already merged with the theme source and will be included in the next update.

    Best regards,
    Josue

    #292390

    Hello @Josue
    Ok i’ll do that, but it will only fix the issue with the image title but what about: https://kriesi.at/support/topic/new-lightbox-plugin-questions/#post-289647 ?
    Thanks

    #292772

    Hi!

    Which image is showing incorrect and what was the setting for that image? I’m just not quite clear on what exactly isn’t working or is expected within the example page.

    Best regards,
    Devin

    #293443

    @devin
    Excuse me if I do not make an answer now because I just ugrade to last enfold version, go to a page with images, click on an image, the new lightbox show up but with no title below?
    Please go to: http://www.domodeco.fr/interieur/cuisine/composez-univers-cuisines-creations.html
    The first one (the feature image show the post title, ok I know why) but the two others do not show any title. Both have Title,Alt and description tags…

    #293446

    ah okey… this:

    titleSrc: function(item){
    	var title = item.el.attr('title');
    	if(!title) title = item.el.find('img').attr('title');
    	if(typeof title == "undefined") return "";
    	return title;
    }

    also apply to images within the post?
    So, how to have the feature image title to be displayed in the lightbox ? because it takes the post title

    thank you

    #293447

    It seems that for the featured image Enfold add the post title to the A tag, but Enfold has removed the Title tag of the image:

    <a class="lightbox-added" href="http://www.domodeco.fr/wp-content/uploads/2014/05/haecker-cuisine-1200x655.jpg" title="Composez votre univers avec Cuisines & Créations">
    <img src="http://www.domodeco.fr/wp-content/uploads/2014/05/haecker-cuisine-845x321.jpg" class="attachment-entry_with_sidebar wp-post-image" alt="Composition Häcker - Cuisines & Créations, concepteur de cuisines Häcker (Lyon 3ème)" height="321" width="845"
    
    #293551
    This reply has been marked as private.
    #293934

    Hi!

    The lightbox will only use the “large” thumbnail size by default. I’ll ask Kriesi to add a filter with the next update which enables the user to change the thumbnail size. For now you’ve two options:

    1) Open up wp-content/themes/enfold/config-templatebuilder/avia-template-builder/php/generic-helper.class.php and replace:

    
    $link = wp_get_attachment_image_src($post_id, 'large');
    

    with

    
    $link = wp_get_attachment_image_src($post_id, 'full');
    

    or

    2) Use the “Manually” link option and paste the image url into the url field.

    
    [av_image src='http://www.wp-master.org/wp-content/uploads/2014/07/visuels_flous_8.jpg' attachment='3255' attachment_size='full' align='center' animation='no-animation' link='manually,http://www.wp-master.org/wp-content/uploads/2014/07/visuels_flous_8.jpg' target='' styling='' caption='' font_size='' appearance=''][/av_image]
    

    Best regards,
    Peter

Viewing 17 posts - 1 through 17 (of 17 total)
  • You must be logged in to reply to this topic.