-
Posts
-
Hey guys,
Am I missing something, or is the lightbox not creating srcset? All other elements are perfectly, but on multiple sites I’ve tested, the lightbox (eg: click on an image and open it up in a lightbox) doesn’t appear to have srcset enabled.
For an example see the links below, but its the same on every install I’ve tested.
Can you please advise?
Thank you.
Hey THP,
Thanks for contacting us!
No, lightbox is not creating srcset. I will check with our devs regarding that. If you would like to display full size images in lightbox, please add following code to bottom of functions.php file of your child theme
function change_lightbox_size() { return "full"; } add_filter('avf_avia_builder_helper_lightbox_size','change_lightbox_size', 10);Best regards,
YigitHey Yigit,
Thanks for the reply and confirming the lightbox isn’t creating srcset.
No I don’t want to display full size images, but it would be a nice improvement to have srcset enabled in the lightbox as well so that smaller sizes can be loaded as needed on mobile devices.
Thanks
Hey,
Thanks for clarification. I have shared this thread with our devs.
We will update you here :)Best regards,
YigitHi,
You are welcome!
Let us know if you have any other questions or issues and enjoy the rest of your day!Best regards,
YigitHi Yigit,
Another issue with the lightbox I wanted to raise, as discussed here: https://wordpress.org/support/topic/issue-with-lightbox-3/#post-14174307 ( thought it was Litespeed related, but seems it’s not).
You can’t test it live using those links at the moment, as we have the CDN turned off so its not broken.
But if we try and serve the images to the lightbox via the Google CDN (which changes the URL structure from /localsite/xxxxx to /cdnname/xxxxx then the lightbox fails to work properly – current page URL is replaced by the images actual URL.
In short, it seems the lightbox doesn’t like working with ‘external’ images (even if the entire site is run via a CDN), as mentioned by Litespeed support.
Can you please look into this fix as well?
One other related srcset request – can it also be implemented for the site’s logo please?
I see in the change log for the upcoming release you are already working on some of these – thank you so much! This is why I love using Enfold and keep buying more and more licenses – excellent support and you listen to our requests (also, I had to use Elementor the other day to fix a new clients site – THE WORST!! Please keep working on the ALB, it’s SO much better to use than Elementor!)
Hi,
Sorry for the late reply!
I checked with our devs regarding srcset in logo as well but we have decided to not implement it, at least for now as logo sizes are already small.
Is there a way we could see CDN issue? Also, is it specific to Google CDN? There are some users using CDN on Enfold and I do not remember receiving such report.
Best regards,
YigitHey Yigit,
Really appreciate the update.
Just on the point of the logo & srcset, I’m not sure of the reasoning that led you to not implement it, but one thing to consider is without srcset currently we need to load a logo double the normal size for retina screens. But for non-retina screens it’s loading a much bigger image than needed. So even though the logo files are admittedly relatively small, not having srcset prevents plugins that look for srcset in the code (such as a retina plugin) from being able to output a retina file. So we are forced to serve a larger file than necessary for all users. Just a thought.
As for the CDN, yes next week we will have a staging site ready for that particular client and we can turn on the CDN and provide you with a URL to view the problem. I’ll let you know when it’s live.
Thanks again.
Hey,
We will keep this thread open for CDN issue.
We have reconsidered srcset support for logo after your message and decided to implement it as well :)
Best regards,
YigitHey that’s awesome thanks Yigit for reconsidering that.
I will let you know ASAP once we have the CDN up on the staging site for you to check out that lightbox issue.
Thanks again.
Hey Yigit,
The CDN is enabled on the dev site for you to checkout that CDN issue with the lightbox images. See an example URL below, but any gallery element will produce the same issue.
If you need login details you can use the ones below as well. Please let me know as soon as you don’t need them anymore (they’re also provided in this thread: https://kriesi.at/support/topic/gallery-thumbnail-layout-issue-on-chromium-based-browsers/ for another issue).
Hi THP,
Thanks for the info!
I went to Enfold theme options > Performance > Disable Features > Self hosted videos and audio features (WP-Mediaelement scripts) and set it to “Always load media features (= WP default behaviour)” and that helped.
Please review your website :)
Best regards,
YigitHi Yigit,
Excellent, thank you! It seems to have resolved the issue as far as I can tell.
Really appreciate your help, never would have though of the connection to that setting.
Any ETA on when the next Enfold release with the new srcset features will be released roughly?
Thanks again, always appreciate your helpful support.
Hey!
You are welcome, always happy to help!
Unfortunately we do not have an ETA for the next release yet however srcset support is added for logo as well :)
Regards,
YigitHi Yigit,
I’m afraid the CDN & Lightbox issues still exist :(
I think the reason we didn’t see them was we were logged in. But I applied those same changes to the live site (not the dev site), flushed all caches, and then tried it not logged in and the problem persists. So i’ve had to turn the CDN off again on the live site.
Can you please take another look on the dev site when you’re not logged into WordPress and you should see the issue.
The logins remain for you to use.
Thanks
Hi,
Thank you for the update.
We cannot debug the issue properly because the scripts are minified. Can we deactivate the script minification and cache plugin temporarily while testing the lightbox?
Does lightbox work when Google Tag Manager is disabled?
Best regards,
IsmaelHi Ismael
Yes you can turn off the magnification settings.
However, I don’t think you can turn off the litespeed plugin entirely or the CDN won’t function properly – there’s a CDN tab in Litespeed that needs to be on (which it currently is) to work properly with the Google CDN and the Closte hosting setup. If you disable litespeed entirely you might get a false positive.
In my own testing from what I recall the issue remained with all other plugins deactivated other than Litespeed. So I think the answer is the issue remains when Google tracking was disabled, but please feel free to test that too.
Thank you for your help.
Hi,
Thank you for your patience.
The lightbox started to work properly after we deactivated the JS and CSS minify settings in the Litespeed > Page Optimization settings (see private field), cache and cdn is still enabled during the test. We do not know exactly which of the minify settings affected the lightbox though, but it is clear that file minification is causing the issue. You may need to test the settings or use a completely different minification plugin.
Best regards,
IsmaelHi Ismael,
Thank you for your time on this.
I just checked the dev site and when logged in, yes it’s working. But when logged out, it is not. I cleared all caches, invalidation the CDN cache, and the problem persists when logged out. ( I haven’t changed any of the settings you disabled in the Litespeed plugin)
When logged out all files are loaded unminified and uncombined as I can see in the Chrome network panel. So I don’t think it is related to the CSS and JS settings directly, as the issue persists even with these settings disabled.
Can you please test it logged out and see?
Thanks again, I appreciate your help working through this.
Hi,
Thank you for following up.
The lightbox still works even when we are logged out, or when checking it on incognito mode. You might be looking on a cached version of the page with the scripts still minified or compressed. Please make sure to do a hard refresh or go on incognito mode, or better yet, try to check the page using another computer.
Best regards,
IsmaelHi guys,
Thank you again for your time on this.
I confirmed it still wasn’t working (not sure why it seemed to be for you) on multiple devices in different countries even.
But my developer discovered the root cause – the Analytics plugin CAOS has a setting “Capture outbound links?” which was enabled. There is a line in the code for this “window.location.href = link;” this was changing the URL of the browser.
Just though I’d report the fix here in case anyone has a similar issue in the future.
This can be closed, thank you.
P.S. Looking forward to the next release with the srcset updates! Any ETA yet?
- The topic ‘Lightbox not using srcset?’ is closed to new replies.