-
Posts
-
Hi,
wie use the latest Enfold with WP 5.3. We put a slideshow on the frontpage using the advanced layout builder. One slide was missing. Troubleshooting took me quite some time. My customer put a button on the slide and used “>>>” as the label. I reckon, this input wasn’t sanitized correctly and caused an error. The slide was completely missing in the source code. Even changing the label did not do the trick. I created a new slide, same image, same caption, same options but a different label: Voilà, everything works like a charm. Could you look into it, please! “>>>” might not be the best label in the world. However, it should not break the function.
MikeHi Mike,
Thanks for contacting us and for reporting the issue. I was able to reproduce the issue and reported it to our devs :)
Regards,
YigitHey,
Thank you! :)
I am closing this thread. If you have any questions or issues, please feel free start a new one :)
Cheers!
YigitHi,
I just heard from our devs. This is a known issue apparently however since it is very rare and has potential to break other stuff, @guenter created this plugin – https://github.com/KriesiMedia/enfold-library/blob/master/integration%20plugins/Enfold/Special%20Character%20Translation/avia-special-characters_1_0_0.zip. We would recommend you to use the plugin if your client needs to have special characters in titles :)
Best regards,
YigitThanks for the update. While I personally would never use “>>>” in a title, I wouldn’t call it a special character. However, the mor important question is: What is considered a special character by the devs? I would rather not use a plugin for such a special task. We probably don’t need it. But it would be better just to know which characters might cause trouble.
Thanks!Hi DFME,
The “>” is the special character because it is used in the html to close the tag.
Here is the answer to your other question:
https://www.computerhope.com/jargon/s/specchar.htmBest regards,
VictoriaI don’t quite get the idea. Why don’t you sanitize the input fields? I know that “>” and “<” are used in html tags. This is exactly why this issue should be addressed by the dev team, since most users are not aware of this problem. These symbols are relatively often used and are not considered special characters. Let alone characters that could break the slider. It’s okay that theses characters must not be used. But it’s not ok to not give any kind of hint or info. It took me some 15 minutes to figure out what’s going on being a quite experienced pro. If you can’t find a proper solution, you could at least add a warning like “Don’t use special characters!”. Having said this, a proper validation seems to me appropriate for such a powerful theme like the Enfold.
Best, MikeHi!
The problem is not the frontend output but is already caused in backend when saving the post. When reading and writing to textareas with javascript (what we need to do when saving ALB elements) browsers translate the special characters and this breaks everything. The options of the ALB elements cannot be read any longer correctly. Sometimes this even breaks the complete backend.
We had already tried to fix it but it has a huge impact on the whole ALB implementation and the risk to break other things is too big.
As not many users need special characters in ALB options we decided to offer the plugin mentioned above for those who really need it.
We will check if we find an easy way to add a warning – I open an issue in our dev repo.
Cheers!
GünterHi Günter,
ok, I get it. That’s the price you have to pay when using such powerfull themes. :-)) I think, a short note above the input fields would be perfectly fine. Just give the user a hint where to beginn the troubleshooting.Thanks, Mike
- You must be logged in to reply to this topic.