"" in image title/description of featured image on single post

Hey, sorry to be blunt, but that is not a solution (and of course that’s what I have done temporarily until you fix it), that’s circumventing the actual problem – there’s a problem in your code, and you need to fix it.

• This reply was modified 7 years, 10 months ago by emilbroll.

Hey Rikard,

I’m sorry, it’s evident that I haven’t been able to explain the issue properly.

The issue is as follows:

On single blog posts, the featured image is displayed above the title and content of the post. If you click on the featured image, a lightbox/popup pops up, displaying the full image with an image caption being displayed. This caption is usually the title of the blog post, but if you have set the alt text/description/title/caption of the image in the media library of wordpress, that content is used instead.

So: this has nothing to do with the title-attribute of the image HTML element, it is an issue of how the alt/desc/title of the image is processed before being displayed in the lightbox. I haven’t studied the code responsible for this lightbox, but it pretty obviously isn’t dealing with ” the right way, that’s what I meant by there being something wrong with your code – ALL characters can be displayed on the web, telling users to “not use this or that character” is avoiding the real problem – that the code isn’t good enough.

Here’s where the details are inserted:
https://cl.ly/3a4539222b3d

The error in your code is most likely somewhere in the /enfold/js/avia.js-file, on the lines 941-950:

image: {
    titleSrc: function(item){
        var title = item.el.attr('title');
        if(!title) title = item.el.find('img').attr('title');
        if(!title) title = item.el.parent().next('.wp-caption-text').html();
        if(typeof title == "undefined") return "";
        return title;
    }
},

When you’re doing .html(), you’re getting the raw html string – you should escape the input so it’s safe to use in a title-attribute, where it will then later be used in the lightbox – setting the title-attribute to a raw HTML-string is very bad, for obvious reasons.
What happens is, your code essentially messes up the HTML of the page, as shown in the screenshot, in cases where " are in the image description/title.

https://cl.ly/2I1Y3P0G2w3w
https://cl.ly/0y010M18032s

• This reply was modified 7 years, 10 months ago by emilbroll.