Tagged: Images
-
AuthorPosts
-
January 7, 2022 at 10:43 pm #1334727
Hey Gunter,
Sorry, the other thread got closed or would I have continued there ( https://kriesi.at/support/topic/missing-scrset-in-alb-gallery/ ) but I have discovered 2 more ALB elements that produce image sizes problems with image proxy services like Imgix.
One is when an image element has the setting turned on to link to the lightbox. In that case, it doesn’t return the right image size for the image (not the lightbox image). If you turn off linking to the lightbox, then the image returns the correct size.
The second one is with the Team Member element. Actually, this element is missing the image selector dropdown under the Styling tab like most other elements have now (that’s just a side issue). But this element also returns the wrong value for image proxy services. It seems to be getting the image size using a whole other method to the other elements we’ve looked at.
Is it possible to add the filter that you added for the masonry elements for these (and any other elements you suspect might have the same issues) for us please?
If you have any questions please let me know.
Thanks so much,
Tim
P.s. The updated srcset that you did the for Gallery thumbnails on hover doesn’t seem to be mentioned in the upcoming changelog – it will be included in the next update though, right?
January 10, 2022 at 5:30 pm #1334973Hey Tim,
Thanks for reporting this.
There is really a bug with the lightbox and image element.
If I add the height and width attribute to the img element is that enough or do you still need a filter to manipulate the img html ?
Team Member takes the image size from the media library “Attachment Display Settings” selectbox for sizes.
But you are right, it is more user friendly similar to image element to change the size with a selectbox in the modal popup.
Will add this.And same to img element – is it enough to add height and width attribute to img html ?
Best regards,
GünterJanuary 10, 2022 at 11:39 pm #1334993Hey Gunter,
Thanks so much for looking into it.
So we think just adding in the image sizes should be enough, but unfortunately we won’t know for sure until we can test it and see if something else in the steps that are run messes up the image proxy. But hopefully just the image sizes will be enough, maybe we just start there?
Thanks again,
Tim
January 11, 2022 at 10:17 am #1335045Hi,
I will update the Image Element and Team Member and send you the latest dev version to check when ready.
Best regards,
GünterJanuary 11, 2022 at 3:22 pm #1335099Hi Gunter,
Sounds great, thanks so much.
Tim
January 11, 2022 at 3:57 pm #1335105January 13, 2022 at 4:09 pm #1335443Hi Gunter,
We briefly tested the dev version and it seems to have fixed those issues, thank you very much.
If you can think of any other element or feature that may be missing image sizes in a similar way that these ones were, please add them in also. If I spot any more I’ll be sure to let you know.
Thanks again,
Tim.
January 14, 2022 at 11:10 am #1335546Hi,
Thanks for the feedback – and glad it solves the problem.
I will keep an eye on this.Best regards,
GünterJanuary 14, 2022 at 10:30 pm #1335641Thanks a lot Gunter, have a great weekend.
Tim.
February 11, 2022 at 9:39 pm #1340212HI Gunter,
Hope you’re keeping well.
Just wanted to flag a small issue with the backend previews of images missing sizes in the html.
For instance, if I add an easy slider, then go into the slide and add/edit the image, there’s normally a square 80×80 preview of the image selected under the Change Image button.
But this is missing entirely when using an image proxy service, as from what I can see there are no sizes or srcset present in the html and so the image proxy service can’t return an image. This is the span that just returns the image src:
`<span class=”avia-builder-prev-img”></span>
This is the same for any element that provides the small preview image in the backend of the ALB.
Could that be updated to include sizes if possible please?
Thanks a lot
Tim
- This reply was modified 2 years, 9 months ago by THP Studio.
February 14, 2022 at 5:40 pm #1340552Hi Tim,
I had a look into it – but it turns out to be more complicate as there are many elements involved and core backend functions.
I add it to our dev repo – but no ETA I can promise at the moment (we are starting to work on 5.0 with some nice new frontend features and Kriesi wants to set priority on this).Best regards,
GünterFebruary 14, 2022 at 5:48 pm #1340555Hi Gunter,
Ok, v5 sounds really interesting! Thanks for adding it to the repo, it’s not a deal breaker but would be nice to have fixed at some point when you can manage.
Thanks for all your work
Tim.
-
AuthorPosts
- The topic ‘Image Sizes & Image Proxy Services’ is closed to new replies.