Tagged: , , ,

Viewing 7 posts - 1 through 7 (of 7 total)
  • Author
    Posts
  • February 1, 2019 at 12:35 pm #1061499
    Manny Rodrigues

    Hello.

    The default setting on the WordPress frontend admin bar “edit” link is set to open in the same window (_self). This default setting is great for accessibility helping those with screen readers and the like. Again, opening the link in the same window is and was the standard.

    This standard appears to have changed after one of the most recent updates to the Enfold theme. Now the frontend admin bar “edit” link is set to target=”_blank” which opens a new tab/page.

    May I request that this be reverted or that some sort of a hook be implemented. Those who want the edit link to open in a new tab can easily do so any number of ways. However, if the link is defaulted to “_blank” there is no way of having it open in the same window confusing those with screen readers and annoying those who don’t want a new tab opened.

    Thank you for your time and any assistance you may be able to provide me with.

    February 3, 2019 at 7:33 pm #1062362
    Basilis

    Hey Manny,

    You should ask that on the WordPress.org forums, they are responsible for such questions as it is not related for our theme.

    Best regards,
    Basilis

    February 3, 2019 at 11:18 pm #1062419
    Manny Rodrigues

    Thanks for your response. However, you are incorrect (I say that respectfully of course).

    This is completely and only enfold theme related. The default WordPress action is to open in _SELF.

    The recent enfold upgrade changed this to _BLANK.

    Let me know if there is a hook to disable the enfold theme alteration of the frontend edit link.

    Thank you.

    February 3, 2019 at 11:32 pm #1062420
    Manny Rodrigues

    The issue is within the class-avia-gutenberg.php file located under the config-gutenberg directory. Again, with the most recent update someone accidentally changed it to ‘blank’ changing the default function of the ‘edit’ link on the frontend of the website.

    See lines: 898 to 905 (line 902 is where blank meta is being called thus altering the default wordpress edit link action)

    $menu = array(
    ‘id’ => ‘edit’,
    ‘title’ => $title,
    ‘href’ => $edit_url,
    ‘meta’ => array( ‘target’ => ‘blank’ )
    );

    $wp_admin_bar->add_menu( $menu );

    February 5, 2019 at 8:03 pm #1063281
    Victoria

    Hi Manny Rodrigues,

    You can comment out the line

    
‘meta’	=> array( ‘target’ => ‘blank’ )

    and see if it chagnes it.

    Best regards,
    Victoria

    February 5, 2019 at 8:19 pm #1063290
    Manny Rodrigues

    Thank you, I know it works because I had removed the array values.

    I have also submitted a pull request on github. Hope your team implements this change.

    February 7, 2019 at 10:13 pm #1064315
    Victoria

    Hi Manny Rodrigues,

    Thank you for your input. Our devs will have a look at it.

    Best regards,
    Victoria

  • Author
    Posts
Viewing 7 posts - 1 through 7 (of 7 total)
  • You must be logged in to reply to this topic.