
-
AuthorPosts
-
July 11, 2019 at 4:25 pm #1117841
Hi Ismael! As requested i have started new tread for issue with product info container size.
This given css does not reduce this empty space :
#top .inner_product_header {
min-height: 60px;
}Initial tread for this issue.
July 12, 2019 at 12:30 pm #1118051Hey axels1983,
Thank you for the update.
It works properly on our end. Did you toggle the Performance > File Compression settings after adding the code?
Best regards,
IsmaelJuly 12, 2019 at 4:45 pm #1118129HI Ismael! No i haven’t touched performance settings. I can see some changes to one product line but it does not affect space i was referring to pls. see link in private. As you can see after using your css bid button draws closer to next row of product pictures and this still leaves massive gap. Also first row is still the same as use to be bid button in middle of this space. Bid/auction button suppose to be under product picture not above.
July 14, 2019 at 9:42 pm #1118568Hi,
Please post us your login credentials (in the “private data” field), so we can take a look at your backend.
- Install and activate ” Temporary Login Without Password “.
- Go to ” Users > Temporary Logins ” on the left-side menu.
- Click ” Create New “.
- Add the email address for the account ( you can use (Email address hidden if logged out) ), as well as the ” Role ” making that the highest possible and the expiry about four days
( do be sure that we have enough time to debug ). - Click ” Submit “.
- You’ll now have a temporary account. Please provide us here in the private section the URL, so we can login and help you out.
When your issue is fixed, you can always remove the plugin!
If you prefer to not use the plugin, you can manually create an admin user and post the login credentials in the “private data” field.Best regards,
BasilisJuly 15, 2019 at 8:42 am #1118701Hi, I have added login credentials.
July 16, 2019 at 12:43 am #1118997Hi,
Thank you for the update.
There are snippets in your Quick CSS field that were not supposed to be added there. We removed those and moved the css modification in the child theme’s style.css file. Please remove the browser cache before checking the page.
Best regards,
IsmaelJuly 16, 2019 at 8:20 am #1119076Hi Ismael ! Im afraid this way we have lost what Mike has done for me pls. see this link.
In few words there suppose to be time left auction timer for products in my account setting and also in individual product page view (timer must be removed from rest of pages).
July 17, 2019 at 3:34 am #1119342Hi,
I didn’t remove those, just the PHP snippet that’s in the Quick CSS field. You can’t add PHP snippet in the Quick CSS field. It won’t work and it will break the style.
Best regards,
IsmaelJuly 19, 2019 at 9:44 am #1120112Hi Ismael! I understand that you did not remove Mikes code in child theme functions.php (post #1116502) but somehow this issue you sorted with product container size affected auction timer visibility. I just did full cpanel backup to day prior you added code and removed snippets that not suppose to be there ( see above post #1118997) and timer works as should for my account and single product pages pls see links in private so only after changes were made on 16 July auction timer disappeared.
Maybe Mike can have a look at this as he did some great job in sorting this timer visibility by creating code. I have now contacted plugin Author and he provided some personal comments regarding this Mikes code that could maybe help resolve this issue.July 20, 2019 at 9:19 pm #1120483Hi,
Sorry for the late reply, I don’t see the topic when another mod replies.
But now I’m a little confused, please state your request again.
Also, what are the personal comments regarding my code?Best regards,
MikeJuly 20, 2019 at 9:44 pm #1120488Hi Mike! I assumed that you are on holiday since other mods took over our topic. That code you created to have auction timer for my account page and single product page was working great and only issue i had was empty space for shop page/category page where timer was removed (see link in private). We used this forced timer code for all pages and then you adjusted code to show timer only for my my account page (watchlist/my auctions) https://kriesi.at/support/topic/how-to-increase-thumbnail-size-image-for-watchlist/page/2/
Ismael did manage to remove that space but this auction timer also disappeared so i did full backup to date prior changes were made and left as it was. I also contacted Plugin author and he advised : Regarding your custom JS code much better approach would be to add couple if statements in https://pastebin.com/BWiswYec rather than removing html block with JS. If statement must be inside function, or like this:
if ( is_page(’29’) ) {
add_action( ‘woocommerce_after_shop_loop_item_title’,’wpgenie_show_counter_in_loop’,50 );
function wpgenie_show_counter_in_loop() {
global $product;$time = ”;
if ( ! isset( $product ) ) {
return;
}
if ( ‘auction’ !== $product->get_type() ) {
return;
}$timetext = esc_html__( ‘Time left’, ‘wc_simple_auctions’ );
if ( ! $product->is_started() ) {
$timetext = esc_html__( ‘Starting in’, ‘wc_simple_auctions’ );
$counter_time = $product->get_seconds_to_auction();
} else {
$counter_time = $product->get_seconds_remaining();
}
$future_class = ( $product->is_closed() === false ) && ( $product->is_started() === false ) ? ‘future’ : ”;$time = ‘<span class=”time-left “>’ . $timetext . ‘</span>
<div class=”auction-time-countdown ‘ . $future_class . ‘”
data-time=”‘ . esc_attr( $counter_time ) . ‘”
data-auctionid=”‘ . intval( $product->get_id() ) . ‘” data-format=”‘ . esc_attr( get_option( ‘simple_auctions_countdown_format’ ) ) . ‘”></div>’;if ( $product->is_closed() ) {
$time = ‘<span class=”has-finished”>’ . __( ‘Auction finished’, ‘wc_simple_auctions’ ) . ‘</span>’;
}echo $time;
}
}July 21, 2019 at 3:54 am #1120551July 21, 2019 at 9:17 am #1120576Hi Mike! Yes of course i tried this above code but for my account timer did not work. There might be some codes added in quick css that could affect this (Ismael mentioned that) but im not sure which one needs to be removed and not loose other changes in code.
p.s
Now i did backup prior any changes where made and before other mods took over our topic.July 21, 2019 at 2:04 pm #1120633Hi,
I took a look at your Quick CSS and found this function that should not be there, so I removed it:function avia_woocommerce_auction_hooks() { add_action('woocommerce_before_shop_loop','woocommerce_auctions_ordering', 20); remove_action('woocommerce_before_shop_loop','avia_woocommerce_frontend_search_params', 20); } add_action( 'init', 'avia_woocommerce_auction_hooks');
Then I checked the links where the counter shows or not from the other post, please see in Private Content area.
So these seem to be working correctly now, please check.Best regards,
MikeJuly 21, 2019 at 4:16 pm #1120651Hi Mike! Yes timer works but now we are back to this issue with empty space between bid now button and product description pls see in private marked with red X. This is space where forced timer suppose to be but as we hid it for shop/category pages now this space stays empty and looks odd.
July 24, 2019 at 5:51 pm #1121657Hi,
I have adjusted the functions.php code to this:function custom_not_script(){ ?> <script> (function ($) { $(window).load(function() { if ($("body").hasClass("woocommerce-account") || $("body").hasClass("single-product")) { $('.auction-time-countdown').css({'opacity':'1'}); $('.time-left').css({'opacity':'1'}); } else { $('.auction-time-countdown').css({'display':'none'}); $('.time-left').css({'display':'none'}); } }); })(jQuery); </script> <?php } add_action('wp_footer', 'custom_not_script');
by using the “display:none” I have removed the dead space.
Please clear your browser cache and check.Best regards,
MikeJuly 24, 2019 at 9:17 pm #1121740Perfect ! Thank you very much Mike for such a great support.
July 24, 2019 at 11:03 pm #1121775Hi,
I’m glad this was resolved. If you need additional help, please let us know here in the forums.
Best regards,
Jordan Shannon -
AuthorPosts
- The topic ‘Height of the product info container.’ is closed to new replies.