exclude images from srcset responsive react.

Hi,

We could modify the class-responsive-images.php > prepare_single_image function a bit and add a condition which prevents the theme from adding the scrset attribute when an array contains the current attachment or image ID. We could also add a filter so that we could modify the array in the future.

Look for this code inside the function..

if( is_numeric( $attachment_id ) || 0 != $attachment_id )
				{
					$new_img = $this->add_attachment_id_to_img( $new_img, $attachment_id );
				}

.., and replace it with:

	if( (is_numeric( $attachment_id ) || 0 != $attachment_id) && !in_array($attachment_id, apply_filters("avf_srcset_exclude_images", array())) )
				{
					$new_img = $this->add_attachment_id_to_img( $new_img, $attachment_id );
				}

The filter can be used as follows.

add_filter("avf_srcset_exclude_images", function($exclude) {
	$exclude = array(123, 111, 141);
	return $exclude;
});

Best regards,
Ismael

Hi,

This is not going to be included in the next patch. We are just trying to provide a possible solution. You could also remove the make_image_responsive function from the enfold/config-templatebuilder/avia-shortcodes/av-helper-slideshow.php line 787.

$img_tag = "<img src='{$img[0]}' width='{$img[1]}' height='{$img[2]}' title='{$linktitle}' alt='{$linkalt}' {$markup_url} {$img_style} />";
						$img_tag = Av_Responsive_Images()->make_image_responsive( $img_tag, $slide->ID, $this->config['lazy_loading'] );

Maybe add a new element option or toggle in the enfold/config-templatebuilder/avia-template-builder/php/class-popup-templates.php where you can disable/enable srcset attribute or responsive images for the slider. Something like:

/**
		 * Responsive Images Option
		 * 
		 * @since 4.8.6.2
		 * @param array $element
		 * @return array
		 */
		protected function responsive_image_toggle( array $element )
		{
			$desc  = __( 'Enable responsive images or add srcset attribute to slider images.', 'avia_framework' ) . ' '; 

			$id = isset( $element['id'] ) && ! empty( $element['id'] ) ? $element['id'] : 'responsive_srcset';
			$std = isset( $element['std'] ) && in_array( $element['std'] , array( 'disabled', 'enabled' ) ) ? $element['std'] : 'enabled';
			$required = isset( $element['required'] ) && is_array( $element['required'] ) ? $element['required'] : array();
			$lockable = isset( $element['lockable'] ) ? $element['lockable'] : false;

			$c = array(
							array(
								'name'		=> __( 'Responsive Images', 'avia_framework' ),
								'desc'		=> $desc,
								'id'		=> $id,
								'type'		=> 'select',
								'std'		=> $std,
								'lockable'	=> $lockable,
								'required'	=> $required,
								'subtype'	=> array(
													__( 'Add srcset attribute', 'avia_framework' )	=> 'enabled',
													__( 'Remove srcset attribute', 'avia_framework' )		=> 'disabled'
												)
							)
				);

			if( isset( $element['no_toggle'] ) && true === $element['no_toggle'] )
			{
				$template = $c;
			}
			else
			{
				$template = array(
								array(	
									'type'			=> 'template',
									'template_id'	=> 'toggle',
									'title'			=> __( 'Performance', 'avia_framework' ),
									'content'		=> $c 
								),
					);
			}

			return $template;
		}

You can then add a condition like so:

$img_tag = "<img src='{$img[0]}' width='{$img[1]}' height='{$img[2]}' title='{$linktitle}' alt='{$linkalt}' {$markup_url} {$img_style} />";
if($responsive_srcset == "enabled") {
    $img_tag = Av_Responsive_Images()->make_image_responsive( $img_tag, $slide->ID, $this->config['lazy_loading'] );
}

Best regards,
Ismael

Hi,

That could also work. We have to modify the config-templatebuilder\avia-shortcodes\slideshow_fullsize\slideshow_fullsize.php file, around line 1073, add this code below to pass the class names to the avia_slideshow object.

$slider->set_extra_class( $meta["el_class"] );

In the config-templatebuilder\avia-shortcodes\av-helper-slideshow.php, around line 789, we could check if the class name “nosrcset” exists or not.

	if(false == strpos($this->config['class'], "nosrcset")) {
							$img_tag = Av_Responsive_Images()->make_image_responsive( $img_tag, $slide->ID, $this->config['lazy_loading'] );
						}

The srcset attribute should not be added whenever the “nosrcset” is used as a custom css class name for a Fullwidth Slider element.

Best regards,
Ismael

Hey!

Alright. Glad to know there is a better solution. Please feel free to open a new thread if you need anything else.

Have a nice day.

Regards,
Ismael