Error saving event – Events Calendar Pro + Event Tickets Pro

I have the same issue with a customer and investigate since 10 hours. It is an Enfold issue but it is not the Calendar Integration.

Issue isolated.

tl;dr
1. Open /enfold/config-templatebuilder/avia-template-builder/php/meta-box.class.php
2. Locate function handler_wp_insert_post_data near line 223
3. Locate the code block if( ‘revision’ == $data[‘post_type’] ) { return $data; } within function handler_wp_insert_post_data
4. Add the following code block after the code block located in #3:

/*
 * Temporary fix for Enfold triggering the non catchable error -1 
 * after executing the check_ajax_referer (wordpress core function)
 * if a tribe event has a ticket attached (woocommerce product).
 *
 * @see https://kriesi.at/support/topic/error-saving-event-events-calendar-pro-event-tickets-pro/
 *
 * @todo Kriesi needs to implement a permanent fix
 */
if( $_POST['post_type'] == 'tribe_events' && $postarr['post_type'] == 'product' ) {
	$product_id = $postarr['ID'];
	$ticket_product_ids = isset( $_POST['tribe-tickets']['list']) ? array_keys($_POST['tribe-tickets']['list']) : array();
	if( in_array( $product_id, $ticket_product_ids ) ) {
		return $data;
	}
}

5. Save the file. You tribe events with attached tickets will save again.

Short description

Enfold introduced the function handler_wp_insert_post_data() in version 4.2.1. The call to check_ajax_referer() from within returns -1

Detailed description

The function handler_wp_insert_post_data() introduced in Enfold version 4.2.1 cares about Advanced Layout Builder Metaboxes attached to posts/pages. Posts/pages without ALB metaboxes are ignored. By default the posttype tribe_events does not support Enfold metaboxes and gets ignored by handler_wp_insert_post_data(). The plugin Tribe Event Tickets Plus allows to add tickets to events using WooCommerce. The posttype product used by WooCommerce supports Enfold metaboxes by default and gets handled by handler_wp_insert_post_data(). This is where the issue stems from.

Saving an event with attached ticket will trigger the WordPress core filter wp_insert_post_data two times. The first call is for the event (tribe_events). The second call is for the ticket (product). The function handler_wp_insert_post_data() is hooked into the filter wp_insert_post_data and parses both save actions. The first call is ignored because the posttype tribe_events has no ALB metaboxes attached. The second call gets processed because the posttype product has ALB metaboxes attached. But because the save action has been initiated from an event (tribe_events) the nonce needed to pass the call to check_ajax_referer() is missing. Therefore the result of check_ajax_referer() is false and because check_ajax_referer() is set to die by default ($die = true) instead of returning the result WordPress dies and returns -1.

Solution

As a quick fix you can modify the function handler_wp_insert_post_data() in class MetaBoxBuilder as described above. What it does it to check the original posttype where the save action has been invoked from (tribe_events) and the posttype passed to handler_wp_insert_post_data(). If the original posttype is tribe_events and the posttype seen in $postarr is product a second check is performed. It will test whether the ID of the product matches any of the ticket (product) IDs attached to the event. If this is true the processing of function handler_wp_insert_post_data() is aborted and the original data are returned.

Another solution might be to add ALB metaboxes to the posttype tribe_events using the filter avf_builder_boxes. However I did not test it because this won’t solve the root cause of the issue.

@kriesi

A permanent fix must work for tribe events with attached tickets regardless whether ALB metaboxes are attached or not. One way would be to introduce a new filter before calling check_ajax_referer() and to execute check_ajax_referer() conditionally. This would allow to move the logic of my fix into the config.php files of your plugin integrations.

I don’t see an entry in the changelog regarding this issue

This would be absolutely inappropriate. It neither describes the issue nor does it contain any props to the person who found the core reason and provided a solution. (me ;-))