-
AuthorPosts
-
May 20, 2018 at 4:26 pm #959458
Hi,
I’ve set up the Custom Error 404 Page. If i typ a wrong page it shows up. But if i typ in a wrong page with an extra child in child then it shows an unstyled blogpost..
Could you check this out please
May 20, 2018 at 11:17 pm #959529Anyone?
May 20, 2018 at 11:28 pm #959534Yup, it’s a bug, we are all running into it… (there are other threads on this). So far Enfold team has not posted a patch.
May 20, 2018 at 11:30 pm #959535Thanx! Appreciate it!
May 20, 2018 at 11:33 pm #959537Here’s an example of the error in action…
http://www.thomashenthorne.com/hello/enfold/test/
404 error page works for:
http://www.thomashenthorne.com/hello/
but once you add another path to the url it re-directs to the first blog page…. happening on every Enfold site I’ve tried that’s running the latest version.
May 20, 2018 at 11:35 pm #959538yes indeed! thanx! Same here!
May 22, 2018 at 5:51 am #960143Hi,
Thank you for using Enfold.
I can’t reproduce the issue on my installation so it’s probably related to a server configuration. Are there any custom directives in the .htaccess file? Or did you install a cache plugin?
Best regards,
IsmaelMay 22, 2018 at 6:12 am #960150When I de-activate Yoast, the bug goes away. De-activating Yoast is not an option, however, so devs need to figure out how Enfold and Yoast can get along better… :)
May 22, 2018 at 7:57 am #960170Hi,
Thanks for the info. We’ll forward it to the development team. :)
Best regards,
IsmaelMay 22, 2018 at 8:06 am #960173Hi,
UPDATE: If you have the time, please edit the functions-enfold.php file. Look for the “av_error404” function. Replace everything with this code.
/** * Error 404 - Custom Page * Hooks into the 404_template filter and display the defined 404 page * Does not work with <a href='http://bit.ly/kwpml' target='_blank' rel="nofollow">WPML</a> * @author tinabillinger * @since 4.3 */ if( ! function_exists( 'av_error404' ) ) { function av_error404($template) { // skip if <a href='http://bit.ly/kwpml' target='_blank' rel="nofollow">WPML</a> is active if( ! defined('ICL_SITEPRESS_VERSION') && ! defined('ICL_LANGUAGE_CODE')) { if (avia_get_option('error404_custom') == "error404_custom") { $error404_page = avia_get_option('error404_page'); $error404_url = get_permalink($error404_page ); if(defined('WPSEO_VERSION')) { if (wp_redirect($error404_url)) { exit(); } } global $wp_query; // check if error 404 page is defined if ($error404_page) { // hook into the query $wp_query = null; $wp_query = new WP_Query(); $wp_query->query( 'page_id=' . $error404_page ); $wp_query->the_post(); $template = get_page_template(); rewind_posts(); return $template; } } } return $template; } add_filter( '404_template', 'av_error404', 999 ); }
Let us know if it helps.
Best regards,
IsmaelMay 22, 2018 at 9:21 am #960200Hi Ismael,
Thanx for the update. Is the new functions-enfold.php file in todays update?May 22, 2018 at 4:19 pm #960399Ismael, yes that code DOES fix the 404 bug. I echo the question above… will this fix be in the GDPR update?
Thanks for fixing this so quickly!
Rob
May 23, 2018 at 8:37 am #960674This fix is NOT in the GDPR update (4.4)… please confirm this is going to be in the next update in 1-2 weeks? I am concerned this bug will result in Google Search Console “soft 404 errors” increasing.
Thanks
RobMay 23, 2018 at 10:29 am #960704I agree with Rob. Replacement in the functions-enfold.php file will take care of the bug but i am to concerned this bug will result in Google Search Console “soft 404 errors” increasing. Please a 4.4.1
May 27, 2018 at 10:32 pm #962892Guys come on… please reply on this topic…
May 30, 2018 at 10:41 am #964090Hi CONCEPTENCREATIE,
This code has not been included yet. It will be included in the next versions.
If you need further assistance please let us know.
Best regards,
VictoriaMay 30, 2018 at 3:10 pm #964302Hi Victoria,
Yeah! We kinda noticed that… “soft 404 errors” would be an issue. So another week for the update i guess?
May 31, 2018 at 7:17 am #964647Hi,
The modification is now included in the core but there’s no ETA for the patch yet, unfortunately. Please keep the modification for now.
Best regards,
IsmaelJune 5, 2018 at 2:39 pm #967244Hi Ismael,
I saw there is an update 4.4.1. but i am not able to find any info. Could you please let me know if the 404 is included?
June 7, 2018 at 9:51 pm #969795Hi,
My bad. There was another issue with the maintenance mode option and Yoast. The fix that is provided here is almost the same as that one so I thought I already reported this issue. Please keep the modifications for now. We’ll forward this again to the development team.
Best regards,
IsmaelJune 7, 2018 at 10:10 pm #969804Hi,
So i updated and have to do the modification again right… Quickfix isn’t it??
June 9, 2018 at 9:21 pm #970551Ismael can you guys put this into production asap? I don’t want to continue to patch Enfold for a bug that’s been around more than a month now. Seems like it would be easy to include in a mini-release and push it within a week?
June 10, 2018 at 9:42 pm #970882June 11, 2018 at 2:05 am #970911Hi!
Thanks for the update. @Gunter created new filters to take care of this particular issue but they’re not merged in the core yet. We’ll update you once the modifications are included in the theme. Sorry for the inconvenience.
Regards,
IsmaelJune 11, 2018 at 2:12 pm #971195Hi,
I installed the 4.4.1 update and switched to Custom 404 page – now that it works with WPML wordpress installations. Unfortunately, Enfold 404 return status 200 instead of 404! Please fix this with the next update.Thanks in advance,
KatrinJune 12, 2018 at 6:43 am #971549Hey!
@prudsys: Thanks for the info. I notified @Gunter about this. The wp_redirect function has a parameter called “status” so that may be used to set the header status to 404 when doing a custom 404 page redirect.// https://developer.wordpress.org/reference/functions/wp_redirect/
Regards,
IsmaelJuly 23, 2018 at 11:22 pm #988961The 404 page error is still in the production version of Enfold. When is this going to be fixed? It’s been months….
(as a reminder, to replicate go to https://www.thomashenthorne.com/dkdkd/dkdkdk/dkdkdk and instead of the custom 404 page you see a blog article).
Thanks
RobJuly 24, 2018 at 1:28 pm #989169Hi,
I’m not sure when the next patch will be released but the modification is already merged in the core. I will tag @gunter to the thread. Please wait for his response.
Best regards,
IsmaelJuly 25, 2018 at 4:47 pm #989790That would be great… I know it’s summer, guys, come but on, it’s just a little patch from months ago! Push it! :)
Best,
RobJuly 26, 2018 at 12:54 pm #990219Hi,
I refactored the way custom 404 and maintenance mode pages are handled. It should also be compatible with WPML and YOAST and the status codes should be 404 and 503.
If you want to test it – please update enfold\functions-enfold.php with
Do not forget to make a copy for fallback.
I will check with Kriesi when he plans the next update.
Best regards,
Günter -
AuthorPosts
- You must be logged in to reply to this topic.