-
AuthorPosts
-
July 29, 2023 at 2:00 pm #1414818
In the newest Enfold version 5.6.5 it comes to an erroneous output, if NO logo is deposited, then the following source code is output
the following source code is printed nonsense:
<span class=”logo bg-logo”>/” aria-label=”=”” wp-content=”” themes=”” enfold=”” images=”” layout=”” logo.png’=”” height=”100″ width=”300″ alt=”” title=”” style=”max-height: 88px;”>’ title=’/wp-content/themes/enfold/images/layout/logo.png” alt=”” title=”” style=”max-height: 88px;” width=”300″ height=”100″>’></span>In the source code I replaced the actual domain with <domaine>.
I was able to isolate the error in the file “function-set-avia-frontend.php” at the variable in line 827 => $aria and line 860 => $link_title, when not using a logo to the incorrect code comes, a quick fix from me in which I define the corresponding variables an empty has now helped for the time being, but is not the right solution ;)
July 30, 2023 at 6:34 pm #1414944Hey Jörg,
Thanks for reporting this I have submitted it to the Dev Team.Best regards,
MikeJuly 30, 2023 at 8:46 pm #1414972yes i can confirm that i have this too – a bit different:
___________________
you can use this snippet to avoid output that fallback image or the blog_name
function change_logo_on_empty_logo_input($logo){ if(empty(avia_get_option('logo'))){ $logo = ""; } return $logo; } add_filter('avf_logo_final_output','change_logo_on_empty_logo_input');
July 30, 2023 at 10:49 pm #1414974yes in the else statement of :
if( ! empty( $logo ) )
there will be no image so no alt nor title.
The aria label should stay :
i replaced those lines from 822 to closing else statement with:$aria = ''; $aria = 'aria-label="' . __( 'Fallback Logo', 'avia_framework' ) . '"'; /** * Return a complete modified aria-label="" attribute string * * @since 5.6.5 * @param string $aria * @return string */ $aria = apply_filters( 'avf_avia_logo_link_aria_label', $aria ); $logo = "<{$headline_type} class='logo bg-logo'><a href='{$link}' {$aria} >{$logo}{$sub}</a></{$headline_type}>"; }
see on pastebin the whole code.: https://pastebin.com/8BsvVC6T
but i guess that Günter will fix it soon – in a better way. than i can do.
July 30, 2023 at 11:01 pm #1414977Hi,
Thank you for confirming Guenni007 I have submited it via our Github reporting channel, I’m sure it will be corrected in our next update.Best regards,
MikeJuly 31, 2023 at 8:13 am #1414996Hi,
Thank you to Guenni007 and Mike.best regards,
Jörg :DJuly 31, 2023 at 3:06 pm #1415045Hey,
Our developers fixed this issue and it will be included in the upcoming update.
If you’d like to apply the fix, please replace the /enfold/framework/php/function-set-avia-frontend.php file with this one https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_5_6_5/framework/php/function-set-avia-frontend.php in Appearance > Theme Editor or via FTP.
Regards,
YigitJuly 31, 2023 at 6:08 pm #1415074Hi Yigit,
Thanks for the quick fix!best regards
JörgJuly 31, 2023 at 6:28 pm #1415077August 1, 2023 at 1:49 am #1415103Yes – this is the much better solution!
August 1, 2023 at 5:47 am #1415109 -
AuthorPosts
- The topic ‘Erroneous output, if NO logo is deposited’ is closed to new replies.