Viewing 4 posts - 1 through 4 (of 4 total)
  • Author
    Posts
  • January 7, 2019 at 8:36 pm #1051038
    zimbo

    Version 4.5.1
    Lines 960-962

    echo "<span class='news-thumb $nothumb'>";
 echo $image;
 echo "</span>";

    Lines 1726-1728

    echo	"<span class='news-thumb $nothumb'>";
 echo		$image;
 echo	"</span>";

    In Version 4.5.2
    The last line
    echo "</span>";`
    has been deleted from both code segments and the <span> element no longer appears to be closed.

    The code still appears to work but are these errors? I believe a <span> element needs to be closed

    PS. Because the combo widget does not provide enough control in how it displays the various elements, I hack the code to get the widget showing as I want, hence I came across this code change after updating to 4.5.2. :-)

    January 9, 2019 at 11:10 am #1051721
    Nikko

    Hey zimbo,

    I have checked it with Enfold 4.5.2 in class-framework-widgets.php and the closing span tag is still there.
    It shows in line 962 and line 1723.

    Best regards,
    Nikko

    January 9, 2019 at 2:18 pm #1051831
    zimbo

    Hi,

    I’ve just checked again and the closing span tags are definitely missing on two sites, one is the live site, the other its test/dev site. I updated this site from 4.5.1. (to 4.5.2) by the Update Theme function in WordPress.

    I then checked another site that I updated to 4.5.2 (from 4.5) a couple of days ago. For some reason this site had a 404 error on the Enfold > Theme Update page so would not update ‘automatically’. I had to do a manual FTP update into the theme directory. The code on that site does have the correct closing span tags.

    It seems to me therefore that the update process via WordPress has got some issues and that I need to do manual FTP updates to ensure code integrity.

    I can assure you that I am not going mad (!) and that those lines of code are missing from the ‘WordPress-updated’ sites, and that I would not be wasting your or my time with a spurious support question/query. I have better things to do… :-)

    I think you can close this but might also suggest some feedback to the dev team about what I have experienced.

    January 12, 2019 at 1:41 pm #1053057
    Victoria

    Hi zimbo,

    Looks like the WordPress update process did not overwrite the files properly or the server cached the files and did not update the cache.

    Glad you got it working for you! :)

    If you need further assistance please let us know.

    Best regards,
    Victoria

  • Author
    Posts
Viewing 4 posts - 1 through 4 (of 4 total)
  • You must be logged in to reply to this topic.