Button settings opens table settings?

Hi Elliott,

Thanks for your reply!

After following your advice and further investigation, I managed to track down the root of the problem:

I use a custom table.php file for the child theme, and it loads via this function: http://kriesi.at/documentation/enfold/add-new-or-replace-advanced-layout-builder-elements-from-child-theme/

The function used to work fine, but one of the recent Enfold updates must have changed something.

I did a test loading the original table.php file via the child theme, but this also causes the button settings issue. Suggesting it’s not caused by the code within the custom table.php file.

Also, changing the priority of the function from 15 to another number, doesn’t work either.

The only thing that “solves” the button settings issue, is loading the table.php file via the parent theme. Though this isn’t an option for me, as I prefer the customized version to be update-proof.

It seems that, when using the latest Enfold version, loading shortcode files via a child theme, currently causes advanced layout builder issues. Maybe there’s a path structure in table.php, which stops making sense when it loads via the child theme. Which might cause the table settings to open, when trying to configure a button.

Do you perhaps know what might be causing this?

Thank you,

Ralph

Hi Ismael,

Thanks for your reply!

How can I include those nice code blocks in a post?

Anyway. it’s only a tiny modification to fix the following issue: https://kriesi.at/support/topic/bug-table-headers-applied-incorrectly-on-media-query/#post-423170 It would be great if this issue could be fixed in Enfold’s core code :)

Here’s the requested Pastebin (I only removed the +1 found at line 349): http://pastebin.com/cZdc3Yy2

Please Note: The original / unmodified table.php file causes the same Advanced Layout Builder issue, when the file is loaded via the child theme. Suggesting it’s not caused by the table.php file. The latest Enfold version seems to have issues with loading shortcodes via the child theme, as it used to work just fine with previous versions.

Since I experience this issue on all of my Enfold sites, I believe you should be able to replicate the issue as follows:

1. Activate the Enfold child theme;
2. Use this function in your child theme;
3. Place the original / unmodified table.php in the child theme’s shortcode folder;
4. Edit a page via the Advanced Layout Builder;
5. Open the config settings of a button element, within the page content;
6. Instead of the button config, the table config will pop up.

Hope this helps.

Best,

Ralph

Hey Ismael,

Thank you very much for the temporary fix idea! I didn’t think of that one.

Re your “updateproof” note: Yes, I did indeed realize it could be a potential cause of problems. Which is why I manually update the child theme’s table.php file after each Enfold update and then remove the +1 again. Which, in itself, makes updating Enfold a bit of a hassle. And, for now, the temp buttons fix requires a manual update of buttons.php as well :)

To answer your question: I have indeed tried to make the tables scrollable. But since some of my tables are quite large, this makes them very wide, requiring lots of vertical scrolling… which I think isn’t very mobile user-friendly and doesn’t look that good. Which is why I prefer the tables to be responsive :)

Hopefully Kriesi manages to work something out, which fixes the issues caused by the +1 in tables.php. As I’m sure that the +1 is there for a reason, so removing it doesn’t seem like the best fix.

Maybe this user’s fix is the correct fix (add an extra +1 instead of removing it): https://kriesi.at/support/topic/bug-table-headers-applied-incorrectly-on-media-query/#post-401260 This user’s fix seems to make sense, as each of the 2 $counter var mentions will now be increased with 1. Perhaps this fix is the key to fixing the responive table issue :)

Thanks again,

Ralph

PS: How can I post those nice code blocks as seen in this post: https://kriesi.at/support/topic/viewing-tables-on-mobile-devices-confusing-order-of-items-displayed/#post-417766

Thank you, Ismael :)

Looking forward to a fixed version of Enfold!

Kind regards,

Ralph