Viewing 17 posts - 1 through 17 (of 17 total)
  • Author
    Posts
  • #596442

    Hi, hope your day is going well!

    So I have a developer looking at my site trying to get WPDiscuz working with Enfold and we’re seeing an issue stopping previously targeted anchors being usable in the browser’s back button (go to an anchor, go to another, go to a third, back doesn’t take your focus back to previous anchors).

    From him – What’s happening is something somewhere (probably some rogue Javascript code, possibly in Backbone which enfold pulls in) is intercepting back button functionality and not letting it do what it’s supposed to do: which is go back to the last anchor.

    Specifically, this affects comments, but the general issue likely affects some of our users who rely on screen readers to interact with websites, and anchors are important to them from what I understand!

    Any suggestions?

    #597130

    Hey getmechamot,

    Could you provide us with a link to the site in question so that we can take a closer look please? Also, please try to be as specific as possible as to where you are getting these problem and how you came to the conclusion of what is causing it. Please note that our support for third party plugins is limited and we can unfortunately not be compatible with all plugins out there.

    Regards,
    Rikard

    #597848

    We setup a test server for you to look at that isolates the issue.Using just the Enfold theme and the @reply plugin our site uses to link a reply to its comment (users don’t like threaded so threaded comments are off). @reply inserts a link that links to the comment to which they are replying, and in our old theme (changed last November, so no way to easily go back to prove it!) and previous themes, users became dependent on this functionality.

    Please note, the functionality I mention below doesn’t technically require the @reply plugin, as it has already made the links you’re using to navigate the comments.And WPDiscuz is not loaded; we kept this simple.

    https://bj-staging.bamfic.com/2016/02/27/faunasphere-mad-turkeys-edition/#comments

    This links to a post and it has 50 or so comments. If you scroll down mid-way, you’ll see lots of @XXX where XXX is a commenter’s name, and it’s a link to their comment).. Users follow conversations by clicking on that link and use that to navigate through discussions.They use the back button to return back to where they were.

    For example, find this comment https://bj-staging.bamfic.com/2016/02/27/faunasphere-mad-turkeys-edition/#comment-5684300 and click the @Baud and then the @Hillary Rettig. Now use the back button; it doesn’t take you back through those anchors, but back to a previous page.

    #599654

    Hey!

    I think this is the expected behavior. Do you a different result with a default WordPress theme?

    Regards,
    Andy

    #599688

    Andy.
    No, you are intercepting the normal functionality of the browser!
    I set the site to use the default 2015 theme; it’s not pretty but going to comments, clicking on the @name and then clicking on the Back button takes you back to the comment you were previously looking at.

    I left it with that default theme so you can see what I mean. Please let me know when I can return it back to your good theme! :)

    #601742

    Hey!

    Did you enable the theme’s Page Preloading option? If yes, please enable the theme back then disable the option. Check the comment links again.

    Regards,
    Ismael

    #601978

    No, it is not enabled. When we first installed the theme last fall, it might have been, just to see what it did, but it hasn’t been on since November 2015.

    I have a test site with the theme at http://www.sitetools.info and the other server remains, and I’ve included the user name/password for both sites. .

    Please help – this has now been almost two weeks and you’ve given me the first thing to check! The fact that each time, it’s a different person concerns me; hopefully you’ll take ownership and help get this solved!

    #603721

    Hi!

    I clicked on “@Baud” and then on “@Hillary Rettig”, then I used browser back button and it takes me back to “@Baud” anchor. So it seems to work totally fine for me.

    Which browser and OS are you using? did you check on another computer as well?

    We recommend to update to Enfold v3.5.1.

    Best regards,
    Andy

    #603950

    Andy,
    Funnily enough, it was you on March 17 who said that

    Hey!

    I think this is the expected behavior. Do you a different result with a default WordPress theme?

    Regards,
    Andy

    Less than 30 minutes later, I replied and changed the site to use the default theme and get a different result. In other words, it works when your theme is off, when your theme is on, the back button is disabled. And now, 11 days later, I’m still no closer to getting this solved!

    I gave you two resources to look at:

    • The bj-staging server has the default WordPress theme and had your theme before I switched them. You can login and switch them or poke around.This is the server to make tweaks or changes to; the other one is under strict version control.
    • For a side-by-side, I also provided my sitetools server info to compare since it is the server I’m actively testing on and it has your theme..

    Is there a way to escalate this or otherwise get better response than every 2-3 days? It keeps getting passed around to different folks, no one takes ownership, and you’re forgetting stuff you’ve already done – you, yourself – that are easily readable in this topic!

    #603998

    Hi!

    ok, now I get what you mean. Please can you check if you get the same result when using Enfold v3.5.1? If yes then I will forward this issue to Kriesi and let’s hope that he can find a fix for it soon. Thank you for making us aware about it. We are awaiting your reply.

    Cheers!
    Andy

    • This reply was modified 8 years, 9 months ago by Andy.
    #604009

    Thank you Andy! Have a wonderful day/afternoon/evening/night! :)

    #604128

    Hey!

    so you get same result when using Enfold v3.5.1?

    Regards,
    Andy

    #604138

    Yeah, I loaded it on sitetools.info and the problem remains. I tried this with unedited files downloaded through WordPress. On the off chance that a video ad in a widget was affecting this, I removed the code/ad and the issue remained.

    I’ll update bg-staging in a few minutes so you can see easily see what i mean.(I’ll update and enable Enfold theme)

    Update: I updated the theme on https://bj-staging.bamfic.com/ and set it as the default theme. And back does not work to go through anchors. I even set Enfold as the theme instead of using my child theme in case it was that. Feel free to poke around the site!

    • This reply was modified 8 years, 9 months ago by getmechamot.
    #604273

    Hey!

    For example, find this comment https://bj-staging.bamfic.com/2016/02/27/faunasphere-mad-turkeys-edition/#comment-5684300 and click the @Baud and then the @Hillary Rettig. Now use the back button; it doesn’t take you back through those anchors, but back to a previous page.

    I click the link above and landed on the actual comment. The back button isn’t activated yet because I went directly to that page. I then clicked on the name @Baud and the browser scrolls to the actual comment. The back button is still not activated because I didn’t go to any other page and because of the avia_smoothscroll script. IMO, this is a better user experience compare to clicking on the back button. If you really want the back button to work again, edit the js > avia.js then look for this code:

    //smooth scrooling
    		if($.fn.avia_smoothscroll)
    		$('a[href*=#]', container).avia_smoothscroll(container);

    Comment it out or remove it completely. Note that this will remove the smooth scroll feature that you can see when clicking on any anchor link like the comment link.

    Best regards,
    Ismael

    #604278

    Hi!

    UPDATE: Try to replace the code above with this:

    //smooth scrooling
    		if($.fn.avia_smoothscroll)
    		$('a[href*=#]:not([href*="#comment"])', container).avia_smoothscroll(container);

    Best regards,
    Ismael

    #604668

    Fantastic! Thank you very, very, very much! Hundreds of users will be happy and I will get many less grumps and such!

    FYI, your forum => email library needs a bit of work. The code that was sent to me in the email was corrupted compared to what’s here in the forum. I’m sure it will take 1 minute to solve!

    This is what was sent:
    //smooth scrooling
    if($.fn.avia_smoothscroll)
    $('a[href*=#]:not([href*="#comment"])', container).avia_smoothscroll(container);

    #604961

    Hi,

    Great, glad we could help and thanks for the feedback :-)

    Regards,
    Rikard

Viewing 17 posts - 1 through 17 (of 17 total)
  • You must be logged in to reply to this topic.