Tagged: 

Viewing 6 posts - 1 through 6 (of 6 total)
  • Author
    Posts
  • February 18, 2015 at 6:49 pm #398378
    littleJ

    Hello Enfold creator(s),

    I was wondering if you could revise all your CSS code and release an update to make it play nice with other plugins in the world. For example, having a css line like this is completely irresponsible:

    #top label { 
display: enfold way, no other way possible ever !important;
}

    Thanks

    February 18, 2015 at 10:25 pm #398506
    Elliott

    Hey littleJ!

    That code is not part of our framework. If your not sure where it came from then someone has access to and is editing the files on your server.

    Best regards,
    Elliott

    February 18, 2015 at 10:50 pm #398518
    littleJ

    Well don’t take it literally… of course there is no such CSS property “enfold way, no other way possible ever”. It’s a failed attempt at evil sarcasm.

    The code is in /css/base.css at line 228.

    The problem is the CSS selector. It’s way too broad. #top is the ID you give to the <body> tag. And then you go on to define that any <label> should be displayed as a block, and should be bold, and font size 12px. That’s inconsiderate of any plugin that uses form elements.

    Why not isolate things? i.e. give the form itself an ID, then reference it to style input types and their respective labels?

    February 19, 2015 at 3:25 am #398608
    Josue

    Hey,

    Thanks for your feedback, i’ll let Kriesi know :)

    Best regards,
    Josue

    February 19, 2015 at 3:43 am #398616
    Kriesi

    Hey!

    In general thats what a theme is for. making sure that styling is consistent across all plugins. I agree though that the labels display:block rule is messing up too many plugins and will remove it

    Cheers!
    Kriesi

    February 19, 2015 at 5:34 pm #399064
    littleJ

    Thanks guys.

  • Author
    Posts
Viewing 6 posts - 1 through 6 (of 6 total)
  • The topic ‘Broad CSS rules are big fat NO-NO’ is closed to new replies.