-
Posts
-
Awesome new update. Thanks for the great work!
Some small feedback from me after I looked a little bit into the update.
accessibility: added aria-label=’…’ to elements where user entered a “Custom Title Attribute” in addition to title=’….’
That’s not working with the Button Element. There’s still only the title attr and not aria-label. Would also be nice to be able to fill the field with the new custom field stuff. E.g. the Button Text is “Read More” but the aria-label should be “Read More: {post.title}”
We had a website checked by an company for accessibility. They said that the main content should be wrapped in <main>. Enfold only has <div id=”main”>. I changed that div in dev tools to the main-tag and didn’t encounter any issues. Could you look into that? Would also be nice if we have <header></header><main></main><footer></footer> but I think the footer stuff would be more complex because the footer tag is only the socket and not the #footer. Maybe <footer><div id=”footer”></div><div id=”socket”></div></footer> but that could potentially break someones css.
We are currently doing a lot of accessibility changes in our projects so I maybe come back with some further change requests. I already reported the aria-expanded stuff for the toggler element 5 days ago and you implemented it :)
All the best,
PatrickHey Patrick,
Thank you for pointing at the buttons. Missed it.
I added aria-label to the 3 ALB buttons and custom field to Button Title Attribute option.
I will check the HTML “main” tag. That should be no problem. I will also have a look into footer tag – but I’m afraid the risk of breaking existing sites is rather high.
And we appreciate your help to improve accessibility. We will try our best to implement it.
Best regards,
GünterHi Günther,
Maybe an option in the enfold footer settings where you can switch to another markup would be an idea?
But I’m currently not sure if my markup idea is 100% right. I did some research and some sources state that only the socket should be wrapped in <footer> and others state that that the whole footer part can be wrapped. We also had no explicit feedback on the footer in the accessibility check so maybe leave it like it is for now and I reach back when I have more information.
All the best,
PatrickHi Patrick,
thank you for your feedback.
According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/main main tag should be unique and should not contain parts like sidebar, footer, …
Doing a quick check I see that changing div id=”main” to main id=”main” includes footer and sidebar. And various page templates already include the main tag resulting in multiple main tags. And also page as footer setting might add main tags.
I do not see a quick solution for that at the moment – but I will keep an eye on it.
Best regards,
Günter
- You must be logged in to reply to this topic.