avia-template-builder Improvement

Hi,

I attempted to create a custom avia shortcode for the page builder for extending the library.

I found out that:

Enfold loads avia shortcodes by looping through all of the declared classes that have been declared in that request and checking if they extend aviaShortcodeTemplate. This is doing more work than it has to.

Enfold uses the class name as the href of the shortcode’s icon in the template builder. This breaks the link and the template disappears when dropping it onto the editing pane.

Shortcode Template Icon in on the page editor:

<a data-avia-tooltip="Creates a simple text block" data-dragdrop-level="3" href="#SomeNamespace\avia_sc_text" class="shortcode_insert_button  avia-target-insert ui-draggable ui-draggable-handle"><img src="http://localhost/wp-content/themes/enfold/config-templatebuilder/avia-template-builder/images/sc-text_block.png" alt="Text Block"><span>Text Block</span></a>

As you can see href="#SomeNamespace\avia_sc_text" is an invalid link.

Possible Solutions:

One possible solution to this could be replacing ‘\’ with ‘_’ and check for that in referencing locations. But this could potentially confuse two classes as the same class. ex. namespace\class ans namespace_class. These are two conventions available.

A better approach would be declaring a method abstract so the subclass can declare the tag it should have.

One possible improvement for the loader is to use a filter based system instead. Filter an array to add class names. Loop through the array and initialize only those templates. This
prevents looping over all declared classes which will lead to better execution time.

Let me know your thoughts,
Jason Gallavin