-
Posts
-
Hi, I’m helping a customer that wants to write “Read more >” in the text of the button module. The problem is that > is not escaped/converted to it’s html entity and therefore it breaks the html code of the page.
I’ve suggested that the customer uses > instead of “>” and it works fine the first time he/she updates the page but the second time a change is made to the page the “>” is back and the html breaks again.
I just wonder if it’s a conscious decision to not escape html in this case or would you possibly consider it for a future release?
And the ampersand character is not escaped in this form so my second paragraph is suppost to be:
I’ve suggested that the customer uses [ampersand]gt; instead of “>” and it works fine the first time he/she updates the page but the second time a change is made to the page the “>” is back and the html breaks again.
Hi,
Could you please provide us with a temporary admin login so that we can take a closer look? You can post the details in the Private Content section of your reply.
Regards,
RikardHi there,
I’m trying to use following text in my full width button “Learn more about Services >”, but it doesn’t work with angel bracket and it’s displaying only this text on my button: ‘Learn
And when clicking on it it doesn’t take me to the Services page.
Can someone give me any suggestions of adding angle bracket “>” to my buttons and for button to display and work properly as when I don’t have any brackets.
Thank you , Alan
Hi amarkoc,
Can you give us temporary admin access to your website in the private content box below, so that we can have a closer look.
Best regards,
VictoriaHi there,
Your buddy Rikard helped me out and it works now with following:
Please try this, without the spaces between the characters:
& g t ;Thank you, Alan
Hi Victoria, Rikard and others that reply to this thread. The proposed fix was already in my original message from 2015. However I also state that this fix is temporary, it will work once but in any later updates to the page the & gt; will be read as an angle bracket character and we are back to square one…
This has nothing to do with any local installation (so don’t bother asking for a login to my site). It can be tested in any installation of the Enfold theme (just tested it in the most recent version 4.0.5 and the problem is still there). The correct fix is to make a code change in the themes Button module to convert angle brackets to html entities.
@martin_e83 I just tested this with the button element from enfolds layout architect and put ‘< shop >’ into the text field. The button shows the text on the web page. I have than added addditional elements to the site and saved again multiple times. The text on the button did not change and shows ‘< shop >’ all the time.
…and how I eventually solved it back in 2015 was to use the character » instead of > or & gt;, but that’s still just a workaround and not a solution to the real problem that angle brackets are not handled correctly within the button module.
Hi martin_e83,
I would say that such symbols should not be allowed, since they can break your page or make the html invalid. There are plenty of icons for that matter.
But then again, glad you got it working for you :)
Best regards,
VictoriaHi Victoria,
Thank you for your response. Well I can agree that icons may be more appropriate since “greater than” in this case does not make any sense in a purely semantic meaning. However, my customer wanted the text of the button to be “Read more >” and apparently several others had the same need and found the same problem with the Enfold theme since then.
Greater than is very much a valid character if handled correctly and escaped. You can see from my initial question that I wondered if it’s a conscious decision to not handle angle brackets like it is usually handled in texts but instead letting it pass unescaped and breaking the html. The response I got was “can i get access to your site”, which was not really the response i was hoping for. I guess this is not really leading anywhere but if people continue to reply to this thread I hope you can consider escaping angle brackets correctly (eg converting them to & gt; on save).
Best regards
Martin@martin_e83 I tried the ‘shop >’ button and confirm the issue. However this seems not to be a pure Enfold issue. I just checked the wordpress shortcode parser and there you need to use ‘& g t ;’ because an angle bracket brakes the attribute parser. The problem: If you use ‘& g t ;’ it will be displayed as angel bracket next time you open the editor and voila saving the post will break the code. This is an interesting issue that needs some intensive testing with other themes and some self developed shortcodes to test different scenarios.
Hi there,
I thought & g t ; would work, but I guess after refreshing several times and the next day I realized it’s not working again.
Thanks martin_e83 for “»” tip. I’ll try using this character, but it’s not the same. All websites out there for more info or shop buttons are using “>” character. For such a widely used enfold theme I’m sure many people had the same issue, so I hope enfold team will look into it and fix it in the next theme update.
Cheers, Alan
- You must be logged in to reply to this topic.