Forum Replies Created
-
Posts
-
Thanks Günter
Wish you health and safety with the recent COVID rise in Austria.
Tell me if anything.
All the best
WadihHi Günter,
Thank you so much, it works great in both french and english now.
The fix is already applied on our site, but when you officially release 4.8.7.2 to the public, will I need to manually do anything, since we have the early fix?
Thank you so much
Hi Günter,
I modified the following file in the official theme:
./themes/enfold/framework/php/font-management/class-avia-type-fonts.phpAnd added the line in functions.php child theme:
add_theme_support( 'custom_uploaded_fonts_relative_url' );Cleared the enfold cache because I don’t use any other type of cache (by saving settings and toggling css fusioning on and off)
Unfortunately, it’s still calculating the URL wrong for the ttf’s.
Please give me your SSH public key, and I will add it for access to the site to inspect the code.
I’ve tried reuploading the font on the English side through Theme Options -> Import/Export -> Custom Font Manager , but it just flipped the problem on the other side, e.g. now both English and French CSS was loading the ttf from the same english domain yourimmigration.ca. It fixed the english side but broke the french side. So I restored the site back to what it was before that step.
Yes the files in the media library are accessible equally under all my different domains including ttf’s from my understanding, that’s the default from what I see.
So I before I can try your fix on class-avia-type-fonts.php as-is, I updated to 4.8.7.1 because I was still on v. 4.7.6.4 .
Now I replaced the file
class-avia-type-fonts.phpwith your on github. What should I do next? Nothing changed yet on the english side. I tried regenerating the files, but no change. How do I activate the condition for your new code path?Hi Günter,
Sure. I wouldn’t mind updating the record in phpmyadmin. I could give you SCP access if you like through an SSH key to the site. Or I can do any changes or checks on your behalf. I am pretty flexible.
Instead of re-uploading the font which I’m not sure of a clean way of doing that, could you tell me which hard-coded value I would change in the db? That would be easiest for me. Unless it’s a serialized value?
I will keep a backup of the site so I will be able to easily revert back if anything.
Thank you so much
Hi Günter,
Thank you so much for your technical answer, finally something I can work with. I am a programmer myself, so we will speak the same language.
I had already tried disabling and enabling the cache, the minifying, I even tried modifying manually the CSS file, but when they get overwritten by Enfold, it gets overwritten with the wrong URL’s again.
To answer your question, the ttf files already works automatically with both the english and french domains, it’s already handled successfully by default.
The problem will come down to the line of code that calculates the resulting URL in your software.
I have a good relation with WPM.L, as a customer, and the ways to retrieve the proper “current” URL has changed over the years, but it’s been stable lately. I know that because I developed some custom WPM.L code before and had to change that part of the code.
I think however you guys should be experts on that plugin though, and not be an afterthought. Your clients shouldn’t have to worry about that. This is the kind of things that should be between Enfold and the authors of WPM.L.
So that I can ask WPM.L the right targeted question, could you tell me which piece of code calculates the URL in Enfold right now? It probably it uses one of their helper function, which might have become obsolete since.
Pleasure working with you on that, and looking forward to resolve that permanently. I know many Enfold people will be happy, most of them haven’t taken the time to bring it up, so I’m doing it on everyone’s behalf.
By the way is there a way we can continue this thread by email? When I write the word WPM.L twice in the same message, the display of your support site eats up everything in between those two strings. There’s a bug in the display logic of kriesi.at support forum with the word WPM.L, probably a regexp issue.
Wadih
Hi,
I don’t think you are understanding the issue. Can you please escalate to somebody with higher level of skill, the authors directly if possible? Or tell me where I can do a complaint?
The question about WPML you asked me you can already find the answer yourself by visiting the site. You will see that it is not a folder setup, but a domain setup. It is perfectly configured, everything works fine, EXCEPT the CSS generation from Enfold, using the wrong domain on the English CSS.
I tried to explain it 2 times already, I gave the links of the french CSS and the english CSS generated by enfold, and I demonstrated how the english CSS generated by enfold is wrong.
Will you please raise this bug to your developers? They will find the line in the source code causing this issue and be able to resolve it.
There should be somewhere in the Enfold source code that has to be repaired so that the english CSS starts using the english domain instead of the french domain, without the need of any .htaccess meddling (which would not be a solution, but just a patchwork).
Hi,
Please refer to my previous response. Please see that CSS file on the English side which is generated by Enfold:
As you see inside, the TTF fonts are sourcing from the wrong domain (votreimmigration.ca – which is the FR version):
@font-face{font-family:'poppins';src:url('https://www.votreimmigration.ca/wp-content/uploads/avia_fonts/type_fonts/poppins/poppins-black.ttf') format('truetype');It should be sourcing from the english domain, e.g. yourimmigration.ca.
Compare these two ENFOLD generated CSS:
French CSS:
https://www.votreimmigration.ca/wp-content/uploads/dynamic_avia/avia-merged-styles-973b1958acabc34491fb515bf8883ba0—617c6b28df629.css
English CSS: https://www.yourimmigration.ca/wp-content/uploads/dynamic_avia/avia-merged-styles-4ebd15befa0f877ffcc392d15eb52ff8—617c9f02baac0.cssWhy is the english CSS using FR domains inside? Do you see what I mean? This is the bug we need to fix.
Thank you so much
Hi,
WPML is configured properly, and Enfold is able to use the respective resources for the respective domain everywhere except for the .ttf fonts.As I explained how the behavior should be, the CSS files should be different for each language, e.g.
FR: http://www.frenchdomain.com/wp-content/uploads/avia_fonts/type_fonts/poppins/poppins-light.ttf
EN: http://www.englishdomain.com/wp-content/uploads/avia_fonts/type_fonts/poppins/poppins-light.ttf
ES: http://www.spanishdomain.com/wp-content/uploads/avia_fonts/type_fonts/poppins/poppins-light.ttfAnd so on and so forth. Your code right now generates the same CSS code for all langauges, e.g.:
FR: http://www.frenchdomain.com/wp-content/uploads/avia_fonts/type_fonts/poppins/poppins-light.ttf
EN: http://www.frenchdomain.com/wp-content/uploads/avia_fonts/type_fonts/poppins/poppins-light.ttf
ES: http://www.frenchdomain.com/wp-content/uploads/avia_fonts/type_fonts/poppins/poppins-light.ttfDo you understand the issue better now?
You may escalate this bug to the appropriate decision makers please, hoping for it to be resolved before the expiration of my license, so I can update accordingly, and everybody else can update and have this resolved at the source.
If I need to contact the authors directly, could you guide me on how I can do that?
