Forum Replies Created

Viewing 30 posts - 1 through 30 (of 335 total)
  • Author
    Posts
  • in reply to: Possible bug with img tags being parsed #1477521

    Hey Yigit.

    Thanks for the feedback.

    I understand what you’re saying about some other plugin or something, but the entire code section goes missing, not just the URL for the image, which makes me think this is less likely.

    And yep, plenty of server space reported.

    Thanks for making a test at your end, I have added one on my end, as well with your suggestion of trying it through Gutenberg – two pages made within minutes of each other, one with ALB and one with Gutenberg. Will report back in a week or two.

    Thanks

    Tim

    in reply to: Timeline Element improvements #1477503

    Hi Gunter,

    Excellent, thanks for finding the issue and fixing it so quickly. 7.0 release is looking like a good one!

    Regards

    Tim

    • This reply was modified 1 day, 6 hours ago by THP Studio.
    in reply to: Timeline Element improvements #1477350

    Sorry Gunter, apologies again for messing you around.

    Please see private.

    in reply to: Timeline Element improvements #1477282

    Hi Gunter,

    Apologies for that, please see private.

    Tim

    in reply to: Timeline Element improvements #1477000

    Hi Gunter,

    Sure, please see private and you’ll notice there is duplicate content for each class=”av-milestone-date timeline-text” element, one hidden and one not.

    Thanks for taking a look.

    Tim

    in reply to: Possible bug with img tags being parsed #1476999

    Hi Gunter,

    Thanks for the reply.

    Can’t be a DB update from a backup, as has happened on multiple sites at different times.

    We have one example where on the 28th of January we edited a page and inserted two images using the method described above (because they had previously disappeared from this page due to this issue) and sent a screenshot of it working on the front end to the client (we still have the screenshot).

    Since then, we haven’t edited the page at all, and I noticed that they have disappeared since then, probably in the last week or so (as we would have noticed it sooner). If I go and check the page revisions, it shows the last revision was on the 28th of January, and it shows the text block where I inserted the images into as being completely empty of any content whatsoever.

    We don’t understand how the page ever seems to work at all, but then randomly breaks over time. But it seems like it can only be something along the lines of: Enfold writes it to the DB on save, then perhaps sees it as bad ALB code when trying to read it down the track and strips it?

    This has only appeared in the last few months, where we’ve gone from versions like 6 or 6.0.1 to the latest 6.0.8 or 9. Is it possible something has changed in those versions which could have affected this?

    I know this is a tricky one to track down, as it will only disappear randomly, but if you would like a login for the page I’m talking about above to take a look just let me know.

    Thanks

    Tim

    in reply to: Possible bug with img tags being parsed #1476851

    Hey Rikard,

    Appreciate the quick response.

    If you follow what you quoted above, hopefully you will see it. Only thing is, it doesn’t happen right away. The images get stripped some time after building the page. Sometimes it’s been days, other times weeks. But please try and see if you can reproduce it.

    Only other thing we can think of is object cache causing a problem with how it’s being written to the database. Is enfold fully compatible with object caches?

    Thanks

    Tim

    in reply to: Product Image Hover & Cache #1465153

    Hi Gunter,

    Thanks so much for taking the time to look at this.

    Your thoughts really helped point us in the right direction and eventually we were able to find a simple CSS conflict that was causing the issue, related to that litespeed-loaded class you mentioned. For anyone else who uses Litespeed cache and wants product hover but finds it isn’t working properly, hopefully this helps…

    Litespeed in their documentation suggest this code which makes lazy loaded images load in nicer:

    /* PART 1 - Before Lazy Load */
    img[data-lazyloaded]{
        opacity: 0;
    }
    /* PART 2 - Upon Lazy Load */
    img.litespeed-loaded{
        -webkit-transition: opacity .5s linear 0.2s;
        -moz-transition: opacity .5s linear 0.2s;
        transition: opacity .5s linear 0.2s;
        opacity: 1;
    }

    But the opacity settings in here conflict with how Enfold wants to handle the image hover. So using a not pseudo class and removing that from the product hover eliminates this issue entirely:

    /* PART 1 - Before Lazy Load with shop products hover excluded */
    img[data-lazyloaded]:not(.avia-product-hover) {
        opacity: 0;
    }
    /* PART 2 - Upon Lazy Load with shop products hover excluded */
    img.litespeed-loaded:not(.avia-product-hover) {
        -webkit-transition: opacity .5s linear 0.2s;
        -moz-transition: opacity .5s linear 0.2s;
        transition: opacity .5s linear 0.2s;
        opacity: 1; 
    }

    Hope that helps, and thanks so much Gunter, really appreciate your time always helping us with things.

    Regards

    Tim

    in reply to: Product Image Hover & Cache #1465015

    Hi Gunter,

    No problem at all, appreciate you getting back to me.

    Please see private,

    Thanks

    Tim.

    in reply to: WooCommerce Category Styling #1463911

    Hi Gunter,

    Excellent, thanks for adding a fix for that, much appreciated.

    Regards

    Tim

    in reply to: WooCommerce Category Styling #1463280

    Hi Gunter,

    Thanks for looking it over and getting back to me.

    Yes it is a fairly heavily customised site, and the 0’s that are being returned are a result of us just using a standard WP function to allow the uploaded images to retain their initial ratio’s on upload and not get cropped at all.

    We did some further testing and found that using your ‘avf_woocommerce_default_banner_image_size’ filter we can successfully return another image size and have it display correctly. For some reason returning the default Enfold size isn’t working correctly for us, but it may be something to do with how we are altering that size in our functions file. So don’t know the root cause of that one, but we can successfully work around it so that is fine.

    However, after some more testing it seems the other issue is in fact a bug. Here are our steps to reproduce it:

    1. Set a shop banner image in Enfold settings and then save it (settings used are “Responsive banner image with description below” and also have enabled Banner for product category pages toggle). This loads fine on the front end.

    2. Now remove the banner image from the back end (don’t change the Banner for product category pages toggle) and save it. On the front end now any Woo category that DOESN’T have it’s own unique banner image set shows the last uploaded image from the media library. My developer noted that it seems to be occurring due to the code around this area:

    Caused by around line 1730:

    // find attachment id – remove width and height
    $full = preg_replace(‘/-\d+[Xx]\d+\./’, “.”, $bg );
    $att_id = attachment_url_to_postid( esc_url( $full ) );`

    $bg is blank and then $full is blank.

    Then attachment_url_to_postid returns the last image uploaded.`

    Hope that helps in debugging that issue.

    Thanks again

    Tim

    in reply to: WooCommerce Category Styling #1462525

    Hi Gunter,

    Thanks for the quick reply. Please see private for details.

    Yes that option is selected in the theme options, but as outlined in point 1 it didn’t work. Now there’s no image set (as you’ll see in the backend) yet the most recently uploaded image in the media library displays for all categories.

    Look forward to seeing what you find out, thanks for the assistance.

    Regards

    Tim

    in reply to: WooCommerce Category Styling #1462447

    Hi Gunter,

    I’m continuing this here as it’s probably more appropriate, but our last communication on it was in this thread:

    First of all, thanks so much again for working on the category banner images for Woocommerce categories, it’s a big win for our clients.

    However I think I have found two bugs (unless I’m missing something). This is on the latest 6.0.2 version.

    1. In the Theme > Shop Options section I enabled a Shop Banner Image, tested it on the front end, noticed a problem (which is point #2), and then removed the image from these settings and resaved the theme options. However now, even though no image at all is set in the theme options, each category is pulling in the most recently uploaded image on the website and using that as the banner for each category that doesn’t have an individual image set for it. See private #1 for examples.

    2. It seems that the images selected are hardcoded to load in at 1500×1500 for some reason? I am loading up panoramic images but they keep just displaying as 1500×1500 regardless. Even in the Shop Banner Image section in Theme Options I have the option when selecting an image to choose it’s size (which I don’t seem to have for individual categories) but even this one loads in square. See #2 in private for example.

    Thanks Gunter for your work on this, hopefully these quirks aren’t too painful to work out.

    Tim.

    • This reply was modified 7 months, 1 week ago by THP Studio.
    • This reply was modified 7 months, 1 week ago by THP Studio.
    in reply to: Sale badge for variable products #1448376

    Hi Gunter,

    That is fantastic news, thank you very, very much!

    I really appreciate you working on that and I look forward to trying it out soon with the release of 6.0

    It looks like it’s going to be a huge release, lots of work detail in the changelog. Thanks for all your work improving the theme.

    Will let you know any feedback on it once I’ve tested it.

    Thanks again

    Tim

    in reply to: Sale badge for variable products #1443974

    Hi Gunter,

    See private please.

    Thanks

    Tim

    • This reply was modified 9 months, 1 week ago by THP Studio.
    in reply to: Sale badge for variable products #1443777

    Hi Gunter,

    In Private,

    Thanks again.

    in reply to: Sale badge for variable products #1443158

    Hey Gunter,

    please see private field, thank you

    Tim

    • This reply was modified 9 months, 2 weeks ago by THP Studio.
    in reply to: Pricing Table Empty Rows #1438214

    Thanks Gunter for looking into this and adding the fix in the next update, much appreciated.

    Tim.

    in reply to: Sale badge for variable products #1431948

    HI Gunter,

    Please see private, thanks.

    Tim

    in reply to: Sale badge for variable products #1431822

    Hey Gunter,

    Thanks for taking a look, I wasn’t sure if it was theme or core related so thanks for confirming.

    Please see private.

    Thanks again

    Tim

    in reply to: WooCommerce Category Styling #1425710

    Hi Gunter,

    Thanks for adding it to the to-do list.

    Really hope it can be one of the more urgent things so we can make our shop fronts look and perform really nicely.

    Thanks for all your work.

    Regards

    Tim.

    in reply to: WooCommerce Category Styling #1424191

    Hi Gunter,

    Circling back to this one, sorry for the long delay on it. We’ve tried to make this work ourselves, but really feel that improving this in core Enfold would be the better option if at all possible.

    Most ecommerce stores now have a banner image on their category pages, and while Enfold has this ability I really hope it could be improved. My suggestion is the following…

    1. Leave the current functionality in place for sites that already have it so as not to break anything
    2. Provide an option in the Enfold Shop settings to toggle the existing parallax effect on or off
    3. Provide an option in the Enfold Shop settings to toggle the ability to have text over the image on or off. If this is set to off, the image should no longer be loaded as a background image, but rather a normal image with full srcset abilities to improve performance, and the ability to select an image size from the usual drop down list of registered image sizes. Also, if this option is set to off, the text is output below the image on the page as normal.
    4. Provide an option in the Enfold Shop settings to change the position of where this image is displayed on the front end. Currently it displays above the breadcrumb bar, but this is unusual functionality as any page built with the ALB will always put content below the breadcrumb bar. So an option to place the image below the breadcrumb bar (but still full width) would be perfect.

    These settings would need to affect not just the single Shop banner image, but also the category banner images as well (that are added via editing the categories themselves).

    I hope that makes sense Gunter, thanks as always for considering improvements

    Kind regards

    Tim

    • This reply was modified 1 year, 3 months ago by THP Studio.
    • This reply was modified 1 year, 3 months ago by THP Studio.
    • This reply was modified 1 year, 3 months ago by THP Studio.
    in reply to: Feature Request: Badges/Labels #1423847

    Feel free to add your thoughts Guenni007 :) more input on features the better

    in reply to: Feature Request: Badges/Labels #1423843

    Thanks Gunter, please see below.

    in reply to: Feature Request: Badges/Labels #1423069

    Hey Gunter,

    Thanks as always for considering requests, Much appreciated.

    Regards

    Tim

    • This reply was modified 1 year, 4 months ago by THP Studio.
    in reply to: WooCommerce HPOS #1415682

    Hey Gunter,

    Excellent, thanks for confirming that, I figured Enfold wouldn’t need to interact directly with those changes but just wanted to confirm.

    Thanks for taking the time to respond.

    Regards

    Tim

    in reply to: WooCommerce HPOS #1415391

    the forum breaks the link, see private

    in reply to: Search question #1406130

    Thanks Ismael, we will keep your code for reference should we need this again on another project, much appreciated.

    This can be closed.

    Tim

    in reply to: Logo Missing Quick Fix #1405893

    can be closed thanks

    in reply to: Responsive Images In Lightbox #1405892

    This can be closed thanks.

Viewing 30 posts - 1 through 30 (of 335 total)