Forum Replies Created
-
AuthorPosts
-
Hi Gunter,
Thanks so much for taking the time to look at this.
Your thoughts really helped point us in the right direction and eventually we were able to find a simple CSS conflict that was causing the issue, related to that litespeed-loaded class you mentioned. For anyone else who uses Litespeed cache and wants product hover but finds it isn’t working properly, hopefully this helps…
Litespeed in their documentation suggest this code which makes lazy loaded images load in nicer:
/* PART 1 - Before Lazy Load */ img[data-lazyloaded]{ opacity: 0; } /* PART 2 - Upon Lazy Load */ img.litespeed-loaded{ -webkit-transition: opacity .5s linear 0.2s; -moz-transition: opacity .5s linear 0.2s; transition: opacity .5s linear 0.2s; opacity: 1; }
But the opacity settings in here conflict with how Enfold wants to handle the image hover. So using a not pseudo class and removing that from the product hover eliminates this issue entirely:
/* PART 1 - Before Lazy Load with shop products hover excluded */ img[data-lazyloaded]:not(.avia-product-hover) { opacity: 0; } /* PART 2 - Upon Lazy Load with shop products hover excluded */ img.litespeed-loaded:not(.avia-product-hover) { -webkit-transition: opacity .5s linear 0.2s; -moz-transition: opacity .5s linear 0.2s; transition: opacity .5s linear 0.2s; opacity: 1; }
Hope that helps, and thanks so much Gunter, really appreciate your time always helping us with things.
Regards
Tim
Hi Gunter,
No problem at all, appreciate you getting back to me.
Please see private,
Thanks
Tim.
Hi Gunter,
Excellent, thanks for adding a fix for that, much appreciated.
Regards
Tim
Hi Gunter,
Thanks for looking it over and getting back to me.
Yes it is a fairly heavily customised site, and the 0’s that are being returned are a result of us just using a standard WP function to allow the uploaded images to retain their initial ratio’s on upload and not get cropped at all.
We did some further testing and found that using your ‘avf_woocommerce_default_banner_image_size’ filter we can successfully return another image size and have it display correctly. For some reason returning the default Enfold size isn’t working correctly for us, but it may be something to do with how we are altering that size in our functions file. So don’t know the root cause of that one, but we can successfully work around it so that is fine.
However, after some more testing it seems the other issue is in fact a bug. Here are our steps to reproduce it:
1. Set a shop banner image in Enfold settings and then save it (settings used are “Responsive banner image with description below” and also have enabled Banner for product category pages toggle). This loads fine on the front end.
2. Now remove the banner image from the back end (don’t change the Banner for product category pages toggle) and save it. On the front end now any Woo category that DOESN’T have it’s own unique banner image set shows the last uploaded image from the media library. My developer noted that it seems to be occurring due to the code around this area:
Caused by around line 1730:
// find attachment id – remove width and height
$full = preg_replace(‘/-\d+[Xx]\d+\./’, “.”, $bg );
$att_id = attachment_url_to_postid( esc_url( $full ) );`$bg is blank and then $full is blank.
Then attachment_url_to_postid returns the last image uploaded.`
Hope that helps in debugging that issue.
Thanks again
Tim
Hi Gunter,
Thanks for the quick reply. Please see private for details.
Yes that option is selected in the theme options, but as outlined in point 1 it didn’t work. Now there’s no image set (as you’ll see in the backend) yet the most recently uploaded image in the media library displays for all categories.
Look forward to seeing what you find out, thanks for the assistance.
Regards
Tim
Hi Gunter,
I’m continuing this here as it’s probably more appropriate, but our last communication on it was in this thread:
First of all, thanks so much again for working on the category banner images for Woocommerce categories, it’s a big win for our clients.
However I think I have found two bugs (unless I’m missing something). This is on the latest 6.0.2 version.
1. In the Theme > Shop Options section I enabled a Shop Banner Image, tested it on the front end, noticed a problem (which is point #2), and then removed the image from these settings and resaved the theme options. However now, even though no image at all is set in the theme options, each category is pulling in the most recently uploaded image on the website and using that as the banner for each category that doesn’t have an individual image set for it. See private #1 for examples.
2. It seems that the images selected are hardcoded to load in at 1500×1500 for some reason? I am loading up panoramic images but they keep just displaying as 1500×1500 regardless. Even in the Shop Banner Image section in Theme Options I have the option when selecting an image to choose it’s size (which I don’t seem to have for individual categories) but even this one loads in square. See #2 in private for example.
Thanks Gunter for your work on this, hopefully these quirks aren’t too painful to work out.
Tim.
- This reply was modified 5 months ago by THP Studio.
- This reply was modified 5 months ago by THP Studio.
Hi Gunter,
That is fantastic news, thank you very, very much!
I really appreciate you working on that and I look forward to trying it out soon with the release of 6.0
It looks like it’s going to be a huge release, lots of work detail in the changelog. Thanks for all your work improving the theme.
Will let you know any feedback on it once I’ve tested it.
Thanks again
Tim
Hi Gunter,
See private please.
Thanks
Tim
- This reply was modified 7 months, 1 week ago by THP Studio.
Hi Gunter,
In Private,
Thanks again.
Hey Gunter,
please see private field, thank you
Tim
- This reply was modified 7 months, 1 week ago by THP Studio.
Thanks Gunter for looking into this and adding the fix in the next update, much appreciated.
Tim.
HI Gunter,
Please see private, thanks.
Tim
Hey Gunter,
Thanks for taking a look, I wasn’t sure if it was theme or core related so thanks for confirming.
Please see private.
Thanks again
Tim
Hi Gunter,
Thanks for adding it to the to-do list.
Really hope it can be one of the more urgent things so we can make our shop fronts look and perform really nicely.
Thanks for all your work.
Regards
Tim.
Hi Gunter,
Circling back to this one, sorry for the long delay on it. We’ve tried to make this work ourselves, but really feel that improving this in core Enfold would be the better option if at all possible.
Most ecommerce stores now have a banner image on their category pages, and while Enfold has this ability I really hope it could be improved. My suggestion is the following…
1. Leave the current functionality in place for sites that already have it so as not to break anything
2. Provide an option in the Enfold Shop settings to toggle the existing parallax effect on or off
3. Provide an option in the Enfold Shop settings to toggle the ability to have text over the image on or off. If this is set to off, the image should no longer be loaded as a background image, but rather a normal image with full srcset abilities to improve performance, and the ability to select an image size from the usual drop down list of registered image sizes. Also, if this option is set to off, the text is output below the image on the page as normal.
4. Provide an option in the Enfold Shop settings to change the position of where this image is displayed on the front end. Currently it displays above the breadcrumb bar, but this is unusual functionality as any page built with the ALB will always put content below the breadcrumb bar. So an option to place the image below the breadcrumb bar (but still full width) would be perfect.These settings would need to affect not just the single Shop banner image, but also the category banner images as well (that are added via editing the categories themselves).
I hope that makes sense Gunter, thanks as always for considering improvements
Kind regards
Tim
- This reply was modified 1 year, 1 month ago by THP Studio.
- This reply was modified 1 year, 1 month ago by THP Studio.
- This reply was modified 1 year, 1 month ago by THP Studio.
Feel free to add your thoughts Guenni007 :) more input on features the better
Thanks Gunter, please see below.
Hey Gunter,
Thanks as always for considering requests, Much appreciated.
Regards
Tim
- This reply was modified 1 year, 2 months ago by THP Studio.
Hey Gunter,
Excellent, thanks for confirming that, I figured Enfold wouldn’t need to interact directly with those changes but just wanted to confirm.
Thanks for taking the time to respond.
Regards
Tim
the forum breaks the link, see private
Thanks Ismael, we will keep your code for reference should we need this again on another project, much appreciated.
This can be closed.
Tim
can be closed thanks
This can be closed thanks.
Hi Yigit,
Thanks for the response.
We’ve worked out a solution for our needs, this can be closed.
Regards
Tim
Thanks Yigit, this can be closed.
Thanks Gunter, appreciate your time.
We’ll see what we can do with the filter you’ve added in 5.6
Thanks again.
Tim.
Thanks Gunter, we will wait for 5.6 to test the functionality, but hopefully this does what we need it to, although if it just pulls max size I’m not sure it will. Could it be tweaked a little to allow us to specify an image size to call?
Regards
Tim
Hey Gunter & Ismael,
Thanks for pointing us in the right direction, we have been able to achieve what we needed.
One other search related question…
At the moment when the AJAX search box is open, you can click outside of it to remove/hide it. This is good/logical, but it has a flaw. While attempting to click away from the AJAX search box, if you click on something that is actually a link then the link click registers and you now navigate away from the page you were just on.
This becomes especially problematic on shop category pages for example where basically everything on the screen has a link attached to it, so clicking to remove the search box almost always results in navigating to a new page by mistake.
Can we please get some code/functionality to ensure the first click is only to hide the search box, and does not register an on-page click?
Thanks a lot as always
Tim
Hi Gunter,
Thanks a lot for the reply. Shame there’s no easier way to interact with this.
To help us further with this, can I ask how Enfold adds the search icon to the header so that it always stays in its position in the header both on desktop and mobile? Eg: on mobile it doesn’t get added to the hamburger menu, but rather sits next to it, which is what we want.
Thanks
Tim
Hi,
Thanks.
-
AuthorPosts