Forum Replies Created
-
AuthorPosts
-
Thanks, Ismael — I was so hopeful, but it doesn’t seem to work. This post, for example, is still full of those tags: https://lunchticket.org/how-to-keep-writing-an-interview-with-lisa-locascio-nighthawk/ — maybe it doesn’t work on the Advance Layout Editor? Thanks again for trying!
December 4, 2021 at 9:23 am in reply to: excerpt line breaks not showing in magazine element #1331527Thanks for your diligence as always, Ismael! I assume there’s no filter for the child theme. Do you think this will be included in a future theme update, or do they actually want to keep the Magazine element working differently like that for some reason?
OK, thanks so much — I’ll keep that in mind.
December 1, 2021 at 9:45 pm in reply to: excerpt line breaks not showing in magazine element #1331228No, that’s what I’m saying: apparently, with the Blog Posts element, the contributors can just use carriage returns in the Excerpt field, like this: https://prnt.sc/212tca0 — that’s a screenshot of the current Excerpt field for that post.
November 30, 2021 at 9:32 am in reply to: excerpt line breaks not showing in magazine element #1330955Hmm, but the Blog Posts element I’m using seems to be pulling from the Excerpt field. For example, I just added a few dots to the end of the first line in the Excerpt field for Never Mercy (see https://prnt.sc/212tca0 ) and those dots show on https://newissue.wpengine.com/weekly-content/amuse-bouche/ . Am I misunderstanding?
OK, thanks anyway — please let me know if you hear anything else about this — it looks so close; like it’s there but it’s just not showing because it’s the wrong z-index or something (although I tried testing that to no avail). Anyway, thanks for trying!
Sure thing — just updated — doesn’t look like it helped. https://busd.wpengine.com/maptest
November 29, 2021 at 10:01 am in reply to: excerpt line breaks not showing in magazine element #1330814Right, but it works without even adding the br tags in the blog element and, since this client has a bunch of layperson contributors adding posts, I was hoping we could get it to work without having to tell them to add code in the excerpts — know what I mean?
Beautiful, Yigit — it works — thanks so much!! Now, any chance there might be something like that coming for the Magazine element? I just need to move the author line below the titles there (see https://prnt.sc/20xu1cl ). Thanks again!!
November 28, 2021 at 8:48 am in reply to: excerpt line breaks not showing in magazine element #1330725Thanks, Ismael, but I think we’re still misunderstanding each other. Simple line-breaks in the custom excerpts (like this https://prnt.sc/20xtwsa ) are working fine in the Blog element (in every option with excerpts except the grid layout — see first post on https://newissue.wpengine.com/weekly-content/amuse-bouche/ for example) — they’re just not working in the Magazine element (see https://prnt.sc/20xty1r ). Nevertheless, I did try adding your snippet, and I added a br to the list of allowed tags at the top, but it didn’t seem to work. Any other ideas? Thanks again!
Sure thing…
Awesome! So, when the next version is released, I should look for the filter somewhere around here? https://kriesi.at/documentation/enfold/blog-post/#post-with-meta-data-below-title — is that the best way to find the new filter?
November 19, 2021 at 10:01 pm in reply to: excerpt line breaks not showing in magazine element #1329744Thanks, Ismael, but to be clear re your last sentence, the client is defining the excerpts manually. And again, the line breaks aren’t being stripped out in the Blog Posts element (at least not in the Single author, small preview pic layout); only in the Magazine element.
Fair enough — thanks, Yigit!
Thanks, Mike, but putting the whole edited file in the child theme doesn’t seem like such a great solution, to me — I wouldn’t want to miss out on other updates to that file, as the theme is updated — know what I mean?
I need to show the authors instead of the dates in the blog grid on my client’s site: https://newissue.wpengine.com/weekly-content/blog/, and I got this to work for me by replacing the time lines on 927-928 with:
$author = get_the_author_meta( 'display_name', $entry->post_author ); $meta .= "<span class='slide-meta-author updated'>" . $author."</span>";So, thank you, but is there any way this could be handled via the child theme?
I needed the same thing; to limit the custom excerpt length in the blog element grid view, and Ismael’s function worked for me — thanks, Ismael! Only problem is it’s breaking in the middle of words — what’s the trick to limit the number of words, as opposed to characters, or to prevent the excerpts from breaking in the middle of words? Here’s the page I’m working on https://newissue.wpengine.com/weekly-content/blog/
September 1, 2021 at 8:25 am in reply to: Enfold forms styling overriding Elementor's form styling and options #1319302Hey Ismael, I just realized I never replied to you here — partly because this sounds over my head, so I think I’ll let it slide, for now. But thanks as always for the reply and effort on your end. I’ll keep this in my back pocket in case I need to dig back into it. You can close this ticket for now, if you want.
Ooh, Ok, thanks again, Ismael!!
OK, thanks, Yigit!
Thanks so much, Ismael. I couldn’t get it to work, but we can hold off on this for now — I’ll get back to you once I confirm we absolutely need to do this. Meanwhile, maybe you can just confirm for me — if we do figure this out, can it be handled via the child theme? I guess not, eh? Thanks again.
Thanks, Ismael. Adding the role attribute looks pretty straight-forward, but working in the aria-expanded true/false it pretty far over my head — any way you could provide any further guidance on that one? And is there any chance either of these things could be handled via the child theme? Thanks again, and as always ;)
Hey Mike, thanks so much for looking into this and sharing with the dev team!! The accessibility review doesn’t seem to reference specific guidelines for this issue — I can ask them about that; I think we’re setting up another review with them within a couple of weeks. I would guess having the menu close once the user tabs out of it would be a significant improvement, at least., but I’ll definitely let you know what they say when I find out. FYI, this is the accessibility firm my client’s using, and you can see their mobile menu works in the way they describe — maybe that could provide a clue re how to program it? https://convergeaccessibility.com/ Anyway, thanks again for taking this question seriously :)
@goldengate415. FYI, my client’s accessibility specialist said those plugins are no good — maybe they’re biased, but you may want to look into that. Here’s an article, for example: https://creative-boost.com/overlays-and-plugins-arent-the-answer-to-accessibility/
Thanks, but the issue is that, if you tab all the way through the mobile menu — without making a selection — the focus jumps out of the mobile menu and back into the site/page behind the mobile menu. So then the user is left with the mobile menu still open, but the focus is not longer in the mobile menu. You can see this issue if you tab past the end of the 2017 demo menu, too. The accessibility firm says we have to “trap” the focus in the menu until the user either makes a selection or closes the menu. In other words, if the user tabs to the end of the menu, the focus should jump to the close button for the mobile menu and then back to the start of the mobile menu. Does that make sense now?
I’m sorry, I still don’t understand — I thought the filter was something I would add to my child theme, so where would you be adding the filter, in the footer.php file? Are you saying I can just keep an eye on the footer.php file to see if you make that change in future updates? Thanks.
OK, thanks, Günter,, but would yo please elaborate on “documented in place” — what do you mean by that?
Re #7 above, one of my clients is working with an accessibility expert and they recommended removing the aria-hidden=true attribute from the scroll-top-link. They think that attribute was put there to hide that link on the phone, but that method apparently creates an accessibility concern on the desktop, where it’s visible. So they’re suggesting removing the attribute and using css to hide it in mobile. Is there a way for me to remove that aria-hidden attribute via my child theme? Thanks!
-
This reply was modified 4 years, 5 months ago by
sky19er.
That worked! So here’s the complete function to pull the full content of posts into the post slider, process the shortcode, and add paragraph breaks:
function avf_post_slider_entry_excerpt_custom($excerpt, $prepare_excerpt, $permalink, $entry ) { $excerpt = $entry->post_content; return do_shortcode(wpautop($excerpt)); } add_filter('avf_post_slider_entry_excerpt', 'avf_post_slider_entry_excerpt_custom', 10, 4);Thanks again, Ismael — I repeat: you’re the man!
-
This reply was modified 4 years, 5 months ago by
-
AuthorPosts
