Forum Replies Created
-
AuthorPosts
-
Thank you for the follow-through, Mike! Sorry about that link expiring — I’ve updated/extended it and repasted it in private content along with sftp info for that dev site — feel free to mess with that site all you want, I’m not worried about losing anything there. Thanks again and lmk if you have any other questions.
OK, I moved the closing divs back to the bottom of page.php (Is this the correct way to close those divs? https://capture.dropbox.com/ROwRW1tjKO7zxuXA ), added all the code from footer.php below that (I assume I’m supposed to remove the get_footer function, correct?), and removed the closing divs from that footer code. Does that all look/sound correct? It doesn’t seem to work — the header and footer both disappear as soon as I activate the Elementor footer. I’m including the info again in the private content, in case you have any other ideas for me :). Thanks again.
OK, so, I should be able to test this with just the page.php file, if I’m only looking at “regular” pages (eg https://gatcomdev.wpengine.com/about/), right? If so, I added the closing divs to the page.php file and it doesn’t seem to do the trick. In my testing it seemed like I had to remove the echo, like this: https://capture.dropbox.com/RmIFvQzocT49oUt0 — does that look right?
When looking at the source after adding those closing divs to the page.php file, I can’t find those new closing divs — I’m guessing maybe because I’m using Elementor to build the pages. If I add the closing divs to the header.php file and view the source, I can see them (https://capture.dropbox.com/hMUlWN8NYgc6dzpQ), but they still don’t seem to make a difference — when I turn on the Elementor footer the Enfold header still disappears — so I put them back in page.php, per your instructions, for now.
Any other ideas for me? Thanks again.
OK, thanks so much — but it sounded to me like they said Elementor would replace the footer.php — “Please note that Elementor doesn’t just hook to WordPress functions. It declares its own theme locations and replaces the theme header.php and footer.php files.” — doesn’t that mean, as long as I’m using the Elementor footer, I don’t need to worry about the Enfold footer.php?
Thanks, Mike! Can you tell me how often you’d guess I’ll have to update those files, due to theme updates? I mean, you don’t think it will be impractical in that respect?
Thanks, Mike — here’s what they said:
Please note that Elementor doesn’t just hook to WordPress functions. It declares its own theme locations and replaces the theme header.php and footer.php files. For reference: https://developers.elementor.com/docs/themes/ Therefore, this is still valid feedback from my side: https://elementor.com/help/considerations-for-theme-builder-compatibility/
Do you think that leaves me any hope for a workaround? Thanks again.
Thanks so much, Mike — sorry I didn’t catch that — I’ll bounce that back to Elementor support and let you know here what they say, either way, if you don’t mind keeping this open.
Thanks, Ismael, but I’m sorry, I misread what they (Elementor support) said and therefore described it wrong to you. They said “[Enfold] opens several div tags in the header template and then closes them in the footer template.” — plus, I missed that they had actually included screenshots (linked below) — does that make more sense, now? Thanks again and lmk if you have any other questions.
header opening tags: https://capture.dropbox.com/oYrHiQf977skxIW4
footer closing tags: https://capture.dropbox.com/Dp4mXtmqwdaJ4JnLAugust 6, 2023 at 5:34 pm in reply to: sorry content area not found error for popups in Elementor #1415653Yep, you can close it!
Yep, you can close it!
August 6, 2023 at 3:01 am in reply to: sorry content area not found error for popups in Elementor #1415630OK, I’ll try to get to that ;). Meanwhile, I seem to have narrowed this particular issue down to the footer options — as long as I don’t select a page to replace the footer in the Enfold options, the popups in Elementor still work; setting that footer page is what seems to break them. Anyway, thanks again!
OK, thanks anyway. I much prefer the way Enfold handles the headers and navigation, but when a client’s already using Elementor I feel pressured to stick with it, especially since Elementor does have some clear advantages. But I still believe Enfold is a smarter system, on the whole (including better support!), and I still recommend Enfold for clients who aren’t already familiar with Elementor. Anyway, thanks again, and thanks for so many years of good support and a great theme!
Thanks, Mike — that did it, for both the theme update and fixing the mailchimp element — feel free to close this thread, now. Thanks again!
Thanks, Mike, but I can’t seem to get the update to come available in the theme options — any idea why it might be stuck on “No Updates available. You are running the latest version! (5.5)”?
Heheh, ok, thanks again, Guenni!
Right, but unless it needs to be there for accessibility, I’d rather not have it at all.
Oh, and Mike, you may notice I did end up switching (at least for now) to using the icons in the main header area, but Guenni’s code with my css still seems to be working, so I’m inclined to leave it as is, unless you think it’s a problem. Thanks again, guys!
Ah, good to know, Guenni — thank you. I set the width to a pixel value instead. But I’m not sure what you’re saying about the heading — is not having a heading an accessibility issue or something?
Thanks, Mike, but I’m using the Full Page Overlay Menu, where the menu items are centered. I wanted to center the social icons, like all the other menu items, and the quickest way I could find to do that was to change the width of the list item containing the social icons ul from 100% to fit-content, and then set the margins to auto. But that “Social Bookmarks” text (even though it wasn’t showing on the front end) was adding a bunch of width to the list item, preventing me from perfectly centering the icons. Removing that text from the php code solved the problem. Does that make sense now?
Sorry, Guenni, did it sound like I was still having trouble? I think I’m all set on this — I’m keeping the socials in the top strip on desktop, and your code helped me add them to the mobile menu, for when they disappear from the header on mobile. Thanks again for your help!
Oops — thanks, guys! I couldn’t even see them on my phone, but once I saw the screenshot from Guenni, I found them on my emulator, in tablet view.
And yeah, I think you’re right, Guenni, about wrapping them in an li. And I’d like to keep them in the top strip, on desktop — so, thanks, Mike, I don’t think I want them in the main header area on this site, but I’ll keep your solution in mind if I do!
So I went with Guenni’s code using the socket socials, but they were still showing at the left edge of my mobile overlay menu. I was able to center them by changing isHeading=”Social Bookmarks” in the php to isHeading=”” (deleting that whole line seemed to vanish the icons), and setting the css to width=”fit-content”; margin: auto; — so here’s my code, if it helps anyone else.
Thanks again, guys!!!
<?php function social_footer_icons_to_hamburger_menu(){ ?> <script> (function($){ $('#header').one('click', '.av-main-nav-wrap', function() { var isMobile = $('.av-burger-menu-main').css('display'), isHeading = "", social = $('#socket .social_bookmarks').clone(true).addClass('sub-menu').css('display','block'), mobileMenu = $('.av-burger-overlay'); mobileMenu.find('#av-burger-menu-ul').append('<li class="menu-item-social av-active-burger-items" role="menuitem"><span class="avia-menu-text">'+isHeading+'</span></li>'); if( social.length ){ mobileMenu.find('.menu-item-social').append(social); } }); })(jQuery); </script> <?php } add_action('wp_footer', 'social_footer_icons_to_hamburger_menu');
And then this css seems to work for me:
.html_av-overlay-full #av-burger-menu-ul li.menu-item-social { width: fit-content; margin: 30px auto; } .html_av-overlay-full #top #wrap_all #av-burger-menu-ul li.menu-item-social li { font-size: 1em; margin: 5px; }
Thanks, Mike! Feel free to close this thread.
Thanks, Mike — what I find tricky is that, when looking in the inspector, unlike with “normal” hover states, I can’t see any change in the css when the slides open, so I couldn’t find what to target — know what I mean? Anyway, if you don’t know what I mean or don’t have any other advice in that respect, feel free to close the topic — and thanks again!!
Ahh, nice! Thanks, again, Mike! Any tips for how to find that kind of thing? I’m usually pretty good with css, but it seemed particularly hard to find the css that was changing when the slides open.
Perfect — beautiful! Thanks so much, Mike — case/thread closed! ;)
Yep, you can go ahead and close it, if you like.
Thanks, Mike, but actually, you/they can hold off on this, for now — I just spoke with my client about this and we’ve decided we might switch gears and try to make the default Events Calendar view work for us, rather than customizing this Events Calendar Shortcode plugin. Thanks anyway, though!
April 26, 2023 at 12:09 am in reply to: using blog element for events calendar listings, need to order by event date #1405617Nice — thanks so much, Ismael — the ordering’s working, and that’s amazing, but it seems now the recurring events aren’t showing. For example, there should be recurring events showing on https://gobeyondhomes.org/property/wilmington-townhomes/. If I disable the functions file in the child theme, I can see the recurring events, but we’re getting that “nothing found” message when the functions file’s active. Do you have any idea why that might be? Thanks again.
April 24, 2023 at 6:38 pm in reply to: using blog element for events calendar listings, need to order by event date #1405415Sorry about the sftp info — below/private has a new password. Instead of reverting the whole site, I just uploaded restored the functions file. But replacing the ADD POST SORT OPTIONS TO ENFOLD ELEMENTS filter at the bottom of that file with the filter you provided didn’t seem to work, so I left the original filter in place.
BTW, you’ll notice the Morgan Place page/url now seems to have some events at the bottom which aren’t formatting properly — I’m guessing that’s a separate issue due to staff not properly entering events, or something (I haven’t seen that issue before) — I’m guessing you can ignore that, for now.
Thanks again and lmk if you have other questions.
April 17, 2023 at 8:09 am in reply to: using blog element for events calendar listings, need to order by event date #1404644Thanks, Ismael — looks like I added it with the CPT UI plugin (see https://capture.dropbox.com/s1Lk7UWcUheKvgfd), but I also just noticed this block of code at the bottom of my functions file (sorry I missed that the first time). Thanks again and lmk if you have any other questions.
// ADD POST SORT OPTIONS TO ENFOLD ELEMENTS if(!function_exists('avia_custom_query_extension')) { function avia_custom_query_extension($query, $params) { global $avia_config; if(!empty($avia_config['avia_custom_query_options']['order'])) { $query['order'] = $avia_config['avia_custom_query_options']['order']; } if(!empty($avia_config['avia_custom_query_options']['orderby'])) { $query['orderby'] = $avia_config['avia_custom_query_options']['orderby']; } unset($avia_config['avia_custom_query_options']); return $query; } add_filter('avia_masonry_entries_query', 'avia_custom_query_extension', 10, 2); add_filter('avia_post_grid_query', 'avia_custom_query_extension', 10, 2); add_filter('avia_post_slide_query', 'avia_custom_query_extension', 10, 2); add_filter('avia_blog_post_query', 'avia_custom_query_extension', 10, 2); add_filter('avf_magazine_entries_query', 'avia_custom_query_extension', 10, 2); add_filter('avf_template_builder_shortcode_elements','avia_custom_query_options', 10, 1); function avia_custom_query_options($elements) { $allowed_elements = array('av_blog','av_masonry_entries','av_postslider','av_portfolio','av_magazine'); if(isset($_POST['params']['allowed']) && in_array($_POST['params']['allowed'], $allowed_elements)) { $elements[] = array( "name" => __("Custom Query Orderby",'avia_framework' ), "desc" => __("Set a custom query orderby value",'avia_framework' ), "id" => "orderby", "type" => "select", "std" => "", "subtype" => array( __('Default Order', 'avia_framework' ) =>'', __('Title', 'avia_framework' ) =>'title', __('Random', 'avia_framework' ) =>'rand', __('Date', 'avia_framework' ) =>'date', __('Author', 'avia_framework' ) =>'author', __('Name (Post Slug)', 'avia_framework' ) =>'name', __('Modified', 'avia_framework' ) =>'modified', __('Comment Count', 'avia_framework' ) =>'comment_count', __('Page Order', 'avia_framework' ) =>'menu_order') ); $elements[] = array( "name" => __("Custom Query Order",'avia_framework' ), "desc" => __("Set a custom query order",'avia_framework' ), "id" => "order", "type" => "select", "std" => "", "subtype" => array( __('Default Order', 'avia_framework' ) =>'', __('Ascending Order', 'avia_framework' ) =>'ASC', __('Descending Order', 'avia_framework' ) =>'DESC')); } return $elements; } add_filter('avf_template_builder_shortcode_meta', 'avia_custom_query_add_query_params_to_config', 10, 4); function avia_custom_query_add_query_params_to_config($meta, $atts, $content, $shortcodename) { global $avia_config; if(empty($avia_config['avia_custom_query_options'])) $avia_config['avia_custom_query_options'] = array(); if(!empty($atts['order'])) { $avia_config['avia_custom_query_options']['order'] = $atts['order']; } if(!empty($atts['orderby'])) { $avia_config['avia_custom_query_options']['orderby'] = $atts['orderby']; } return $meta; } }
-
AuthorPosts