Forum Replies Created
-
AuthorPosts
-
Hi Ismael,
I was doing a lot of testing & htaccess changes yesterday, so temporarily disabled all other admin logins. Active now.
Added note:
Also by the way, you don’t really need admin access for that, you can also see it by adding a default WP Text widget to a footer column in a standard clean Enfold with Child installation :-)
OL works fine, UL doesn’t.Kind regards,
Rob- This reply was modified 5 years, 7 months ago by rob2701. Reason: added additional info
April 2, 2019 at 7:01 am in reply to: Highlighting active parent menu item on subitem opening #1085870Hi Ismael,
Thanks for the clear explanation about the sorting script.
I do understand the why, i.e. giving the user freedom to select any combination of cats/subcats, but it just feels counterintuitive to me to have to exclude the parent when using subcategories :-)
It’s just something I need to add to my “that’s just the way it is” list.Kind regards,
RobApril 1, 2019 at 10:26 am in reply to: WooCommerce cart item deletion behaviour with Enfold #1085402Hi Mike,
Regarding the de-activated password protection:
No, I did not allude “that it was working differently for logged in users”. Quite the contrary. I stated above that the Cache was NOT disabled for logged in users, so that the frontend pages would be the same whether logged in or not. Please read accurately.
I know you de-activated the Password Protec plugin, then activated W3TC. Then visited the frontend. I also know that you re-activated the Password Protection afterwards. So far so good. But what happened when the unprotected pages were already cached? You forgot to purge the cache and/or de-activate W3TC. Exactly: the site was happily continuing to serve unprotected CACHED pages to everyone. The cache was doing what caches do. Simple logic, right?
Fact remains that there was absolutely NO good reason for you to even touch the Password Protect plugin. The Temporary Login plugin totally circumvents the password protection, and the Dashboard has Visit Site and Visit Store links.
There is no reason to log out to check the frontend either. So the whole thing was utterly avoidable.When you opt for a nuclear option like this, at least retrace all of your steps or check with the customer beforehand!
I was lucky to discover this after about an hour. But what if I had not not been available for a week? I don’t think you realise that this could have created real practical damage for my client and for my reputation be able to protect my client’s data like I promised them. For that same reason, could you please delete the Dropbox video? Thanks.In short: if I hand you guys the key to the garden door to be able to check on a problem with the dishwasher in the kitchen, you should not have to unlock the front door, much less leave the front door unlocked and wide open when you have left again through the garden door. Thanks for understanding the impact of this.
Regarding the issue with the cart:
Yes, we agree then that the issue only occurs when then W3 Total Cache is active.
That was never the question. This is not about attaching the blame for the issue to someone or to the theme, it is about finding the cause for the issue and solving it. The puzzle is finding out what is causing it. And why all browsers EXCEPT IE show the issue when the cache is active.While I appreciate the time you spent on this, it still baffles me why you would need to repeat all steps of my testing just to confirm the exact symptoms I reported. Now we know that we can both properly test an issue. Good for us! :-)
I know perfectly well that Enfold is not Woo is not W3TC. So I was never asking anyone to debug the W3 Total Cache plugin, in fact I posted above that I had posted on their support forum as well.
What I was asking for was insight into the difference in WORKING of the X and Quantity cart item deletion…
Because it could very well be a difference in page refresh method (javascript call or inline or something else) which requires something to be excluded in W3TC. Could be Enfold, could be Woo, could be an exclusion needed in W3TC somewhere (before you ask, all Woo cart/checkout/shop pages are already excluded from the cache). And the baffling thing here to me is that in IE the issue does NOT occur WITH W3TC active.Again, thanks for the time you spent on this. I do understand that being flooded with requests does things to the workings of logic. But reading helps.
May I suggest some general guidelines for your entire support team?
1.
Instead of diving in to repeat a test already done and already well-described and reported by the customer, please read the entire history of the post twice. Then try to understand what the customer is actually asking. And only then take action or respond.2.
And if you do take action: please retrace all of your steps put the furniture back in the original position when you leave. Double-check.3.
In case of a nuclear option like de-activating Password Protect: check with the customer first to get approval.Kind regards,
Rob
March 31, 2019 at 10:02 pm in reply to: WooCommerce cart item deletion behaviour with Enfold #1085182Hi Mike,
Sure the issue is there, I know that and you just confirmed what I already knew.
That’s why I was asking for insight into the difference between the two cart deletion methods. Like you can read above.What I do definitely NOT appreciate is you disabling the password mode on this staging site. Why oh why would you touch that?
That is there to PREVENT access to the general public to the staging – still allowing external support like yours through the Temporary Login link for admins (DIFFERENT plugin!). This is a staging site, it is NOT supposed to be accessible from the outside (as there is also a LIVE site somewhere), and you messed that up by leaving the cached version active AFTER disabling the password protection. There was absolutely NO reason whatsoever for you to do that, because, as I explained above, the settings were already available for testing through pages being cached also for logged in users aka admins aka Enfold support. You just needed to hit “visit site” from the Dashboard.I fixed it now, but this sort of thing does not really enforce my trust in Enfold support per se.
I know you guys have a lot on your plate, but properly reading and thinking about what you do on a site (even if staging) should be part of the package…Kind regards,
Rob- This reply was modified 5 years, 8 months ago by rob2701. Reason: added note about Temporary Login and Password Protect being 2 different plugins
March 31, 2019 at 6:56 pm in reply to: WooCommerce cart item deletion behaviour with Enfold #1085141Hi Mike,
Thanks for taking time to look at this. However…
Did you notice that this happens when W3TC is ACTIVE? At the moment it is deactivated, so that’s why the issue isn’t happening.
I did a lot of tests, so Enfold compression currently off, as well as W3TC. Feel free to activate.
Additonal info: cart is excluded from page cache. Cache is NOT disabled for logged in users (otherwise you would not be able to see (password protected site – staging).So long story short:
W3TC deactivated > all fine
W3TC activated > problem with X as you and I described (except in IE). Mac died, so can’t check Safari.
Feel free to activate it (with or without Enfold compression active) and check (staging site, so knock yourself out).
;-)BTW, I have also reported the issue at the W3TC forum, see what they can say about this.
Kind regards,
Rob- This reply was modified 5 years, 8 months ago by rob2701. Reason: some additional info added
Hi Rikard,
Any text-widget really. Check the home page footer text-widgets (col 1,2 and 3).
Link to staging in private. See bottom of QuickCSS.Kind regards,
RobNOTE:
I also changed the rule to #id li (since the list-style property applies to list-items li, not the container ul).
But that doesn’t work either.
I think this may be because Enfold has decided to set list-style-type to NONE in the base css and then adds classes to achieve circle, disc, square etc.
The other way around would maybe have been handier, i.e. add a class for .no-bullet or something instead of changing the default behavior?
Anyways, I stil want to get this to work the normal way, and not even targeting the specific page will work in the current setup. :-)- This reply was modified 5 years, 8 months ago by rob2701.
March 29, 2019 at 7:45 pm in reply to: shopping cart table in WooCommerce with different colors #1084724Sorry for misunderstanding. I had just done the fonts myself and just “assumed” you had the same, without looking at the pics. :-)
Glad you found it!March 29, 2019 at 12:17 pm in reply to: shopping cart table in WooCommerce with different colors #1084539/* WooCommerce no grey font 2nd grid row cart+checkout */ .woocommerce-cart-form tr:nth-child(2n), .woocommerce-checkout tr:nth-child(2n) { color: #111111; }
- This reply was modified 5 years, 8 months ago by rob2701.
March 26, 2019 at 7:26 pm in reply to: WooCommerce cart item deletion behaviour with Enfold #1083208Hi,
Saw on the W3TC forum that they are preparing a new version. So will wait for that first.
For now the behaviour with deleting items from the shop cart I described above is definitely there with W3TC active, tried all kind of W3TC settings changes but it still remains.Perhaps you can shed some light on how the behaviour with deleting through the cross differs from deletings through the quantity in the cart.
Will try to check on the Woo forums as well and post here if I find something.
Kind regards,
RobAddition:
Just installed W3 Total Cache 0.9.7.3 (just released an hour or 2 ago) and tested.
With Enfold compression disabled and W3TC active: same “delete from cart” behaviour described above
With Enfold compression enabled and W3TC active: same “delete from cart” behaviour described above
With Enfold compression disabled: both methods of product deletion work fine
With Enfold compression enabled: both methods of product deletion work fineI wish I could say that there’s maybe something wrong with my W3TC settings, but I do not think that is the case after lots of tweaking. EVERYTHING works very well with Enfold compression + W3TC active, it’s just that one stupid thing in the cart item deletion with the X that not behaving the way it should.
So still looking for the answer to this puzzle. Any help appreciated… thanks in advance!
2019-03-27, found this has probably nothing to do with W3TC…
Results testing with Enfold Compression enabled and W3TC enabled, deleting cart item with X:
works flawlessly ONLY in IE, needs page refresh in Opera, FireFox and Chrome.
did not test Edge as I refuse to use W10 :-)So I guess this is back to you now, Enfold support
- This reply was modified 5 years, 8 months ago by rob2701. Reason: error corrected
March 25, 2019 at 12:32 pm in reply to: Highlighting active parent menu item on subitem opening #1082628Hi,
Thanks for taking the time to look at this. Unfortunately though, the test page you set up proves my point about the illogical nature of the choices exactly :-)
As you can see:
- 1. instead of just choosing the parent to get sorting, you need to choose ALL subcategories to display sorting
- 2. IF, like you did, you ALSO choose the parent category, then you get a DUPLICATE, i.e. PARENT = also ALL. In other words, ALL and PARENT are identical.
- 3. Conclusion: the PARENT needs to be excluded to get a proper sorting in the portfolio grid. This is not logical i.m.o. and this was exactly my point.
Perhaps one of the devs can explain the why and how of this arrangement?
Kind regards,
RobP.S.:
Trying to warn here also about some possible illogical behaviour with this “free to choose a combination of all subcategories from various parents”.
For exampke consider this scenario:
if you have 2 different portfolio cats, each with subcats, and both have a subcat with the exact same name, say “sour fruits”, then what would be the result in the sorting options? Would they display separately in the sorting or be merged even if belonging to different parents? Just saying.- This reply was modified 5 years, 8 months ago by rob2701. Reason: added explanation of why I'm worried about this
March 24, 2019 at 6:10 pm in reply to: WooCommerce cart item deletion behaviour with Enfold #1082274After some more testing it is definitely related to W3 Total Cache, not to Enfold. :-)
W3 Total Cache 0.9.7.2 seems to have some issues with WP 5.1.1:
– after a few times activate-deactivate-purge cache-reactivate W3TC freezes up, cannot be reactivated.
– after that it cannot be deinstalled, need to manually delete W3TC files through FTP, then reinstall
– leaves behind W3TC entries in htaccess at deinstall (browser cache and core W3TC)So, even if it’s not Enfold related, I will leave the link active to the staging if you want to have a look.
It’s a staging and well backed up, so knock yourselves out if you want to do some testing yourselves :-)Sure, close when you want. It was solved anyway :-)
Kind regards,
Rob- This reply was modified 5 years, 8 months ago by rob2701.
Hi Mike,
no worries about the late reply, I can see you are all a bit swamped with requests.
Actually, I don’t understand your comment…Of course the CSS works for me (that’s why I added it).
I just noticed that without my addition it is not correct in the standard Enfold CSS, meaning that in the current Enfold situation the headings are close together without any space if they follow each other directly without a paragraph in between :-)
So I just thought to give you guys a heads up to maybe include it as an addition to the CSS in the next version, that’s all.
Kind regards,
RobHi Rikard,
Sure, details in the private message block.
See the Privacy Policy page (which has multiple headers following each other).
Then uncomment the CSS code for h1+h2, etc. in the Quick CSS.
Then visit the page again.Regards,
RobMarch 12, 2019 at 8:46 pm in reply to: Highlighting active parent menu item on subitem opening #1077960Hi, here’s how I solved it in case someone else needs it too:
/* change active menu item background and color */ /* this works for PAGES with SUBPAGES */ .current_page_item a { color: #719430; } /* highlight SHOP menu item when product item open */ /* hover over "Remove" button of menu item to see menuID */ .single-product .main_menu ul li#menu-item-MENUID a .avia-menu-text { color: #000000; } /* highlight bottom border when menu top header */ .single-product .main_menu ul li#menu-item-MENUID a { border-bottom: 2px solid #719430; } /* highlight only proper Portfolio menu item (category) when single portfolio item open */ /* hover over "Remove" button of menu item to see the menuID */ /* because of subcategories for sorting now I have to specify each subcategory as well */ body.single-portfolio.category-A .main_menu ul li#menu-item-MENUID a .avia-menu-text, body.single-portfolio.category-A1SUB .main_menu ul li#menu-item-MENUID a .avia-menu-text, body.single-portfolio.category-A2SUB .main_menu ul li#menu-item-MENUID a .avia-menu-text, body.single-portfolio.category-A3SUB .main_menu ul li#menu-item-MENUID a .avia-menu-text, body.single-portfolio.category-B .main_menu ul li#menu-item-MENUID a .avia-menu-text { /* color: #719430 !important; */ color: #000000 !important; } /* highlight bottom border when menu top header */ body.single-portfolio.category-A .main_menu ul li#menu-item-MENUID a { border-bottom: 2px solid #719430 !important; } /* because of subcategories for sorting need to specify each subcategory as well */ body.single-portfolio.category-A1SUB .main_menu ul li#menu-item-MENUID a, body.single-portfolio.category-A2SUB .main_menu ul li#menu-item-MENUID a , body.single-portfolio.category-A3SUB .main_menu ul li#menu-item-MENUID a { border-bottom: 2px solid #719430 !important; }
The bottom border parts are only valid if you use top menu of course.
When you have time I’d be very interested in your answer on:
- why I need to choose all portfolio subcategories (without the parent) in the portfolio grid in order to get sorting.
- if possibile, wouldn’t it be more logical to select the parent to automatically include the subcats for sorting? See my explanation above.
P.S.
Theme is a joy to work with! Great job!hI,
For anyone interested in follwoing the same route as me to serve up double-size retina images with high compression to all devices, here’s what I did.functions.php in child theme:
// remove "responsive images" functionality in WP 4.4 and higher add_filter('wp_get_attachment_image_attributes', function($attr) { if (isset($attr['sizes'])) unset($attr['sizes']); if (isset($attr['srcset'])) unset($attr['srcset']); return $attr; }, PHP_INT_MAX); add_filter('wp_calculate_image_sizes', '__return_false', PHP_INT_MAX); add_filter('wp_calculate_image_srcset', '__return_false', PHP_INT_MAX); remove_filter('the_content', 'wp_make_content_images_responsive'); // Disable loads of Enfold & WP image sizes upon upload // do image sizes manually, double-size with high compression for retina screens // use Photoshop to set exact double size and quality between Q30 and Q40 add_action('init', 'remove_enfold_image_sizes'); function remove_enfold_image_sizes() { // do NOT remove widget size, is used in backend portfolio items! // remove_image_size('widget'); remove_image_size('square'); remove_image_size('featured'); remove_image_size('featured_large'); remove_image_size('portfolio'); remove_image_size('portfolio_small'); remove_image_size('gallery'); remove_image_size('magazine'); remove_image_size('masonry'); remove_image_size('entry_without_sidebar'); remove_image_size('entry_with_sidebar'); remove_image_size('shop_thumbnail'); remove_image_size('shop_catalog'); remove_image_size('shop_single'); remove_image_size('shop_gallery_thumbnail'); } // Remove unneeded WP image sizes add_filter( 'intermediate_image_sizes_advanced', 'prefix_remove_default_images' ); // Remove default image sizes here. function prefix_remove_default_images( $sizes ) { // do NOT remove small and medium sizes, they are used in backend Media Library! // unset( $sizes['small']); // 150px // unset( $sizes['medium']); // 300px unset( $sizes['large']); // 1024px unset( $sizes['medium_large']); // 768px return $sizes; }
List of Enfold/TopMenu image sizes for different image ratios:
w = standard width Enfold
Rw = doubled Enfold width for Retina
GR = Golden RatioENFOLD WITH Top menu full width header banner frontpage w 1519 x 430 / Rw 3040 x 860 >>>>> USE: 4:1 > 3000 x 849 news featured w 81 x 81 / Rw 162 x 162 >>>>> USE: 1:1 > 180 x 180 1:1 > 360 x 360 portfolio 2 column featured w 758 / Rw 1516 >>>>> USE: 4:3 > 1600 x 1200 3:2 > 1600 x 1067 16:9 > 1600 x 900 GR > 1600 x 991 portfolio 3 column featured w 507 / Rw 1014 >>>>> USE: 4:3 > 1024 x 768 3:2 > 1024 x 683 16:9 > 1024 x 576 GR > 1024 x 624 portfolio 4 column featured w 378 / Rw 756 >>>>> USE: 4:3 > 800 x 600 3:2 > 800 x 533 16:9 > 800 x 450 GR > 800 x 496 portfolio single full width w 1419 / Rw 2838 >>>>> USE: 4:3 > 3000 x 2250 3:2 > 3000 x 2000 16:9 > 3000 x 1688 GR > 3000 x 1858 portfolio single 2/3 w 918 / Rw 1836 >>>>> USE: 4:3 > 1920 x 1440 3:2 > 1920 x 1280 16:9 > 1920 x 1080 GR > 1920 x 1189 portfolio single 3/4 w 1043 / Rw 2086 >>>>> USE: 4:3 > 2500 x 1875 3:2 > 2500 x 1667 16:9 > 2500 x 1406 GR > 1920 x 1549 gallery with right sidebar w 986 / Rw 1972 >>>>> USE: 4:3 > 2000 x 1500 3:2 > 2000 x 1333 16:9 > 2000 x 1125 GR > 2000 x 1239 store multi product w 320 / Rw 640 >>>>> USE: 4:3 > 640 x 480 3:2 > 640 x 427 16:9 > 640 x 360 GR > 640 x 396 store single product 1/2 w 667 / Rw 1334 >>>>> USE: 4:3 > 1440 x 1080 3:2 > 1440 x 960 16:9 > 1440 x 810 GR > 1440 x 892 5 column featured w 216 / Rw 432 >>>>> USE: 4:3 > 480 x 360 3:2 > 480 x 320 16:9 > 480 x 270 GR > 480 x 297 3/5 of page w 817 / Rw 1634 >>>>> USE: 4:3 > 1800 x 1350 3:2 > 1800 x 1200 16:9 > 1800 x 1013 GR > 1800 x 1115
March 11, 2019 at 11:37 am in reply to: Highlighting active parent menu item on subitem opening #1077272Hi,
Playing around with it some more, I have found that I need to choose only subcategories (children) for display. Then sorting works as it should. BUT: in my mind this is a bit of a convoluted workaround and it creates other problems.
Now I need to target each subcategory in the CSS separately to get proper menu highlighting. And the highlighting behaves as if it were a subMENU item (which it is not, it is just a subcategory in the portfolio with no menu item set for it), that is to say the highlight bottom color becomes attached directly to the menu text instead of being on the bottom of the header…And how do I solve that?
And what happens if I have another portfolio category B which has a subcategory name equal to the one in portfolio category A?I understand that it’s a difficult situation because the theme wants to give the user the liberty to freely choose any combination of portfolio categories to display in the grid. Fine if we’re only talking about parents (same level). But here we have 1 parent with a few children.
<spockmode on>The resulting behaviour is highly illogical, captain!</spockmode off>
This is what I have logically presented:
FRUITS
Apples
Pears
Bananas
Sweet
SourFirst:
I would expect that choosing FRUIT to display in the portfolio would include the subcategories.
After all, they are only for sorting purposes WITHIN the main portfolio cat. That’s why they are set as children.
But: I need to choose all children to get sorting below the parent. Doesn’t make sense (at least not to me). I would understand it if the children were parents also, but they’re not.Second:
This complicates matters enormously, because a “Granny Smith apple” would be:
Fruit / Apple / Sour, belonging to 3 categories (1 parent and 2 children).
Setting the subcats specifically to be CHILDREN should be enough for the display and the sorting to understand what it needs to do?So my question is:
Wouldn’t it be better and easier to have “parent includes children” as the default and then treat child exclusions as exceptions?
To my mind (and I am not a coder, mind you) this seems the opposite, i.e. catering for the exceptions and then ending up with an illogical default. Or, in other words, it seems parentA+childrenA1+A2+A3 is treated the same as parentA+parentE+parentG.
Supermarkets may put tomatoes with the vegetables, but they’re still technically a fruit :)Or maybe I’m doing something wrong not understanding the theme logic properly.
But please correct me if I’m wrong. I love to learn :)So long story short:
I solved the highlighting issue when there is no sorting enabled (only main portfolio category chosen for display).
Appreciate any help you can give me to sort out the highlighting menu bottom colour workaround (when sorting is enabled, i.e. subcategories chosen for display).Thanks in advance
RobMarch 11, 2019 at 12:31 am in reply to: Highlighting active parent menu item on subitem opening #1077162Hi,
Spoke too soon about closing the ticket… :)
Creating subcategories in one portfolio parent category I discovered some behaviour which I cannot seem to solve.Code above works fine as long as there are no subcategories, highlights menu parent perfectly.
However, when I add 3 subcategories under MenuItem/PortfolioCat A (A1,A2,A3) in order to have sorting, the behaviour becomes unpredictable:- in the portfolio grid I cannot just choose the parent Category-A, I have to choose to display A+A1+A2+A3, otherwise I get no sorting. Shouldn’t subcategories be included by default?
- however, now I get in the sorting all/subcatA1/subcatA2/subcatA3/catA… what is catA (the parent doing there? There is already ALL…
- If I only choose catA itself for the portfolio grid display, then of course I have proper menu highlighting but no sorting…
I appreciate any help or insight you can give me.
Thanks in advance,
RobMarch 9, 2019 at 6:55 pm in reply to: Highlighting active parent menu item on subitem opening #1076810Solved the issue myself gents. One less request in the flood :-)
Menu now highlights only the proper portfolio-cat/menu-item on opening a single portfolio item.
Here’s how I did it in case someone else meets the same problem:
Child theme functions.php:
// Highlight only proper portfolio CATEGORY/MENU ITEM when single portfolio item open // instead of all portfolio cats being highlighted function add_category_name($classes = '') { if(is_single()) { $category = get_the_terms($post->ID, 'portfolio_entries'); $classes[] = 'category-'.current($category)->slug; } return $classes; } add_filter('body_class','add_category_name');
Child theme Quick CSS:
/* highlight only proper Portfolio menu item (category) when single portfolio item open */ /* hover over "Remove" button of menu item to see the menu IDs */ body.single-portfolio.CATEGORY-SLUG-A .main_menu ul li#menu-item-765 a .avia-menu-text, body.single-portfolio.CATEGORY-SLUG-B .main_menu ul li#menu-item-764 a .avia-menu-text, body.single-portfolio.CATEGORY-SLUG-C .main_menu ul li#menu-item-1038 a .avia-menu-text { color: #719430 !important; } /* highlight bottom border when menu top header */ body.single-portfolio.CATEGORY-SLUG-A .main_menu ul li#menu-item-765 a, body.single-portfolio.CATEGORY-SLUG-B .main_menu ul li#menu-item-764 a, body.single-portfolio.CATEGORY-SLUG-C .main_menu ul li#menu-item-1038 a { border-bottom: 2px solid #719430 !important; }
You can close this request.
Kind regards,
Rob- This reply was modified 5 years, 8 months ago by rob2701. Reason: corrected small typo
March 7, 2019 at 11:04 am in reply to: Highlighting active parent menu item on subitem opening #1075911Hi Vinay,
Yes, like you can read above I figured out everything EXCEPT the portfolio items.
Can you please read above before responding? :-)
As you can see from the site, opening a PORTFOLIO item highlights ALL 3 portfolio menu items, even though the CSS says the colours are restricted to 1 portfolio menu item only…Regards,
RobSo to make it more clear:
Go to menu item “Golden Ratio” (menu item is set to highlight purple)
Open a portfolio item in there
See all 3 portfolio menu items highlighted (blue-orange-purple)
So the other 2 portfolios get highlighted as well, even though they are different portfolio categories on different pages with different menu items and different colors specified.- This reply was modified 5 years, 8 months ago by rob2701. Reason: Added explanation for clarity
March 6, 2019 at 12:21 am in reply to: Highlighting active parent menu item on subitem opening #1075198Link to staging site in private content if you want to have a look. Thanks in advance.
March 3, 2019 at 10:22 pm in reply to: Highlighting active parent menu item on subitem opening #1074053Hi,
I added this CSS below to clarify the problem.
There are 3 different portfolios (= categories/taxonomies).
– Each portfolio has a separate menu item (top level, not nested)
– Each portfolio grid on each page is restricted to display 1 portfolio category
– ALL portfolio items have been assigned a proper category
– ALL portfolio items have proper parent set for breadcrumbsProblem:
Even though the CSS “should” be restricted to each separate menu item ID, still on opening a portfolio item ALL portfolio cats/taxonomies/menu-entries get highlighted…When you can, please help me understand this behaviour, because I’m lost now.
/* -------------------------------------------------------------- */ /* TEST PORTFOLIO ITEM CAT PARENT HIGHLIGHT BELOW */ /* TEMP DIFFFENT COLOURS TO SEE THE DIFFERENCES */ /* Portfolio A - Menu ID = 765 */ /* hover over "Remove" button of menu item to see ID */ /* HIGHLIGHTS ALL PORTFOLIO CATS even while restricted to only this menu item */ /* highlight Portfolio menu item when portfolio item open */ body.single-portfolio .main_menu ul li#menu-item-765 a .avia-menu-text { /* color: #719430 !important; */ color: blue; } /* highlight bottom border when menu top header */ body.single-portfolio .main_menu ul li#menu-item-765 a { /* border-bottom: 2px solid #719430 !important; */ border-bottom: 2px solid blue; } /* Portfolio B - menu ID = 764 */ /* hover over "Remove" button of menu item to see ID */ /* HIGHLIGHTS ALL PORTFOLIO CATS even while restricted to only this menu item */ /* highlight Portfolio menu item when portfolio item open */ body.single-portfolio .main_menu ul li#menu-item-764 a .avia-menu-text { /* color: #719430 !important; */ color: orange!important; } /* highlight bottom border when menu top header */ body.single-portfolio .main_menu ul li#menu-item-764 a { /* border-bottom: 2px solid #719430 !important; */ border-bottom: 2px solid orange; } /* Portfolio C - menu ID = 1038 */ /* hover over "Remove" button of menu item to see ID */ /* HIGHLIGHTS ALL PORTFOLIO CATS even while restricted to only this menu item */ /* highlight Portfolio menu item when portfolio item open */ body.single-portfolio .main_menu ul li#menu-item-1038 a .avia-menu-text { /* color: #719430 !important; */ color: purple; } /* highlight bottom border when menu top header */ body.single-portfolio .main_menu ul li#menu-item-1038 a { /* border-bottom: 2px solid #719430 !important; */ border-bottom: 2px solid purple; }
- This reply was modified 5 years, 8 months ago by rob2701. Reason: corrected some typos
March 3, 2019 at 1:30 pm in reply to: Highlighting active parent menu item on subitem opening #1073941Switching to menu top I see that the breadcrumbs trail does it properly for the portflio items: it shows the portfolio category (parent) of the portfolio item. The menu highlighting however (with the above css) seems to get the grandparent instead, i.e. the whole portfolio, therefore highlighting all portfolio category menu items/taxonomies.
March 1, 2019 at 2:50 pm in reply to: Highlighting active parent menu item on subitem opening #1073209Hi Yigit,
I have the reverse proxy setup to the local devsite running, so it’s now accessible with password from the outside.
Let me know when you have time and are a little less busy, then I can create a temporary login without password link for you.
No hurry though (it’s just a dev site for now)
Rob- This reply was modified 5 years, 9 months ago by rob2701.
March 1, 2019 at 2:08 pm in reply to: Highlighting active parent menu item on subitem opening #1073189Hi Yigit,
Publicly accessible is a bit difficult (site is live on a different URL), I’m just starting to rebuild a local better version to transport afterwards. Still very early stages as I’m still learning how Enfold works.
But I can give you access to the devsite once I get that damn reverse proxy running.The issue is not that difficult to reproduce:
– build two portfolios (categories) en give them each a menu entry on a left sidebar menu
– set each portfolio to display one cat only
– enter some portfolio items in each category
– enter CSS above in child menu style
– open a portfolio item in one of the portfolio menu entries
– see both portfolio menu entries highlightedI understand you are all very busy now, so good luck with that tsunami of requests :-)
This is not that urgent for now.Thanks for your attention so far.
Best regards,
RobMarch 1, 2019 at 12:21 pm in reply to: Highlighting active parent menu item on subitem opening #1073111Hi Yigit,
Unfortunately not yet possible, still working on a local development server and have not yet set up the reverse proxy.
Rob
Hi Ismael,
Thanks for the response and the tip, will look into it. Still getting to know the theme, so one step at a time :-)
Regards,
RobAfter some more testing, thinking and testing:
1.
Changes to the thumbs array in the child theme DO work. I must have done something wrong last time. Sorry.2.
After a bit of thought I’ve decided that its much more efficient for me to do the exact double-size high compression images by hand and then upload.
While it’s nice to have the theme automatically do resizing and cropping, it just results in much heavier images, most of which I will not use anyway..3.
I have commented out all thumbnails sizes in the child theme functions.php therefore..
Thus regenerating thumbs loses all other sizes (except the WP ones for the Media Library).
Going to try just using the full size original and having the theme CSS do downscaling.You can mark this topic as solved. I hope. Unless I’ve made a wrong assumption somwhere down the line :-)
Follow-up:
Same changes made in parent theme’s functions.php > thumbnails sizes become the way I set them
Same changes made in child theme’s functions.php > thumbnails sizes stay what is orginally set in the parent theme and do not change the way they should (respecting the child theme’s functions.php).
Can you help me understand why and provide a solution? Thanks in advance.Hi Enfold Team, I tested this out in hte meantime but am baffled by the results :-)
Can you help me understand?I doubled the thumb sizes in the child theme functions.php:
// – set WordPress compression of image and thumbnails on upload and resize to 90 or higher
// images are manually resized, compressed and optimized BEFORE upload already
// WP compression on images on resize/for thumbnails is standard = 82
add_filter(‘jpeg_quality’, function($arg){return 90;});// remove “responsive images” srcset functionality in WP 4.4 and on from this theme
remove_filter( ‘the_content’, ‘wp_make_content_images_responsive’ );// double-size thumbs for Retina screens and zoom
$avia_config[‘imgSize’][‘widget’] = array(‘width’=>72, ‘height’=>72); // small preview pics eg sidebar news – ORG 36 x 36
$avia_config[‘imgSize’][‘square’] = array(‘width’=>360, ‘height’=>360); // small image for blogs – ORG 180 x 180
$avia_config[‘imgSize’][‘featured’] = array(‘width’=>3000, ‘height’=>860); // images for fullsize pages and fullsize slider – ORG 1500 x 430
$avia_config[‘imgSize’][‘featured_large’] = array(‘width’=>3000, ‘height’=>1260); // images for fullsize pages and fullsize slider – ORG 1500 x 630
$avia_config[‘imgSize’][‘extra_large’] = array(‘width’=>3000, ‘height’=>3000, ‘crop’ => false); // images for fullscrren slider – ORG 1500 x 1500
$avia_config[‘imgSize’][‘portfolio’] = array(‘width’=>990, ‘height’=>800); // images for portfolio entries (2,3 column) – ORG 495 x 400
$avia_config[‘imgSize’][‘portfolio_small’] = array(‘width’=>520, ‘height’=>370); // images for portfolio 4 columns – ORG 260 x 185
$avia_config[‘imgSize’][‘gallery’] = array(‘width’=>1690, ‘height’=>1368); // images for portfolio entries (2,3 column) – ORG 845 x 684
$avia_config[‘imgSize’][‘magazine’] = array(‘width’=>1420, ‘height’=>750); // images for magazines – ORG 710 x 375
$avia_config[‘imgSize’][‘masonry’] = array(‘width’=>1410, ‘height’=>1410, ‘crop’ => false); // images for fullscreen masonry – ORG 705 x 705
$avia_config[‘imgSize’][‘entry_with_sidebar’] = array(‘width’=>1690, ‘height’=>642); // big images for blog and page entries – ORG 845 x 321
$avia_config[‘imgSize’][‘entry_without_sidebar’]= array(‘width’=>2420, ‘height’=>846); // images for fullsize pages and fullsize slider – ORG 1210 x 423
$avia_config[‘imgSize’] = apply_filters(‘avf_modify_thumb_size’, $avia_config[‘imgSize’]);Save and regenerate thumbs.
But then I watch the regenerated thumbnails and they seems to be back to the standard sizes.
These are the currently registered thumbnail sizes, whether they exist for this attachment, and their filenames:thumbnail: 80×80 pixels (cropped to fit)
medium: 300×300 pixels (proportionally resized to fit inside dimensions)
medium_large: 768×0 pixels (proportionally resized to fit inside dimensions)
large: 1030×1030 pixels (proportionally resized to fit inside dimensions)
widget: 36×36 pixels (cropped to fit)
square: 180×180 pixels (cropped to fit)
featured: 1500×430 pixels (cropped to fit)
featured_large: 1500×630 pixels (cropped to fit)
extra_large: 1500×1500 pixels (proportionally resized to fit inside dimensions)
portfolio: 495×400 pixels (cropped to fit)
portfolio_small: 260×185 pixels (cropped to fit)
gallery: 845×684 pixels (cropped to fit)
magazine: 710×375 pixels (cropped to fit)
masonry: 705×705 pixels (proportionally resized to fit inside dimensions)
entry_with_sidebar: 845×321 pixels (cropped to fit)
entry_without_sidebar: 1210×423 pixels (cropped to fit)
shop_thumbnail: 100×100 pixels (cropped to fit)
shop_catalog: 300×300 pixels (cropped to fit)
shop_single: 600×0 pixels (proportionally resized to fit inside dimensions)
woocommerce_thumbnail: 300×300 pixels (cropped to fit)
woocommerce_single: 600×0 pixels (proportionally resized to fit inside dimensions)
woocommerce_gallery_thumbnail: 100×100 pixels (cropped to fit)Thanks in advance for your help (I see you’re a bit flooded with help requests now…)
- This reply was modified 5 years, 9 months ago by rob2701.
-
AuthorPosts