Forum Replies Created
-
Posts
-
Hi,
I know how to fix it by myself via js.
This feedback comes from an accessibility testing company, and they flagged it as an issue. I’m just passing their feedback on to you for free, so you can consider implementing it directly into the core. That way, Enfold can become accessibility-compliant out of the box.
All the best,
PatrickHi Ismael,
I’m talking about the Text-Block.
<section class="av_textblock_section " itemscope="itemscope" itemtype="https://schema.org/CreativeWork"><div class="avia_textblock" itemprop="text"><p>Klicke hier, um Ihren eigenen Text einzufügen</p> </div></section>It’s a section no matter if it’s in a color section or outside.
All the best,
PatrickHi Ismael,
I can’t grant you access, which is why I created the element in a different development environment. I didn’t encounter the error there. I found out that get_terms doesn’t work for taxonomies created via CTP UI. However, taxonomies created via ACF work without any issues. I’ll check if I can find the issue for that.
Best regards,
PatrickCan’t give you access to the project but I tested it on a local clean project and it’s the same issue. So you can test it on your enfold development project too.
Regards,
PatrickHi,
Sorry for the late response.
I don’t want to use string translation for that. I’m using the classic wpml translation und just adding the codeblock element to the translated page. You can try it on your test install. I tried it on different projects and it’s the same bug everywhere.
Regards,
PatrickHi Ismael,
Sorry, I updated the two url’s. We are using the codeblock element and the setting is set to “Display codeblock as code snippet”. I’ve inserted them below the post thumbnail. On the translated page (english page) the tags are removed on the frontend.
Regards,
PatrickHi Rikard,
Thank you. Indeed that helped :)
Maybe you can take that into the core and check if it’s a short or not and handle that case in background so it’s more convenient to just copy and paste the link without the need of changing the url and adding the iframe param.
All the best,
PatrickHi Günter,
Sorry for the late answer.
Thanks for the update. The animation thing is also fixed. Don’t know if it was just an issue on my side or if you did something.
All the best,
PatrickHi Günther,
Maybe an option in the enfold footer settings where you can switch to another markup would be an idea?
But I’m currently not sure if my markup idea is 100% right. I did some research and some sources state that only the socket should be wrapped in <footer> and others state that that the whole footer part can be wrapped. We also had no explicit feedback on the footer in the accessibility check so maybe leave it like it is for now and I reach back when I have more information.
All the best,
PatrickHi Ismael,
It was here https://kriesi.at/support/topic/change-google-maps-styling/#post-1440344
Günter also said it would be a nice feature.
All the best,
PatrickOk, dann hab ich es missverstanden 😅
Yes, the ternary operator should be save for the changes in core and borlabs implementation would be great.
Thanks,
PatrickHallo Günter,
Ich wechsel kurz auf Deutsch weil ich mich da besser Ausdrücken kann :D
Den Code den du mir jetzt geschickt hast ist ja schon der Code den ich so in Verwendung habe und der funktioniert auch. Ismael hatte nur Änderungen in im javascript gemacht (https://kriesi.at/support/topic/change-google-maps-styling/#post-1440336) und ich wollte nur wissen ob ihr diese Änderungen dann in den Core übernehmen könnt mit dem nächsten Update. Kann es sein, dass du https://kriesi.at/support/topic/change-google-maps-styling/#post-1440337 nicht gelesen hast? :D
Oder reden wir gerade aneinander vorbei?
Liebe Grüße
PatrickI got a json file:
[ { "featureType": "all", "elementType": "geometry", "stylers": [ { "hue": "#006cff" } ] }, { "featureType": "all", "elementType": "geometry.fill", "stylers": [ { "hue": "#006cff" } ] }, { "featureType": "all", "elementType": "labels.text", "stylers": [ { "hue": "#006cff" } ] }, { "featureType": "all", "elementType": "labels.icon", "stylers": [ { "hue": "#006cff" } ] }, { "featureType": "landscape.man_made", "elementType": "geometry", "stylers": [ { "hue": "#006cff" }, { "saturation": "100" } ] }, { "featureType": "poi", "elementType": "all", "stylers": [ { "visibility": "off" } ] }, { "featureType": "road", "elementType": "geometry", "stylers": [ { "lightness": 50 }, { "visibility": "simplified" } ] }, { "featureType": "road", "elementType": "labels", "stylers": [ { "visibility": "simplified" } ] }, { "featureType": "transit", "elementType": "labels.text", "stylers": [ { "visibility": "off" } ] } ]I added that first as a string in the filter but it didn’t work. So i changed it to array only. Did I miss something?
Hi Ismael,
I have another question. Is it possible to make the google map to work with borlabs cookie? I added the borlabs cookie shortcode arround the google map via the avf_in_shortcode_handler_prepare_content. If I don’t allow the cookie the map gets nicely blocked. When i press allow the map doesn’t load. I have to refresh the whole page so that the map loads again. Is there a way to fix that?
You can check on the website I sent you before. There are two versions. One is added via a google iframe which works. The second is the enfold element. Would be nice if it work with the enfold element too.
All the best,
PatrickHi Ismael,
Thank you. It works :)
Possible you put the changes into core with the next update?Thanks,
PatrickHi Mike,
I want to add snazzy map styles which is done by setting the styles attribute of google maps.
add_filter( 'avf_gmap_vars', function($maps) { $snazzy = [ [ "featureType" => "all", "elementType" => "geometry", "stylers" => [ [ "hue" => "#006cff" ] ] ], [ "featureType" => "all", "elementType" => "geometry.fill", "stylers" => [ [ "hue" => "#006cff" ] ] ], [ "featureType" => "all", "elementType" => "labels.text", "stylers" => [ [ "hue" => "#006cff" ] ] ], [ "featureType" => "all", "elementType" => "labels.icon", "stylers" => [ [ "hue" => "#006cff" ] ] ], [ "featureType" => "landscape.man_made", "elementType" => "geometry", "stylers" => [ [ "hue" => "#006cff" ], [ "saturation" => "100" ] ] ], [ "featureType" => "poi", "elementType" => "all", "stylers" => [ [ "visibility" => "off" ] ] ], [ "featureType" => "road", "elementType" => "geometry", "stylers" => [ [ "lightness" => 50 ], [ "visibility" => "simplified" ] ] ], [ "featureType" => "road", "elementType" => "labels", "stylers" => [ [ "visibility" => "simplified" ] ] ], [ "featureType" => "transit", "elementType" => "labels.text", "stylers" => [ [ "visibility" => "off" ] ] ] ]; $maps['av_google_map']['av_gmap_0']['styles'] = $snazzy; return $maps; } );When I check window.av_google_map in dev tools everything is there correctly but it seems like it doesn’t get initialized.
It writes the zoom level, etc. so I assumed that I can also set the styles attribute because it’s on the same level when the map gets initialized.
All the best,
PatrickPerfekt, danke.
Jetzt wo ich über meine erste Nachricht drüber lese, habe ich mich glaube ich ein wenig falsch aus ausgedrückt. Was wir benötigen und was unser Code macht ist, dass wir ein Suchfeld in der Iconauswahl hinzugefügt haben um die Auswahl einzuschränken wenn man viele Icons hat. Dafür haben wir eben ein Suchfeld hinzugefügt und dem Icon-HTML noch ein data-attr mit dem Icon-Namen von Fontello gegeben.
Liebe Grüße
PatrickThank you Günter,
Will there be any changes in the future to the font manager stuff because I saw some new classes that you made (aviaFontManagementBase)?
Yes, sure it would help. It was like that before. But it’s enfold code so you would have to change it.
We did a workaround and created a custom class with a public function that extends your class and calls the zip_flatten function. So it’s working for now.
