Anyone?

Has anyone checked my site already?

Hi Victoria,

I’d like to, but I checked the demo again and the shopping cart seems to have the same shopping cart bug… put a product in the cart and the cart icon shows up in the header, go to another page and the cart icon is gone. Only when a new product is put in the cart, the cart icon comes back.

I’ll try disabling plugins and such, but I think the theme itself is the real cause. Also, it used to worked correctly quite a while ago.

Is there something else I can try, except disabling plugins?

Best,

Ralph

Hi Victoria,

Thank you! I just tried the code, but it makes the shopping cart icon visible all the time, even when it’s empty?

Best,

Ralph

Hi Victoria,

I wanted to, but I just checked the following shop demo: https://kriesi.at/themes/enfold/shop/ And it looks like the demo has similar cart icon issues. If you put an item in the cart (on desktop) and browse to other pages, the cart icon is completely gone on desktop. It only comes back once you’re on the cart page itself. I did not yet test this on mobile.

Can you confirm the issue with the demo?

Best,

Ralph

Hey,

It depends… if the theme doesn’t have some kind of fallback like Enfold (Enfold manages to fall back on its dummy widgets), then the theme will simply display no widgets at all. As the Yoast SEO function simply disables ‘widgets_init’ completely.

Anyway, since the conditions of the Yoast SEO function are already pretty tight (it is executed only when an XML URI actually has the word ‘sitemap’ in it), I figured I’m going to leave things as they are. As I think that writing a function that blocks Yoast SEO’s function when an XML URI is 404ing, won’t have much added value. I mean, when the Yoast SEO sitemap feature works correclty, I think the chances of having a user 404 an XML sitemap URI are really slim.

Thanks for pointing me in the direction of Yoast SEO! And please, feel free to consider the issue solved.

Thanks again,

Ralph

Hi,

I found out Yoast SEO is 100% to blame here, not Enfold.

The following Yoast SEO file contains a comment and function which explains everything:

wordpress-seo\inc\class-sitemaps.php

Here are the comment and function:

	/**
	 * Check the current request URI, if we can determine it's probably an XML sitemap, kill loading the widgets
	 */
	public function reduce_query_load() {

		if ( ! isset( $_SERVER['REQUEST_URI'] ) ) {
			return;
		}

		$request_uri = $_SERVER['REQUEST_URI'];
		$extension   = substr( $request_uri, -4 );

		if ( false !== stripos( $request_uri, 'sitemap' ) && ( in_array( $extension, array( '.xml', '.xsl' ) ) ) ) {
			remove_all_actions( 'widgets_init' );
		}
	}

So, when an XML or XSL URI contains the word ‘sitemap’, the above function kills the (custom) widgets and ultimately forces Enfold to load its default/dummy widgets. Change or remove the word ‘sitemap’ in/from the XML URI and Enfold will show a 404 page with the custom / correct widgets.

Anyway, I’ll report the issue to Yoast SEO. Hopefully they’ll add a check to the above function, which checks whether the sitemap URI is actually a 404 page or not… before killing all widgets. That should fix the 404 page widgets issue.

Please consider leaving this topic open, so I can keep you guys posted about any replies from the Yoast SEO devs.

Thank you,

Ralph

Hi Ismael,

Thanks for your reply.

To answer your questions:

Please see the attached links to reproduce the issue. The PHP extension leads to the correct 404 page. The XML extension displays a 404 page, which displays the Pages widget for some reason.

Re the login details: Is their something specific you’d like to check in the dashboard? If yes, perhaps I can look that up for you myself. As I’ve learned the hard way, to never pass on login details :) Though my test setup uses default settings and Yoast SEO and Akismet are the only plugins within its plugin folder. Would you be able to re-create this setup on a WP test setup of your own?

Kind regards,

Ralph

Hey Kriesi Team,

Can someone please help or at least let me know whether you actually feel like this issue is worth solving or not?

I understand you guys are very busy, but I feel like I’m pretty much talking to myself here for almost a week now :) While I think that in some cases, like in my case, having the default 404 page and its Page Widgets expose every single page, is not a really good idea.

Hoping to hear from you!

Thank you,

Ralph

Hello?

Yup, I have Yoast SEO activated… do you think this plugin is causing the issue? If yes, can the issue be solved without deactivating Yoast SEO?

Thank you, Ismael :)

Looking forward to a fixed version of Enfold!

Kind regards,

Ralph

Hi Ismael,

Thanks for your reply!

How can I include those nice code blocks in a post?

Anyway. it’s only a tiny modification to fix the following issue: https://kriesi.at/support/topic/bug-table-headers-applied-incorrectly-on-media-query/#post-423170 It would be great if this issue could be fixed in Enfold’s core code :)

Here’s the requested Pastebin (I only removed the +1 found at line 349): http://pastebin.com/cZdc3Yy2

Please Note: The original / unmodified table.php file causes the same Advanced Layout Builder issue, when the file is loaded via the child theme. Suggesting it’s not caused by the table.php file. The latest Enfold version seems to have issues with loading shortcodes via the child theme, as it used to work just fine with previous versions.

Since I experience this issue on all of my Enfold sites, I believe you should be able to replicate the issue as follows:

1. Activate the Enfold child theme;
2. Use this function in your child theme;
3. Place the original / unmodified table.php in the child theme’s shortcode folder;
4. Edit a page via the Advanced Layout Builder;
5. Open the config settings of a button element, within the page content;
6. Instead of the button config, the table config will pop up.

Hope this helps.

Best,

Ralph

Hi Elliott,

Thanks for your reply!

After following your advice and further investigation, I managed to track down the root of the problem:

I use a custom table.php file for the child theme, and it loads via this function: http://kriesi.at/documentation/enfold/add-new-or-replace-advanced-layout-builder-elements-from-child-theme/

The function used to work fine, but one of the recent Enfold updates must have changed something.

I did a test loading the original table.php file via the child theme, but this also causes the button settings issue. Suggesting it’s not caused by the code within the custom table.php file.

Also, changing the priority of the function from 15 to another number, doesn’t work either.

The only thing that “solves” the button settings issue, is loading the table.php file via the parent theme. Though this isn’t an option for me, as I prefer the customized version to be update-proof.

It seems that, when using the latest Enfold version, loading shortcode files via a child theme, currently causes advanced layout builder issues. Maybe there’s a path structure in table.php, which stops making sense when it loads via the child theme. Which might cause the table settings to open, when trying to configure a button.

Do you perhaps know what might be causing this?

Thank you,

Ralph

Hey Josue,

Because of your post, I dropped the hook idea. Then I tried to call the validation function within js/shortcodes.js via functions.php… this resulted in an epic fail. Finally I had a really simple idea, which actually seems to be doing the trick (only track valid form submissions). I simply added the following check:

if (!$('p').hasClass('error')) {

So the final tracking code looks as follows:

$('.avia_ajax_form button[type="submit"]').on('click', function() {
     if (!$('p').hasClass('error')) {
          ga('send', 'event', 'button', 'click', 'button-3');
     }
});

So far I’ve only tested it with an ‘alert’ and it seems to be working. Could you please let me know what you think of this approach / the check?

Kind regards,

Ralph