Forum Replies Created
-
Posts
-
Hello Mike,
It seems working! (after adding a second close round bracket after the page id in both “if” statements)
It took a while to understand where the error was… ;)))
Thank you so much!Hello,
I found the error. It is my fault.
There was an extra square bracket I left adapting the code.I would like to ask if possible to track different contact forms: I have 2 of those, 1 on the homepage, the other in the contact page, but the function above adds the attribute to all forms.
Thank you!
Hi Ismael,
it has always been in autoplay since I added it in the slider.
And today I checked the Gtmetrix again, in autoplay, and now it is everything back to normal.
Probably it is fault of those of Vimeo that they want to scare off people!!
It took me 2 hours to understand where these files could come from, and and thought the most horrible things.
It was better I was on vacation that day that I checked!!
Thank you anyway for your support and understanding.Hi Ismael,
It’s not wrong at all having an H1, in the contrary, it is essential, but along with a separate description.
For SEO purpose, each page of a website should have at least 1 title (h1) and this should match the page title.
and 1 LONG description (min 300 words). In the description it is a good practice to add also h2 and h3 titles but these can be added in the editor.
So I cannot add a long description in H1 because it will look huge (as happened when it was in the category banner title), and anyway, I need both.
Search engines spiders must recognise titles and description separately.Yes, this is no longer an issue, we fixed it, but in my opinion you should fix both archives to have, by default, an h1 (term title) and separate div for the description, exactly as it appears in the backend. But this is for your interest, not mine anymore. I mean, If I were a theme developer, I would care to make my theme the best theme ever, and with seo in mind, when thinking about the html structure.
Thank you anyway. :)Hello Ismael,
well, I managed to fix it. And I know nothing about php.I know we fixed the title in the previous request. I meant to say that what is set “by default” in the theme is wrong!
That’s the problem. Your theme is not SEO friendly, and you don’t seem to understand that fix this issue should be your priority.
I recommend to add this issue to development task list.Best regards
Hello Ismael,
sorry, yes I forgot to tell you more about this little shortocode, it is just a simple plugin than can be used in the wordpress editor, and works also in category and tag description editor. It toggles a piece of text.
I pointed out that is was not rendered correctly, so I thought there was something wrong with the div nidification.
I checked with more attention the html output and I saw that the wrapping div “term-description” (it is rendered using the woocommerce function woocommerce_taxonomy_archive_description”) is missing, and this happened since you added the code for the tag archive.
This div should appears right after the “woocommrce-notice-wrapper”(compare with live site)Please can you check further more if there is any error?
(I also report that at line 112-115 there is a spelling error “ava” instead of “avia”. I tried to correct but things getting worse.)I don’t know if this is beyond the scope of a support: In Enfold you have a term description in the <H1> tag of the parallax banner and this is very wrong.
I really appreciated your commitment until now to solve this issue in category archive and in tag archive, and hope that you understand the importance of this request. In my opinion this must a priority in the task list to improve Enfold theme.Thank you again!
Hello Ismael,
yes tag archive seems fine but now there is something that is breaking the code in the category archive.
https://dev.officinadeiricordi.it/categoria-prodotto/vetrina-affettatrici-volano-berkel/
A you see the shortcode [expand title=”Leggi di più”] is not rendered, and if you compare the same page in live site, there is a different div nidification.
An there is a paragraph with class “ptag” I created for tag archive, appearing in there (empty)
As I understood these 2 archives (category and tag) differ but, at the same time, share some code and this is quite messy.
I still don’t understand why these 2 archives should differ, would not be better if they could have the same template?
I think this should be an issue with priority for theme fixing.
Anyway, hope that you can help me to fix it :)
Thank you!Hello Ismael,
again your modification is affecting the category archive: no more description and there is a suffix before title.
https://dev.officinadeiricordi.it/categoria-prodotto/vetrina-affettatrici-volano-berkel/
please compare with same page in live site
https://www.officinadeiricordi.it/categoria-prodotto/vetrina-affettatrici-volano-berkel/
Thank youHi Isamel,
Maybe I did not express myself properly.I need both:
– h1 with term title
and below
– paragraph with term description.Same as we did for product category archives.
Thank so much!in functions.php, in child theme named “Officina dei Ricordi”
of cloned websiteYou need to access here:
https://dev.officinadeiricordi.it/wp-adminsee this:
thanks!
Hello Ismael,
I cloned website so you can see the result of your code applied.
Feel free to edit directly and check the result.
Login is the same.I see that you replaced a <p> with <h1> but not the dynamic content: “$term->description” is non correct, it should be maybe “$term->name”.
I tried replacing myself, which it seems ok, but the term description, that should appear below the term name, is now missing.
https://dev.officinadeiricordi.it/tag-prodotto/altre-origini/Your new piece of code affects product category archive and it reverted it as it was at the beginning (CATEGORY suffix and term description missing)
https://dev.officinadeiricordi.it/categoria-prodotto/vetrina-affettatrici-volano-berkel/
Compare with same page in live site:
https://www.officinadeiricordi.it/categoria-prodotto/vetrina-affettatrici-volano-berkel/Have a look also at the code in fuctions.php at row 125 which was added to optimize category archives. I placed in now in upper position, i think you missed it.
Thank you!Hello Ismael,
regarding the description that now is in right place, In added the function below, but the html editor gives me a warning of sintax error and in the debug log file I have this other warning
[14-May-2021 09:08:40 UTC] PHP Warning: call_user_func_array() expects parameter 1 to be a valid callback, function ‘woocommerce_before_shop_loop’ not found or invalid function name in /home/// ADD PRODUCT CATEGORY DESCRIPTION IN RIGHT PLACE
add_action(“after_setup_theme”, function() {
add_action( ‘woocommerce_before_shop_loop’, ‘woocommerce_taxonomy_archive_description’, 10 );
add_action( ‘woocommerce_before_shop_loop’, ‘woocommerce_before_shop_loop’, 10 );
}, 20);Do you see anything wrong?
Thank you!Hello,
that page is the one set for Yith Request a quote plugin. The one I said that I’m having problems with.
Ok I’ll try contact them.
Thank youFinally it seems to work!
And it was quite hard to develop with my knowledge, so thank you.I recommend to take into account to update your theme, because the description in the title banner does not make any sense.
No one would be able to use category products for SEO purpose.hello Ismael,
sorry I’m not a php programmer and I struggle a bit..
The function I need to change should be “avia_woocommerce_parallax_banner”I cannot find corresponding terms in your below lines:
remove_action( ‘avia_after_main_container’, ‘avia_woocommerce_big_cat_banner’, 11 );
remove_action( ‘avia_after_main_container’, ‘avia_woocommerce_shop_banner’, 11 );Should I write:
remove_action( ‘avia_after_main_container’, ‘avia_woocommerce_parallax_banner’, 11 );
add_action(‘avia_after_main_container’,’my_function_avia_woocommerce_parallax_banner’, 11);
function my_function_avia_woocommerce_parallax_banner ( $bg, $overlay, $opacity, $description, $font ) {
// same function but with 1180 row changed?
}
______
For description location, with woocommerce_before_shop_loop, now it is in the right place! :)
thanksHello Ismael,
ok i f I cannot rewrite config.php it must be found a piece of code to be put in child functions.php doing all the following:
1) remove description in title banner
2) adding category title (+ stripping prefix).
3) adding description inside template-shop elementI see that you added description before the template-shop element, when it should be inside.
This creates a full width element pushing down both the template-shop element and the sidebar, which is not correct.
The description should be inside the 2/3 width element, and the sidebar should always adjacent to the title banner.
Please see screenshot.Hope you understand. This is they way it is supposed to be designed.
and hope it is possibile to achieve.
Thank you!Hi Ismael,
i tried your code (which now is removed but you can see screenshot showing the results)
– category title is placed in right placed but it has a suffix “category:” that i would like to remove
– description should be placed in the other “main” below the banner. Both containers have same classes, and maybe this is the reason we don’t understand each other ;).
– I tried putting a folder named config-woocommerce and inside config.php in the child theme, but it does not work,
next Enfold update I will lose the customization, anyway I think this should a obvious thing to change in your theme.Thank you for support!
I saw the option but the result is not making really sense (see link with screenshot)
While now I have description in right place, the title is the shop title and not the category title.
The title should be the one that now is shown as description, which I left very short because used to appear in the banner inside h1.
Thank you!Hello,
thank you to show me how to add the banner in the shop page, it is something I wanted to do for a long time.
But the initial request is another one.
I would like to add a description in product categories.
As you pointed out the description is set in the banner inside an h1 tag,if($description) $output .= ”
<h1>”.$description.”</h1>
“;In there it should be placed the category title, while the description should be placed below inside the “main” element with class “template-shop” and “content”. Just before the product list.
Don’t you think?
This should allow to have category pages optimized for seo
Hope you get my point.
Thank you!Now I see there is another div with the same class, anyway it is a title occupying the width o the central content , excluded the sidebar. It is not full width as the product category (you can see one posted above).
Thanks!Hello,
I think your code is not correct because template-shop is the content below, and the page-title is outside and before it.
What I meant for main.template-shop is actually the container you mention in your css.
ps: sorry the screenshot is of a category page, not of the shop page, that’s why you see a header title. It does no matter since the .template-shop appears in both.
Thank you!I have a further question, how do i display a title header here
https://www.officinadeiricordi.it/shop/
as appears automatically in the product category template?
https://www.officinadeiricordi.it/categoria-prodotto/vetrina-affettatrici-volano-berkel/I mean, the h1 is missing completely and should be present.
Thank you!Hello, in the main.template-shop as a paragraph is possible?
So it will be displayed at the top before the product list.
Thank you!I tried Autoptimize, now I have new issues while font entypo fontello and css seems solved. It never ends…
I let you know soon. ThanksHello, I see nobody has answered yet.
As suggested by thinkjarvis I disabled grouping and minification by breeze, and tried activated the Enfold one.
I have a little improvement probably based on the fact that only Enfold scripts are grouped and other (plugins) are excluded.
Maybe more small files are delivered quicker than a big one.
Anyway the grouped css file is considered as render-blocking along withe other css files of plugins.
I should defer some less important css, any help on doing this? Otherwise any suggestion based on Enfold Performance settings?Thank you!
Thank you for trying anyway!
It seems all very complicate.
Of course I cleared all levels of cache (Breeze, Varnish e keycdn zone).
In GTmetrix waterfall the font now is loaded twice, and the one I added with your snippet is loading much faster! (the one served by cdn).I’ll also try to use combination offered by the theme, hoping it won’t have problems of sync with Varnish Cache on the server.
In the meantime I hope the Enfold team will help me! :)Hello thinkjarvis , thank you for your interest and help!
I added it but it still see the other one loaded, so maybe I need to find a way to “deregister” the original one.
The original one is loaded using css and all other formats are loaded.
Please see the source code of my homepage at line 294Thank you! :)
