Forum Replies Created
-
Posts
-
Thanks for checking, I think I misinterpreted something in Dev Tools, I can see now that the 260 px wide image is being loaded in mobile.
However your research has identified an issue – not the first I’ve come across – with Lighthouse, so that’s useful to know. What I couldn’t reconcile was the massive increases in First and Largest Contentful Paint times in a mobile Lighthouse test, given that when I load the site on my actual smartphone the pages display super quick. You’ve discovered that what causes this is that Lighthouse tests the full image, not the real smaller image, which is just bizarre. Why Google won’t fix this is crazy given their focus on mobile-first indexing.
The Top Story referenced has been moved off the home page. However you can see the same effect I raise on the “Fitting Farewell Finale for Fawley Hill Vintage Steam Festival” story. The ‘full size’ image loaded on mobile is 700 x 467 px but is only 86kb as opposed to 64kb for the 260 x 173 px image. So whilst the difference in image kb sizes is not as pronounced as the Hurricanes story, the fact remains that a 700 x 467 image is being loaded instead of a 260 x 173 px one.
[The site uses 700 x 467 px images as its main size for the individual stories (posts). An image might be uploaded in a larger size than that; Simple Image Sizes and Smush then create the 700 x 467 size (and others), hence that size might be 500kb or less.]
I already have a header widget declared, it displays the date and an email link.
I added the search plugin shortcode into it and it displayed the plugin’s search box, but in the wrong place, which would be OK to allow me to test it out.
However in then looking at the plugin options to see how to customise it, I discovered this in General Options:
Try to replace the theme search with Ajax Search Lite form?
Works with most themes, which use the searchform.php theme file to display their search forms. with an On/Off box.Turning it on, and hey presto, when I click on the magnifying glass in the menu bar, ajax-search-lite kicks into life…
I post this in case anyone else wants to use the plugin and was as initially baffled how to enable it as I was. :-)
Thanks, that works. The box and header_meta element are bigger than they were before the WordPress update, but it looks OK and I can’t be bothered to mess around with it any further. ;-)
I still do wonder though whether this change of element size and code after the update of WordPress should be flagged to your dev team to look at because something has caused the theme to alter its layout/design from what it was before. Case closed!
I would normally say I could probably figure the CSS out but because 6.5.2 has swapped around the order of ‘form’ and ‘phone-info’ in the HTML, and the “id=searchform” line is now outside of the phone-info div, the phone-info CSS definition is not working as it should.
This is the default from layout.css
.phone-info { float: left; - overridden by your float:right directive above font-weight: bold; line-height: 20px; font-size: 11px; padding: 5px 0; }If I change the first padding parameter, then white space around the box does not appear until a setting of “12px 0” and then space is only added beneath the search box, not above. If I increase it further just to test, say “25px 0”, then again no padding is added above.
So please can you have a look at what is going on and advise which CSS elements I now need to target to get control back of the box, e.g. how to get padding to appear above and below the box?
I have now and it moves the search box back to the right but there is still a difference between the sites if you look at them.
The www site has a header_meta height of 47px whilst the dev site is now smaller at 43px.
The www site’s search box has 5px padding top and bottom from the phone-info div element so there is gap within the header_meta element. It’s overall height is 36px.
The dev site’s box now fills the header_meta element despite the phone-info padding being specified (but is apparently ignored), and its height has increased to 42px.
Now I am sure that I could either just leave it as is in its new format or play around with the CSS on the dev site to get it looking as it did (although the HTML code changes might preclude this).
But the big issue here is why has the WP update from 6.4.3 to 6.5.2 changed the layout and code? It’s altered the dimensions of the search box, its location (right to left before your CSS fix) and changed the order of the HTML code for the search box. Surely there’s something here that’s “wrong” and needs looking into/fixing?
I deleted [avia_search] from Phone Number… and the header_meta element shrinks in size. Add it back in and re-save and it reverts back to ‘wrong’ size.
But I’ve just spotted there’s something else going on here. On the dev site under 6.5.2 the HTML is:
<div id="header_meta"... <div class="container"> <form action="http://dev.jacksgallery.co.uk/" id="searchform" method="get" class="">...</form> <div class="phone-info "><div></div></div> </div></div>But on the www site with 6.4.4. the HTML is:
<div id="header_meta"... <div class="container"> <div class="phone-info "> <div><form action="https://www.jacksgallery.co.uk/" id="searchform" method="get" class="">...</form></div> </div> </div></div>I’ve made no changes to layout, content etc yet simply updating WP from 6.4.4 to 6.5.2 changes the HTML code and swaps the order of the ‘form’ and ‘phone-info’ elements. Both code blocks have 4 sets of <div>…</div> so there is no extra div being added.
Sorry to jump on the thread, but I can’t find the “upcoming events content element” in ALB. I can see the code under avia-shortcodes but there’s nothing about events in Enfold documentation either. What is this element and how do I see/try/use it?
Thanks, that worked. Added it to the CSS of the plugin using the font, Performance score on the site is now 99 for Desktop… :-)
I decided to alter the default Medium size (300 x 300) using the function because I use Portfolio, which works. Medium is now 600 x 450 px.
But the issue remains that when setting a Featured Image in the Post there is no selection available to choose the Medium size – Add A New Post / Featured Image only allows the full sized image to be chosen, nothing else.
How do I set the altered Medium size as the FI?
I did the edits with Dreamweaver and uploaded class-avia-combo.php with the error showing, but everything worked fine on the test server, so I did the live site as well, without problems. I also edit class-avia-newsbox.php but that did not report any errors. I can only think as Gunter suggested that there is some character introduced from the recent edits that Dreamweaver has taken offence at because no errors were reported when I edited the 5.5 version back in March. Whatever, all seems OK.
It’s not the comma that causes the error it’s when I hit enter to add a new, empty line. Or if I don’t do that but just paste in my amendment code, it’s the shifting down of all the code below.
The real question is, why is adding some code some 250 lines above causing the function get_post_list to throw an error?
I personally think it should be fixed as I’d have thought you’d want to maintain compatibility with all browsers. You can close it.
Hi,
Not experiencing any issues but thought it worth pointing out… :-)
I thought it also threw up a Lighthouse error but checking again I can’t see one.
Regards
Brilliant, thanks – works a treat!
Out of interest – what’s the reason why
if ($query['category_name'] = 'events';)
doesn’t work?Thanks. Your fix only affects part of the blog text, namely the
- … section at the bottom.
This
#top .all_colors p { font-size: 16px; }is over-riding the 18.4px declaration, and adding !important to .entry-content-wrapper doesn’t work either.
I didn’t realise the smaller font size would narrow the blog container. I’ll have a re-think about the size and layout. Case closed!
Updated to 4.9.2.3 yesterday, no further errors.
Can you explain how tabs.php could throw such an error as there is not a Tab Section on the site’s Pages? Or must there be somewhere in a Post?
I didn’t realise before posting that the site is running 4.8.6.1, so if the code has been updated since that version it might be fixed.
No I cannot reproduce it, in part because the site does not use a Tab Section anywhere that I’m aware of on its Pages (it does have the Combo widget on every page and post, which is tabbed) so it seems strange to me that tabs.php should throw an error. Having said that, the site has 12,800 Posts dating back nearly 10 years, so it’s possible a Tab section was used in the past – but the site Editor cannot remember doing so… Does that code get called by something else?
Also, at the time the error was logged, middle of a Sunday evening, no admin folks were working on the site so however the error was invoked it would have to be by a normal user (unless of course there’s a system process that might cause it).
Sorry can’t offer more insight (but if there’s anything I can do further, please advise).
I’m not sure what is causing the token problem to be honest with you, we haven’t any other users with the same problem. Maybe you could try reaching out to Envato support? They should be in a better position to help you out with that.Just coming back on this last point having tried to engage with Envato Support on this matter over a number of weeks, as @Rikard suggested.
To quote them from various responses I received:
“The Envato Market plugin is maintained – we ensure it works best on the latest version of WordPress and on a modern hosting platform, however we can’t guarantee it’ll work on all WordPress sites or hosting environments.”
and
“Unfortunately, we are no longer actively providing customer support for the Market Plugin, but, as previously stated, we highly advise on common issues that some users encounter in the ‘Help’ tab of the plugin. ”
and
“If you’ve tried all the troubleshooting steps (listed under the Help tab) and you’re still unable to get the Envato Market plugin to work on your site/hosting, at this time, our advice is to remove the Envato Market plugin and instead visit the Downloads section of ThemeForest/CodeCanyon to download the latest version of your items.”My guess on why I was getting the errors I reported from the plugin is that the Enfold auto updater requires 7 tokens to be enabled but the Market plugin is very clear on only enabling 3, and no more.
Whatever, given Envato’s “no support” stance on the plugin and the fact they’re not even willing to look at the problem, I’ve uninstalled the plugin. Case closed!
Hi,
In toggles.php I change the <p> class of the tab headings to <h2> for better SEO e.g.
Lines 853-858 Change all instances of p.toggler to h2.toggler Line 1074 Change p to h2 "<h2 data-fake-id='# Line 1080 Change p to h2 '</h2>';I can see from the latest toggles.php code that this has been changed so I need to update my ‘shortcode’ alterations. Can I still make these changes if I figure out the new code? I’d better check the other ones I alter as well.
Can I turn debugging off?
Assuming the shortcodes were the cause of the critical error upon trying to update, what do you think is creating the errors on the token? If I try to Save Changes in Envato Market now I still get the ‘Incorrect token permissions’ errors yet it validates correctly in Theme Options/Update.
Hi Yigit,
The site was down. Appearance > Themes said “The active theme is broken. Reverting to the default theme.” It says Enfold Child is Active but then below it says:
Broken Themes The following themes are installed but incomplete. Name Description enfold Stylesheet is missing. DeleteI’ve renamed ‘enfold’ to ‘enfold-4-9’, uploaded 4.8.6.1 and it’s live again.
Options > Theme Update is also now showing there is a new version (4.9) available.
Debugging is active plus define( ‘WP_DEBUG_LOG’, true );
I have hopefully fixed the FTP problem. The hosting provider said that whilst permissions looked OK to you, their system sometimes overrides this after I’d set you up as a new user (he didn’t say why) but he has reset it so you should be fine now.
Sorry, been busy elsewhere…
Updating the live site via Updates > Themes, because 4.9 was showing as available, and using the old, original token that validated in Theme Update, crashed the site with the “critical error”. I had to FTP version 4.8.6.1 back up to /themes to get the site back online.
After this, back on 4.8.6.1, I could validate this original token in Enfold Child > Theme Update – but the Manual Update check there failed to find 4.9 and Envato Market also fails that token with:
Incorrect token permissions, please generate another token or fix the permissions on the existing token. Please ensure only the following permissions are enabled: View and search Envato sites Download your purchased items List purchases you've made Dismiss this notice. Additional Error Details: Found too many permissions on token.. sale:verify []So I tried the new token I generated a few days ago. Theme Update again validates the token but Envato Market fails it as above.
I then created another new token today. This again validates in Theme Update but again no Manual Update shows up. When I go into Envato Market and add this newest token, Save Changes, I get the error again as above (Incorrect token permissions). But if I go to the Themes tab, it lists Enfold Version 4.9 as available. I have not tried clicking Activate on this for fear of crashing the site again.
One last try: I did the FTP upload of 4.9 into /themes, did the directory re-name as I’ve always previously done – and the site crashed with ‘critical error’. So reverted back to 4.8.6.1.
So it appears both sites are now well and truly messed up, and cannot be updated.
Why is Enfold Child > Theme Update validating all three tokens but Envato Market fails all three? This must be why the auto update is failing but doesn’t explain why the FTP upgrade is also failing.
What next?
- … section at the bottom.
