Forum Replies Created
-
AuthorPosts
-
It’s not the comma that causes the error it’s when I hit enter to add a new, empty line. Or if I don’t do that but just paste in my amendment code, it’s the shifting down of all the code below.
The real question is, why is adding some code some 250 lines above causing the function get_post_list to throw an error?
I personally think it should be fixed as I’d have thought you’d want to maintain compatibility with all browsers. You can close it.
Hi,
Not experiencing any issues but thought it worth pointing out… :-)
I thought it also threw up a Lighthouse error but checking again I can’t see one.
Regards
Brilliant, thanks – works a treat!
Out of interest – what’s the reason why
if ($query['category_name'] = 'events';)
doesn’t work?Thanks, I’ll give them a go.
Thanks. Your fix only affects part of the blog text, namely the
- … section at the bottom.
This
#top .all_colors p { font-size: 16px; }
is over-riding the 18.4px declaration, and adding !important to .entry-content-wrapper doesn’t work either.
I didn’t realise the smaller font size would narrow the blog container. I’ll have a re-think about the size and layout. Case closed!
Updated to 4.9.2.3 yesterday, no further errors.
Can you explain how tabs.php could throw such an error as there is not a Tab Section on the site’s Pages? Or must there be somewhere in a Post?
I didn’t realise before posting that the site is running 4.8.6.1, so if the code has been updated since that version it might be fixed.
No I cannot reproduce it, in part because the site does not use a Tab Section anywhere that I’m aware of on its Pages (it does have the Combo widget on every page and post, which is tabbed) so it seems strange to me that tabs.php should throw an error. Having said that, the site has 12,800 Posts dating back nearly 10 years, so it’s possible a Tab section was used in the past – but the site Editor cannot remember doing so… Does that code get called by something else?
Also, at the time the error was logged, middle of a Sunday evening, no admin folks were working on the site so however the error was invoked it would have to be by a normal user (unless of course there’s a system process that might cause it).
Sorry can’t offer more insight (but if there’s anything I can do further, please advise).
I’m not sure what is causing the token problem to be honest with you, we haven’t any other users with the same problem. Maybe you could try reaching out to Envato support? They should be in a better position to help you out with that.
Just coming back on this last point having tried to engage with Envato Support on this matter over a number of weeks, as @Rikard suggested.
To quote them from various responses I received:
“The Envato Market plugin is maintained – we ensure it works best on the latest version of WordPress and on a modern hosting platform, however we can’t guarantee it’ll work on all WordPress sites or hosting environments.”
and
“Unfortunately, we are no longer actively providing customer support for the Market Plugin, but, as previously stated, we highly advise on common issues that some users encounter in the ‘Help’ tab of the plugin. ”
and
“If you’ve tried all the troubleshooting steps (listed under the Help tab) and you’re still unable to get the Envato Market plugin to work on your site/hosting, at this time, our advice is to remove the Envato Market plugin and instead visit the Downloads section of ThemeForest/CodeCanyon to download the latest version of your items.”My guess on why I was getting the errors I reported from the plugin is that the Enfold auto updater requires 7 tokens to be enabled but the Market plugin is very clear on only enabling 3, and no more.
Whatever, given Envato’s “no support” stance on the plugin and the fact they’re not even willing to look at the problem, I’ve uninstalled the plugin. Case closed!
Got it, thanks. Closed!
Hi,
In toggles.php I change the <p> class of the tab headings to <h2> for better SEO e.g.
Lines 853-858 Change all instances of p.toggler to h2.toggler Line 1074 Change p to h2 "<h2 data-fake-id='# Line 1080 Change p to h2 '</h2>';
I can see from the latest toggles.php code that this has been changed so I need to update my ‘shortcode’ alterations. Can I still make these changes if I figure out the new code? I’d better check the other ones I alter as well.
Can I turn debugging off?
Assuming the shortcodes were the cause of the critical error upon trying to update, what do you think is creating the errors on the token? If I try to Save Changes in Envato Market now I still get the ‘Incorrect token permissions’ errors yet it validates correctly in Theme Options/Update.
Hi Yigit,
The site was down. Appearance > Themes said “The active theme is broken. Reverting to the default theme.” It says Enfold Child is Active but then below it says:
Broken Themes The following themes are installed but incomplete. Name Description enfold Stylesheet is missing. Delete
I’ve renamed ‘enfold’ to ‘enfold-4-9’, uploaded 4.8.6.1 and it’s live again.
Options > Theme Update is also now showing there is a new version (4.9) available.
Debugging is active plus define( ‘WP_DEBUG_LOG’, true );
I have hopefully fixed the FTP problem. The hosting provider said that whilst permissions looked OK to you, their system sometimes overrides this after I’d set you up as a new user (he didn’t say why) but he has reset it so you should be fine now.
Details attached.
Sorry, been busy elsewhere…
Updating the live site via Updates > Themes, because 4.9 was showing as available, and using the old, original token that validated in Theme Update, crashed the site with the “critical error”. I had to FTP version 4.8.6.1 back up to /themes to get the site back online.
After this, back on 4.8.6.1, I could validate this original token in Enfold Child > Theme Update – but the Manual Update check there failed to find 4.9 and Envato Market also fails that token with:
Incorrect token permissions, please generate another token or fix the permissions on the existing token. Please ensure only the following permissions are enabled: View and search Envato sites Download your purchased items List purchases you've made Dismiss this notice. Additional Error Details: Found too many permissions on token.. sale:verify []
So I tried the new token I generated a few days ago. Theme Update again validates the token but Envato Market fails it as above.
I then created another new token today. This again validates in Theme Update but again no Manual Update shows up. When I go into Envato Market and add this newest token, Save Changes, I get the error again as above (Incorrect token permissions). But if I go to the Themes tab, it lists Enfold Version 4.9 as available. I have not tried clicking Activate on this for fear of crashing the site again.
One last try: I did the FTP upload of 4.9 into /themes, did the directory re-name as I’ve always previously done – and the site crashed with ‘critical error’. So reverted back to 4.8.6.1.
So it appears both sites are now well and truly messed up, and cannot be updated.
Why is Enfold Child > Theme Update validating all three tokens but Envato Market fails all three? This must be why the auto update is failing but doesn’t explain why the FTP upgrade is also failing.
What next?
I installed the plugin. Existing token on the site yields:
Incorrect token permissions, please generate another token or fix the permissions on the existing token. Please ensure only the following permissions are enabled: View and search Envato sites Download your purchased items List purchases you've made Additional Error Details: Found too many permissions on token.. sale:verify []
I created a new token as per plugin instructions, entered it into Envato Market, Save Changes and get:
Your OAuth Personal Token has been verified.
When I then enter this new token into Theme Options and Revalidate, I get:
We checked the token on 2022/03/02 15:59 and we were able to connect to Envato and could access the following information: Your purchases Username could not be accessed (needed for your information only) E-Mail could not be accessed (needed for your information only) Following errors occurred: username Errorcode 403 returned by Envato: Forbidden: - code: not_authenticated email Errorcode 403 returned by Envato: Forbidden: - code: not_authenticated
The old token in https://build.envato.com/my-apps#tokens had this:
This token has access to: View and search Envato sites View your Envato Account username View your email address Download your purchased items Verify purchases of your items List purchases you've made
I then found this page: https://kriesi.at/documentation/enfold/theme-registration/#toggle-id-5, which says the token also needs “View the user’s account profile details”. So I added the other 3 from above and this. The token then validates.
Before moving on, this raises an issue.
The default plugin setting states you only need 3 permissions (as did the error message after I’d first installed the plugin):
View and search Envato sites Download your purchased items List purchases you've made
The existing tokens (and I have another licence/token as well as this site we are discussing) all have the 6 permissions above. But creating a new token with 3 or 6 doesn’t validate. I had to add “view account profile” as well. Why does the plugin say you only need 3, the old tokens have 6, but you actually (apparently) now need 7? Have Envato changed the rules/guidance? Whatever, if Enfold needs the 7 then maybe you might want to consider highlighting a link to that #toggle-id-5 page in a sticky post at the top of the forum?
All that aside, I now have a nice, shiny bright new token that validates on the test site. But the manual update check still fails to find 4.9, and when I do the FTP directory re-name to update, I get the critical error again and the site is dead.
Please note that the live site, which has the original token that failed on the test site, has found the 4.9 update (it is also on 4.8.6.1) and I have successfully re-validated that original token this afternoon. (The test site is set up as a sub-domain of the live site.)
I know you offered to update the theme for me but I’d like to get to the bottom of why this token & site update has suddenly stopped working after all these years. Next steps?
Please close, thank you.
Thanks.
Hi Ismael,
1. The default comment field has a corresponding label above it.
<label for=”comment”>Comment <span class=”required” aria-hidden=”true”>*</span></label>
I know, I can see it – but this is the crux of the problem. We can both see the label code is present but Lighthouse says it isn’t, and is generating an error.2. Please note that the comment field is a default WordPress element, it is not generated by the theme.
I did not realise this – please see my last comment below.3. Are you sure that the textarea that the plugin generates has been removed from the page when you run the test again?
Yes, definitely gone, also checked in Firefox. See https://imgur.com/gallery/ZkOGgrv – this is Dev Tools Elements after I have clicked on the hyperlink from Failing Elements > textarea#comment, showing what Lighthouse thinks is the (shaded) line of code that generates the “Form elements do not have associated labels” error.Now… given your reply to 2, whilst I appreciate your time and effort to assist with this, isn’t this something that I should (now) be raising on a WordPress forum? You having pointed out it’s a default WP element that is causing the error, and not an Enfold element. Or rather, I think it’s Lighthouse that has a bug here but it’s a WP element it’s failing on. Perhaps I should be getting them to address the issue with Google?
Thanks, hopefully they’ll take note. Case closed.
I use Antispam Bee on that site. If I deactivate it then the line
<textarea id="a941a68d79d5a981230e419af11a14d5" aria-hidden="true" name="comment" autocomplete="new-password" style="padding:0 !important;clip:rect(1px, 1px, 1px, 1px) !important;position:absolute !important;white-space:nowrap !important;height:1px !important;width:1px !important;overflow:hidden !important;" tabindex="-1"></textarea>
disappears from the page.However… without that plugin active, and after a hard cache refresh, I still get the “Form elements do not have associated labels” error from Lighthouse, specifying this line:
<textarea id="comment" name="comment" cols="45" rows="8" maxlength="65525" required="required"></textarea>
which is the Enfold comment box.If I re-enable the plugin the Antispam code re-appears. If I run Lighthouse again, I still get the ‘no label’ error. When Lighthouse highlights what’s causing the error, it states:
Failing Elements textarea#comment
with a small thumbnail of the comment box. The ‘textarea#comment’ is a hyperlink to the code it thinks is a problem. If you click on that hyperlink, you get transferred to the Elements tab of Dev Tools, wherein the HTML code is displayed. It then automatically goes to the line of ‘problem’ code and highlights it in light blue. Guess what? It’s not the Antispam Bee line that’s highlighted, but the Enfold comment box, e.g.
<textarea autocomplete="new-password" id="comment" name="ac76510e77" cols="45" rows="8" maxlength="65525" required="required"></textarea>
So Lighthouse is saying it’s not Antispam Bee causing the error, but Enfold. When Lighthouse detects multiple errors on a page, e.g. ALT tags missing, it lists out all failing instances under Failing Elements. The only element ‘failing’ here is the Enfold textarea.
When you say “We have checked the comment form on a fresh installation without a plugin and we didn’t find the same hidden textare below the actual comment field“, yes the hidden textarea won’t be there – but did you run Lighthouse on that page? I suspect if you did, you’d get the ‘no label’ error.
Or you can try it yourself on the page (or any page on my site) that I referenced in the first post.
Given your last reply, I’m at a loss to understand what’s going on here. Another Lighthouse bug perhaps?
I agree the UL is there but shouldn’t you or the devs report this to Google as it’s clearly a bug in Lighthouse yet it’s coming across as an Enfold problem, when it’s not. I’m sure other users will flag this to you in future and I’d have thought you might want to get the issue fixed at source to prevent repeated questions on it.
“… the lighthouse warning can be ignored.”
But it’s flagging this as a red triangle “high priority to fix” error and it is downgrading the Accessibility score.
Whilst you say the element doesn’t require a label, could one not be added so that the error goes away? It seems a simple fix for the devs to do and I assume it wouldn’t ‘hurt’ or cause a problem, with the benefit of helping the score improve.
I see now from other posts that you have changed your long standing policy of free lifetime support. I know all about Envato’s policy but back in 2015 this post explained the situation: https://kriesi.at/support/topic/envato-support-policy-2/#post-500677.
Are you now saying that Envato have forced @Kriesi to change his previous position of free lifetime support, even after Envato had changed their rules?
If so, do you not think it would be polite and a courtesy to long standing customers like me and many, many others to have posted a sticky post on the support forum explaining what has changed rather than letting everyone find out the hard way, and as a consequence have angry users post multiple questions in this forum, that you and other mods then have to waste time answering???
September 27, 2021 at 7:18 pm in reply to: The Cookie bar keeps on coming back at multiple visits #1322535@Jan_FtFA : one of my sites suddenly started doing this today after I updated to WP 5.8.1. (Note for mods – it is still running Enfold 4.8.6.1)
I went into Chrome settings and deleted all the cookies for that site – and the problem went away.
I did not get the time delay issue you report. When the cookie bar was re-appearing on every page even after clicking ‘OK’, the bar re-appeared on every new page selected, all the time.
PS. I experienced the same problem on another Enfold site (which took a couple of attempts at deleting cookies, but eventually the problem went away) but did not get it on a 3rd. So who knows what’s going on…
Thank you @Guenni007
Thanks, I’ll give it a go!
One further question though – what does the number 10 signify in the add_action (or add_filter)?
I’ve seen different numbers in some functions (but not others) but never understood what it is, why the number varies or why some functions have one number, some have two, others none. Hope you can shed some light!
@Ismael – I have not considered hooks and have never created a PHP function from scratch, although I am quite adept at investigating & hacking PHP code modules to get what I want… :-)
The day and date is written into a custom widget area called ‘header’ that the theme assigns an id of ‘custom_html-7’, and I position it in the header via my child style.css, e.g.
#header #custom_html-7 { left: 50%; padding-top: 0px; etc
Are there any code examples of using the two hooks you mention that might give me a head start in trying to figure something out? I can’t see anything in Enfold Documentation.
Excellent, thank you – it works.
The validation process in Search Console fails on the errors I get. I found similar breadcrumb errors reported on other themes via a Google search and those theme authors acknowledged a problem in their themes and fixed them. But it “appears” Enfold does not know the cause of these errors.
So until the cause of the errors is fixed, we are stuck with. :-(
I know I shouldn’t jump in on someone else’s thread but @swisstraveler’s issue is the same as mine here: https://kriesi.at/support/topic/search-console-has-identified-that-your-site-is-affected-by-2-breadcrumbs-issues/ – which as you can see @Rikard had to leave unresolved.
My site is today reporting 4 pages with both ‘Either “name” or “item.name” should be specified’ and ‘Missing field “id”‘ errors.
There is something going on here…
- … section at the bottom.
-
AuthorPosts