Hi @BigBatT,

Added files to the core and https://github.com/KriesiMedia/enfold-language-files. Thanks for your contributions!

Best regards,
Günter

Hi,

Thanks for checking and your time.

Using the index seems to be server depending:

https://planetscale.com/learn/courses/mysql-for-developers/indexes/indexing-for-wildcard-searches

I removed the order by clause and the query time dropped dramatically on my install.

Could you try to remove the following line from ..\enfold\config-templatebuilder\avia-template-builder\php\class-dynamic-content.php

around line 1410:

$sql .= 'ORDER BY meta_key ';

and can you please check with and without limit ?

Thank you very much in advance.

Best regards,
Günter

Hi,

I checked the query on my localhost:

Can you check that meta_key is an index on your install and maybe also try to reindex it. Sounds a bit strange that an SQL Server does not use an index.

If you do not need the custom field feature added with 6.0 disable it in theme option Enfold->Template Builder-> Custom Layout And Dynamic Content.

Our query is based on the WP query in ..\wp-admin\includes\template.php function meta_form() which fills the custom fields when editing a post. This query is limited to 30 entries by default.

There are also several filters for our query (see ..\config-templatebuilder\avia-template-builder\php\class-dynamic-content.php function get_default_custom_fields() ) – even to shortcut it or to limit:

$limit = apply_filters( 'avf_query_default_custom_fields_limit', 0 );

But we offer the custom fields in dropdowns to be selected by users – not showing all might result in being not user friendly. There is much depending on your application.

If you know exactly which custom fields are needed you can return this set hardcoded with filter:

			/**
			 * Allow to short circuit the query against post meta table.
			 * Return an array filled with the keys.
			 * Query for _ only might get much longer than other queries
			 *
			 * @since 6.0
			 * @param array|null $keys
			 * @param bool $filter
			 * @param int $limit
			 * @return array|null
			 */
			$wp_custom_fields = apply_filters( 'avf_before_query_wp_default_custom_fields', null, $filter, $limit );

Best regards,
Günter

Hi Roel,

Thank you for pointing at this.

First I checked the database structure of WP post meta table.

meta_key field is an index in my install (6.5.3). This means the query you show is a simple query against an index and this means that is a very fast query – even in a database that contains million of entries in a table.

Please check with your hoster (datatbase hoster) why this query is so slow in your case. Could be your database is broken somehow or allocated memory is too small.

Nevertheless I improved the query logic to remove it from frontend for next release 6.0.1.

If you want to test the fixes please replace the 2 following files:

..\config-acf\class-avia-acf.php
..\config-templatebuilder\avia-template-builder\php\class-dynamic-content.php

with

https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/enfold_6_0/config-acf/class-avia-acf.php
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/enfold_6_0/config-templatebuilder/avia-template-builder/php/class-dynamic-content.php

Best regards,
Günter

Hi,

@Guenni007

I forgot to mention that when using HTML markup in toggle title the open toggle title is ignored (there is a message in the description text). This is a limitation – but I think something to live with.

In your test site https://webers-testseite.de/accordion it works as it should – with fixed toggle title as it did before 6.0 where we added the open toggle title option.

@conflock

Did you clear browser cache? See example of @Guenni007.

Can you give me a access to a staging site with full WP admin access where I can see why it is not working ?

Best regards,
Günter

Hi Günter,

Beispiele:

https://github.com/KriesiMedia/enfold-library/blob/master/actions%20and%20filters/Dynamic%20CSS/avf_dynamic_css_after_vars.php

https://github.com/KriesiMedia/enfold-library/blob/master/actions%20and%20filters/Dynamic%20CSS/avf_dynamic_css_additional_vars.php

Best regards,
Günter

Hi Martin,

Alles klar. Macht Sinn.

Ich hab es einmal zu den feature requests hinzugefügt, damit ich es nicht vergesse: https://github.com/KriesiMedia/Enfold-Feature-Requests/issues/109

LG,
Günter

Hi Patrick,

thank you for your feedback.

According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/main main tag should be unique and should not contain parts like sidebar, footer, …

Doing a quick check I see that changing div id=”main” to main id=”main” includes footer and sidebar. And various page templates already include the main tag resulting in multiple main tags. And also page as footer setting might add main tags.

I do not see a quick solution for that at the moment – but I will keep an eye on it.

Best regards,
Günter

Hey Patrick,

Thank you for pointing at the buttons. Missed it.

I added aria-label to the 3 ALB buttons and custom field to Button Title Attribute option.

I will check the HTML “main” tag. That should be no problem. I will also have a look into footer tag – but I’m afraid the risk of breaking existing sites is rather high.

And we appreciate your help to improve accessibility. We will try our best to implement it.

Best regards,
Günter

Hi,

Best regards,
Günter

Hey Blatze,

Danke dafür. Hab für die nächste Release “Ohne Titel und ohne Textauschnitt” genommen.

Die Übersetzungen werden von Usern bereitgestellt.

Es gibt ein Github Repository: https://github.com/KriesiMedia/enfold-language-files

Einige User warten die language files regelmässig – wir senden Ihnen dann vor einer neuen Release die letzte Version damit Sie die files übersetzen können und wir diese bereits in der Release mitveröffentlichen können (z.B. Italienisch, Holländisch, Französisch).

Wir sind dankbar für jede Unterstützung bei den Übersetzungen.

Liebe Grüsse,
Günter

Hi,

In der Function shortcode_handler() des Elementes, dort ist

$output .=		$slideshow->html();

und das wird dann nach oben weitergereicht.

Ich würde einmal raten, eine clean staging site aufzusetzen, ein paar Bilder und dann testen ohne customizations ob es geht.
Vielleicht ist irgendwo in der DB ein Problem nach einem WPML update. Wäre vielleicht auch mit WPML abzuklären, ob die dann eine Idee haben.

Best regards,
Günter

Hi,

Removed the filter and added an option for each toggle.

Best regards,
Günter

Hi!

Added with filter to 6.0

Regards,
Günter

Hey imc-html,

Verwendet Ihr die letzte Version von Enfold 5.7.1 ? Wenn nicht, bitte einmal updaten (wenn möglich zuerst auf einer Staging Site testen).

Die “Initialisierung” der Bilder erfolgt in ..\config-templatebuilder\avia-shortcode-helpers\class-avia-slideshow.php in function set_slides( $ids ) mit

get_posts() und diese Funktion wird von WPML unterstützt, um die Bilder ID zu übersetzen.

Voraussetzung dafür ist, dass die Bilder auch mit WPML übersetzt sind. Könnt Ihr das einmal überprüfen?

Best regards,
Günter