Forum Replies Created
-
Posts
-
Hi Patrick,
Thank you for your feedback.
I did not change anything with animation. Mayby some browser/server cache issue.
Enjoy the theme and have a great day.
I will close this topic – feel free to open a new one when you need further assistance or find other bugs.
Best regards,
GünterHi Tim,
Thank you for the credentials.
Having a look into it – you are having a lot of customizations, a lot of plugins and also modifications to the image sizes defined.
E.g. 1500*0 – Featured Thin (added by theme), 1700*0 – Fullscreen Sections/Sliders (added by theme), …
In core it is: 1500*430 – Featured Thin (added by theme), 1500*1500 – Fullscreen Sections/Sliders (added by theme)
We are using core WP functions for creating the responsive scrset and size – no idea what *0 causes behind the scene in WP core.
Also it is a bit strange that when no image is selected for a category we get the last image added returned by a core WP function:
$attachment_id = avia_get_woocommerce_term_meta( $term->term_id, 'thumbnail_id' );calls
get_term_meta( $term_id, $key, $single )The following functions are involved in handling the banner for shop page and category pages in file ..\config-woocommerce\config.php:
avia_woocommerce_overview_banner_image()
avia_woocommerce_big_cat_banner()
avia_woocommerce_shop_banner()
avia_woocommerce_parallax_banner()The code in the functions is pretty straight and easy to understand.
What I would suggest you can do:
– To make 100% sure we do not have a bug in our core (we tested it carefully, but we might have missed something) create a clean install with Enfold and WooCommerce, add a few images and categories and check, if you get it to run as you want it – using filters if necessary (we can add additional filters if needed to core)
– Then you need to dig into your customizationed site and try to figure out, what breaks our code
I know this answer does not satisfy but digging into your code cannot be done in a few minutes.
If you need anything added to code or anything I can assist you let me know.
Best regards,
GünterHi Tim,
Theme option:
Did you enable “Display responsive banner image …” and for uploaded image you have to select the desired size in media library.
There is filter ‘avf_woocommerce_default_banner_image_size’ (..\config-woocommerce\config.php line 1694) – you can return a registered image size
I cannot reproduce the problem with the categories.
Do you have a staging site where I can see it – and with backend access to check option settings and theme editor ?
Best regards,
GünterHi,
Glad we found the solution and we could help you.
Enjoy the theme and have a great day.
Best regards,
GünterHi,
In the dev console of FF and Chrome I added the css above in the element – this makes the button clickable but leaves the video playing.
Did you save theme options after adding the CSS to rebuild the merged files and cleared browser cache?
Alternative disable merging first and check.
Best regards,
GünterHey reqonsult,
Can you try to add the following CSS code:
#top .av-video-slide.av-video-playing a.avia-button { pointer-events: all; }It might be necessary to add !important.
Best regards,
GünterHey ofeuillet,
I answered in your other topic: https://kriesi.at/support/topic/accordion-header-issue-since-enfold-6-01/
I will close this.
Best regards,
GünterHey ofeuillet,
Thank you for using Enfold and for reporting this.
I missed a check for that.
Will be fixed in next release 6.0.3.
If you want to test the fix please update the 2 files
..\config-templatebuilder\avia-shortcodes\toggles\toggles.js
..\config-templatebuilder\avia-shortcodes\toggles\toggles.min.jswith
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_6_0_2/config-templatebuilder/avia-shortcodes/toggles/toggles.js
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/Enfold_6_0_2/config-templatebuilder/avia-shortcodes/toggles/toggles.min.jsDo not forget to make a backup for a fallback and save theme options in case you use merged js.
Best regards,
GünterHey Patrick,
Thank you for reporting this.
I updated aria-hidden=”false” for ALB icons containing a link for 6.0.2.
If you want to test it before please replace
../config-templatebuilder/avia-shortcodes/icon/icon.php
with
There’s also still an animation
I cannot reproduce this. If you have a staging site can we have a link to it where we can see it and we can also get access to the underlying shortcode.
Thank you in advance.
Best regards,
GünterHi @BigBatT,
Added files to the core and https://github.com/KriesiMedia/enfold-language-files. Thanks for your contributions!
Best regards,
GünterHi,
Thank you very much for checking and your help.
I will add a fix to 6.0.1 and we will release it very soon.
Have a great day – and thank you for using Enfold.
Best regards,
GünterHi,
Thanks for checking and your time.
Using the index seems to be server depending:
https://planetscale.com/learn/courses/mysql-for-developers/indexes/indexing-for-wildcard-searches
I removed the order by clause and the query time dropped dramatically on my install.
Could you try to remove the following line from ..\enfold\config-templatebuilder\avia-template-builder\php\class-dynamic-content.php
around line 1410:
$sql .= 'ORDER BY meta_key ';and can you please check with and without limit ?
Thank you very much in advance.
Best regards,
GünterHi,
Thank you for posting the temporary solution.
As I do not have a test environment with such many posts: could you please check if adding a limit (as WP does) would help?
e.g. like
add_filter('avf_query_default_custom_fields_limit', function($limit) { return 300; });Thank you for your help in advance.
Best regards,
GünterHi,
I checked the query on my localhost:
Can you check that meta_key is an index on your install and maybe also try to reindex it. Sounds a bit strange that an SQL Server does not use an index.
If you do not need the custom field feature added with 6.0 disable it in theme option Enfold->Template Builder-> Custom Layout And Dynamic Content.
Our query is based on the WP query in ..\wp-admin\includes\template.php function meta_form() which fills the custom fields when editing a post. This query is limited to 30 entries by default.
There are also several filters for our query (see ..\config-templatebuilder\avia-template-builder\php\class-dynamic-content.php function get_default_custom_fields() ) – even to shortcut it or to limit:
$limit = apply_filters( 'avf_query_default_custom_fields_limit', 0 );But we offer the custom fields in dropdowns to be selected by users – not showing all might result in being not user friendly. There is much depending on your application.
If you know exactly which custom fields are needed you can return this set hardcoded with filter:
/** * Allow to short circuit the query against post meta table. * Return an array filled with the keys. * Query for _ only might get much longer than other queries * * @since 6.0 * @param array|null $keys * @param bool $filter * @param int $limit * @return array|null */ $wp_custom_fields = apply_filters( 'avf_before_query_wp_default_custom_fields', null, $filter, $limit );Best regards,
GünterHey roelvanleuken,
Thank you for pointing at this – I already answered your contact form request yesterday:
First I checked the database structure of WP post meta table.
meta_key field is an index in my install (6.5.3). This means the query you show is a simple query against an index and this means that is a very fast query – even in a database that contains million of entries in a table.
Please check with your hoster (datatbase hoster) why this query is so slow in your case. Could be your database is broken somehow or allocated memory is too small.
Nevertheless I improved the query logic to remove it from frontend for next release 6.0.1.
If you want to test the fixes please replace the 2 following files:
..\config-acf\class-avia-acf.php
..\config-templatebuilder\avia-template-builder\php\class-dynamic-content.phpwith
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/enfold_6_0/config-acf/class-avia-acf.php
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/enfold_6_0/config-templatebuilder/avia-template-builder/php/class-dynamic-content.phpBest regards,
GünterHi Roel,
Thank you for pointing at this.
First I checked the database structure of WP post meta table.
meta_key field is an index in my install (6.5.3). This means the query you show is a simple query against an index and this means that is a very fast query – even in a database that contains million of entries in a table.
Please check with your hoster (datatbase hoster) why this query is so slow in your case. Could be your database is broken somehow or allocated memory is too small.
Nevertheless I improved the query logic to remove it from frontend for next release 6.0.1.
If you want to test the fixes please replace the 2 following files:
..\config-acf\class-avia-acf.php
..\config-templatebuilder\avia-template-builder\php\class-dynamic-content.phpwith
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/enfold_6_0/config-acf/class-avia-acf.php
https://github.com/KriesiMedia/enfold-library/blob/master/temp_fixes/enfold_6_0/config-templatebuilder/avia-template-builder/php/class-dynamic-content.phpBest regards,
GünterHi,
Achtung, dass der Selektor nicht zu schwach ist. :root ist ein sehr starker selector, stärker als html !!!
Würde sicherheitshalber wie in meinem Beispiel nehmen:
html.html_entry_id_46364 , html.html_entry_id_2407
Best regards,
GünterHi,
I forgot to mention that when using HTML markup in toggle title the open toggle title is ignored (there is a message in the description text). This is a limitation – but I think something to live with.
In your test site https://webers-testseite.de/accordion it works as it should – with fixed toggle title as it did before 6.0 where we added the open toggle title option.
@conflock
Did you clear browser cache? See example of @Guenni007.
Can you give me a access to a staging site with full WP admin access where I can see why it is not working ?
Best regards,
GünterHey conflock,
Thank you for reporting this – and sorry for the problems.
Will be fixed in next release.
Meanwhile you can replace the content of folder “..\enfold\config-templatebuilder\avia-shortcodes\toggles\” with the files of:
If you need help let us know and we can do it for you.
In case you have enabled file compression please disable it, save theme options, enable it again and save theme options again.
Best regards,
GünterHi Günter,
Beispiele:
Best regards,
GünterHi,
Ich hatte es kurz einmal am Radar, aber keine schnelle Lösung gesehen. Ist aber nicht vergessen.
Best regards,
GünterHi Martin,
Alles klar. Macht Sinn.
Ich hab es einmal zu den feature requests hinzugefügt, damit ich es nicht vergesse: https://github.com/KriesiMedia/Enfold-Feature-Requests/issues/109
LG,
GünterHi Martin,
Freut mich, dass ich helfen konnte.
dynamische Post-Toggles
Wenn ich das richtig verstehe, möchtest Du ein Toggle Element erstellen, wo man analog wie z.B. bei Masonry eine Kategorie, Custom Post Type Einträge, … filtern kann und aus der Ergebnisliste dann z.B. Post Title als Toggle Titel nimmt und das Excerpt oder Post Content dann als Toggle Content nimmt.
LG aus Wien,
GünterHi Patrick,
thank you for your feedback.
According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/main main tag should be unique and should not contain parts like sidebar, footer, …
Doing a quick check I see that changing div id=”main” to main id=”main” includes footer and sidebar. And various page templates already include the main tag resulting in multiple main tags. And also page as footer setting might add main tags.
I do not see a quick solution for that at the moment – but I will keep an eye on it.
Best regards,
GünterHey janssen-media,
Thank you for using Enfold.
If you choose “wp_post_title” it is always of the current post title where the element is added.
What you need is use of custom fields where you can enter values specific for the post. You can use the ACF plugin for easier handling.
E.g. define “toggle1”, “toggle2” as custom fields, add values there and then use these custom fields as dynamic content.
If you create a custom layout with that toggle you can add this custom layout to any page/post where you need it and then need only fill in the custom fields values as needed.
Hope this helps.
Best regards,
GünterHey Patrick,
Thank you for pointing at the buttons. Missed it.
I added aria-label to the 3 ALB buttons and custom field to Button Title Attribute option.
I will check the HTML “main” tag. That should be no problem. I will also have a look into footer tag – but I’m afraid the risk of breaking existing sites is rather high.
And we appreciate your help to improve accessibility. We will try our best to implement it.
Best regards,
GünterHi,
For 6.0 I added filter avf_form_datepicker_args that allows to change all arguments. See https://github.com/KriesiMedia/enfold-library/blob/master/actions%20and%20filters/ALB%20Elements/Contact%20Form/avf_form_datepicker_args.php
today button
This is the default behaviour of this element.
Best regards,
Günter
